Skip to contentSkip to conversation

new package libhid

PATCH New Sagaert Johan 2 participants 2 messages Jan 22, 2011 – Jan 24, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 new package libhid

The included patch prevents from linking to libusb on the host.

the package files :

diff -rupN buildroot-master/package/libhid/Config.in
buildroot/package/libhid/Config.in
--- buildroot-master/package/libhid/Config.in 1970-01-01
01:00:00.000000000 +0100
+++ buildroot/package/libhid/Config.in 2011-01-29 19:30:49.000000000 +0100
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBHID
+ bool "libhid"
+ depends on BR2_PACKAGE_LIBUSB
+ select BR2_PACKAGE_LIBUSB_COMPAT
+ help
+ Userspace library for accessing USB HID devices
+
+ http://libhid.alioth.debian.org
diff -rupN buildroot-master/package/libhid/Config.in~ buildroot/package/libhid/Config.in~
--- buildroot-master/package/libhid/Config.in~ 1970-01-01
01:00:00.000000000 +0100
+++ buildroot/package/libhid/Config.in~ 2011-01-29 19:27:59.000000000 +0100
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBHID
+ bool "libhid"
+ select BR2_PACKAGE_LIBUSB_COMPAT
+ help
+ Userspace library for accessing USB HID devices
+
+ http://libhid.alioth.debian.org
diff -rupN buildroot-master/package/libhid/libhid.mk buildroot/package/libhid/libhid.mk
--- buildroot-master/package/libhid/libhid.mk 1970-01-01
01:00:00.000000000 +0100
+++ buildroot/package/libhid/libhid.mk 2011-01-30 00:10:11.000000000 +0100
@@ -0,0 +1,15 @@
+#############################################################
+#
+# libhid
+#
+#############################################################
+LIBHID_VERSION = 0.2.16
+LIBHID_SOURCE = libhid-$(LIBHID_VERSION).tar.gz +LIBHID_SITE = http://alioth.debian.org/frs/download.php/1958
+LIBHID_DEPENDENCIES = libusb-compat libusb +LIBHID_INSTALL_STAGING = YES +LIBHID_INSTALL_TARGET = YES
+LIBHID_CONF_OPT = --disable-swig --without-doxygen --disable-package-config
+
+
+$(eval $(call AUTOTARGETS,package,libhid))
diff -rupN buildroot-master/package/libhid/libhid.mk~ buildroot/package/libhid/libhid.mk~
--- buildroot-master/package/libhid/libhid.mk~ 1970-01-01
01:00:00.000000000 +0100
+++ buildroot/package/libhid/libhid.mk~ 2011-01-29 23:29:34.000000000 +0100
@@ -0,0 +1,16 @@
+#############################################################
+#
+# libhid
+#
+#############################################################
+LIBHID_VERSION = 0.2.16
+LIBHID_SOURCE = libhid-$(LIBHID_VERSION).tar.gz +LIBHID_SITE = http://alioth.debian.org/frs/download.php/1958
+LIBHID_DEPENDENCIES = libusb-compat libusb +LIBHID_INSTALL_STAGING = YES +LIBHID_INSTALL_TARGET = YES
+LIBHID_CONF_OPT = --disable-swig --without-doxygen --disable-package-config
+#LIBHID_LIBTOOL_PATCH = YES
+LIBHID_AUTORECONF = YES
+
+$(eval $(call AUTOTARGETS,package,libhid))

#1 lore raw

PATCH 2/2 new package libhid

Hello Sagaert,

Quoted 1 line · On Sat, 22 Jan 2011 20:17:34 +0100 "Sagaert Johan" <[email protected]>…

The included patch prevents from linking to libusb on the host.

The patch below does not seem to match this description.

Moreover, your patch has been word-wrapped by your e-mail client. Could you use git send-email instead ?

Your patch 1/2 (which adds the source package/libhid/Config.in line) should be part of this patch (i.e a single patch for adding the package).

Review line 3

Quoted 9 lines

diff -rupN buildroot-master/package/libhid/Config.in
buildroot/package/libhid/Config.in
--- buildroot-master/package/libhid/Config.in 1970-01-01
01:00:00.000000000 +0100
+++ buildroot/package/libhid/Config.in 2011-01-29 19:30:49.000000000 +0100

(quoted diff) +3 -0
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBHID
+	bool "libhid"
+	depends on BR2_PACKAGE_LIBUSB

This should be a "select" statement, as we do for all library dependencies.

Quoted 5 lines

diff -rupN buildroot-master/package/libhid/Config.in~ buildroot/package/libhid/Config.in~
--- buildroot-master/package/libhid/Config.in~ 1970-01-01
01:00:00.000000000 +0100
+++ buildroot/package/libhid/Config.in~ 2011-01-29 19:27:59.000000000 +0100

Could you use Git to generate your patches in order to not have those backup files in the patch ?

Quoted 12 lines

diff -rupN buildroot-master/package/libhid/libhid.mk buildroot/package/libhid/libhid.mk
--- buildroot-master/package/libhid/libhid.mk 1970-01-01
01:00:00.000000000 +0100
+++ buildroot/package/libhid/libhid.mk 2011-01-30 00:10:11.000000000 +0100

(quoted diff) +6 -0
@@ -0,0 +1,15 @@
+#############################################################
+#
+# libhid
+#
+#############################################################
+LIBHID_VERSION = 0.2.16

Review

Quoted 10 lines
(quoted diff) +9 -1
+LIBHID_SOURCE = libhid-$(LIBHID_VERSION).tar.gz
+LIBHID_SITE = http://alioth.debian.org/frs/download.php/1958
+LIBHID_DEPENDENCIES = libusb-compat libusb
+LIBHID_INSTALL_STAGING = YES
+LIBHID_INSTALL_TARGET = YES
+LIBHID_CONF_OPT = --disable-swig  --without-doxygen
--disable-package-config
+
+
+$(eval $(call AUTOTARGETS,package,libhid))

This .mk file looks good, but I haven't tested it yet.

Could you fix those comments and resend ?

Thanks a lot!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com