Skip to contentSkip to conversation

ui/cocoa.m: blinky mouse cursor fix

PATCH Applied Programmingkid 2 participants 2 messages Sep 27, 2015 – Oct 13, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ui/cocoa.m: blinky mouse cursor fix

The mouse cursor can become blinky when being moved a lot. This patch fixes that problem by issuing the redraw sooner.

---
 ui/cocoa.m |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
ui/cocoa.m +1 -1
index 334e6f6..cf372a4 100644
@@ -1275,6 +1275,7 @@ static void cocoa_refresh(DisplayChangeListener *dcl)
     NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init];
 
     COCOA_DEBUG("qemu_cocoa: cocoa_refresh\n");
+    graphic_hw_update(NULL);
 
     if (qemu_input_is_absolute()) {
         if (![cocoaView isAbsoluteEnabled]) {
@@ -1295,7 +1296,6 @@ static void cocoa_refresh(DisplayChangeListener *dcl)
             [cocoaView handleEvent:event];
         }
     } while(event != nil);
-    graphic_hw_update(NULL);
     [pool release];
 }
 
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 30 lines · Programmingkid

The mouse cursor can become blinky when being moved a lot. This patch fixes that problem by issuing the redraw sooner.

---
 ui/cocoa.m |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
ui/cocoa.m +1 -2
index 334e6f6..cf372a4 100644
@@ -1275,6 +1275,7 @@ static void cocoa_refresh(DisplayChangeListener *dcl)
     NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init];
 
     COCOA_DEBUG("qemu_cocoa: cocoa_refresh\n");
+    graphic_hw_update(NULL);
 
     if (qemu_input_is_absolute()) {
         if (![cocoaView isAbsoluteEnabled]) {
@@ -1295,7 +1296,6 @@ static void cocoa_refresh(DisplayChangeListener *dcl)
             [cocoaView handleEvent:event];
         }
     } while(event != nil);
-    graphic_hw_update(NULL);
     [pool release];
 }
 
--
Quoted 1 line

1.7.5.4

Thanks, applied to cocoa.next. (This brings us into line with the other UI front ends which update the graphics first and process events second.)

-- PMM