cstart: Fix typo in i386's cstart assembly
PATCH 1/1 cstart: Fix typo in i386's cstart assembly
Replace a '%' with a '$' to encode a literal in when initializing CR4. This fixes the build on i386 as gcc complains about a non-existent register.
x86/cstart.S: Assembler messages:
x86/cstart.S:128: Error: bad register name `%(1<<4)' Makefile:101: recipe for target 'x86/cstart.o' failed
--- x86/cstart.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
x86/cstart.S +1 -1
@@ -125,7 +125,7 @@ start: jmpl $8, $start32 prepare_32: - mov %(1 << 4), %eax // pse + mov $(1 << 4), %eax // pse mov %eax, %cr4 mov $pt, %eax
Signature · 1 line
2.26.0
Quoted 5 lines · Sean Christopherson
Replace a '%' with a '$' to encode a literal in when initializing CR4. This fixes the build on i386 as gcc complains about a non-existent register.
( I should have noticed it before )
Quoted 10 lines · On Mon, 13 Jul 2020 21:19:05 -0700 Sean Christopherson…
Replace a '%' with a '$' to encode a literal in when initializing CR4. This fixes the build on i386 as gcc complains about a non-existent register.
x86/cstart.S: Assembler messages:
x86/cstart.S:128: Error: bad register name `%(1<<4)' Makefile:101: recipe for target 'x86/cstart.o' failedFixes d86ef58519645 ("cstart: do not assume CR4 starts as zero")Signed-off-by Sean Christopherson <[email protected]>
Quoted 17 lines
--- x86/cstart.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)x86/cstart.S +1
-1@@ -125,7 +125,7 @@ start: jmpl $8, $start32 prepare_32: - mov %(1 << 4), %eax // pse + mov $(1 << 4), %eax // pse mov %eax, %cr4 mov $pt, %eax