fix error case of xen

Curret kdump-xen with makdumpfile always return 0. So if we fail to kdump, we will get $?=0. This patch improve it.

Signed-off-by Akio Takebe <[email protected]>

Hi Takebe-san,

Thank you for the patch.

Quoted 6 lines · Akio Takebe

Curret kdump-xen with makdumpfile always return 0. So if we fail to kdump, we will get $?=0. This patch improve it.

Signed-off-by Akio Takebe <[email protected]>

makedumpfile.c get_symbol_addr(char *symname) · line 997

Quoted 8 lines

makedumpfile.c +2 -0

@@ -993,6 +993,8 @@ get_symbol_addr(char *symname)
 		if (!strcmp(sym_name, symname)) {
 			symbol = sym.st_value;
 			break;
+		} else if (i >= (shdr.sh_size/shdr.sh_entsize)-1) {
+			DEBUG_MSG("Can't get symbol of %s.\n", symname);

This patch is for fixing error code of xen, but the above code adds the debugging message. So the above code doesn't match its purpose. Is it necessary ?

Quoted 7 lines

Quoted 6 lines · Akio Takebe

Curret kdump-xen with makdumpfile always return 0. So if we fail to kdump, we will get $?=0. This patch improve it.

Signed-off-by Akio Takebe <[email protected]>

Quoted 12 lines

makedumpfile.c get_symbol_addr(char *symname) · line 997

Quoted 8 lines

makedumpfile.c +2 -0

@@ -993,6 +993,8 @@ get_symbol_addr(char *symname)
 		if (!strcmp(sym_name, symname)) {
 			symbol = sym.st_value;
 			break;
+		} else if (i >= (shdr.sh_size/shdr.sh_entsize)-1) {
+			DEBUG_MSG("Can't get symbol of %s.\n", symname);

This patch is for fixing error code of xen, but the above code adds the debugging message. So the above code doesn't match its purpose. Is it necessary ?

Sorry for incomprehensible comment.

The existences of symbols depend on linux version, cpu architecture, and linux configuration (.config file). If the above code is merged, the debugging message will be big and unreadable.
Do you want to know the lacks of necessary symbol for dump filtering of Xen ? -D option prints them.

makedumpfile.c main(int argc, char *argv[]) · line 6150

Quoted 4 lines

makedumpfile.c renamed from v1.2.5/makedumpfile.c +2 -1

-		return handle_xen();
+		if (!handle_xen())
+			goto out;

I guess that the above code is not enough. If handle_xen() succeeds, it should return TRUE instead of COMPLETED like the attached patch, right ?

Thanks
Ken'ichi Ohmichi

Signed-off-by Akio Takebe <[email protected]>

Signed-off-by Ken'ichi Ohmichi <[email protected]>

---
diff -puN backup/v1.2.5/makedumpfile.c makedumpfile/makedumpfile.c

makedumpfile.c renamed from v1.2.5/makedumpfile.c +1 -1

@@ -5855,7 +5855,7 @@ handle_xen()
 	MSG("\n");
 	MSG("The dumpfile is saved to %s.\n", info->name_dumpfile);
 
-	return COMPLETED;
+	return TRUE;

out:

	return FALSE;

#endif

Quoted 2 lines

I guess that the above code is not enough. If handle_xen() succeeds, it should return TRUE instead of COMPLETED like the attached patch, right ?

You're right!
Your patch looks good, thank you very much for your review.