Skip to contentSkip to conversation

Fix c/s 19510

PATCH In review Masaki Kanno 1 participant 2 messages Apr 8, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix c/s 19510

Hi Keir,

Sorry, my patch (c/s 19510) includes a bug.
Could you apply an attaching patch?

Best regards,
Kan

tools/python/xen/xend/server/pciif.py +4 -4
diff -r d9de5cc2b0bc tools/python/xen/xend/server/pciif.py
@@ -71,6 +71,10 @@ class PciController(DevController):
         pcidevid = 0
         vslots = ""
         for pci_config in config.get('devs', []):
+            vslot = pci_config.get('vslot')
+            if vslot is not None:
+                vslots = vslots + vslot + ";"
+
             domain = parse_hex(pci_config.get('domain', 0))
             bus = parse_hex(pci_config.get('bus', 0))
             slot = parse_hex(pci_config.get('slot', 0))
@@ -82,10 +86,6 @@ class PciController(DevController):
                 opts = map(lambda (x, y): x+'='+y, opts)
                 opts = reduce(lambda x, y: x+','+y, opts)
                 back['opts-%i' % pcidevid] = opts
-
-            vslot = pci_config.get('vslot')
-            if vslot is not None:
-                vslots = vslots + vslot + ";"
 
             back['dev-%i' % pcidevid] = "%04x:%02x:%02x.%01x" % \
                                         (domain, bus, slot, func)

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw

Without the patch, HVM domain creations fail that PCI pass-through devices are assigned.

Best regards,
Kan

Quoted 16 lines · Masaki Kanno

Hi Keir,

Sorry, my patch (c/s 19510) includes a bug.
Could you apply an attaching patch?

Best regards,
Kan

-------------------------------text/plain-------------------------------
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel