Skip to contentSkip to conversation

Enable more HP machine to enable mute led

PATCH Kailang 2 participants 5 messages Jun 13, 2014 – Jun 18, 2014 Sound

lore
Share & tools
lore

Kailang

author
#0 lore raw

Hi Takashi,

Add more HP machine to support mute led functions.

Thanks.

BR,
Kailang

Quoted 1 line

From f06f78fc2fd45c004ab512b77b4e1945bb52ffda Mon Sep 17 00:00:00 2001

From: Kailang Yang <[email protected]>
Date: Fri, 13 Jun 2014 17:16:31 +0800
Subject: [PATCH] ALSA: hda/realtek - Add more entry for enable HP mute led

More HP machine need mute led support.

sound/pci/hda/patch_realtek.c +14 -0
index 9c095fa..874647c 100644
@@ -4774,14 +4774,24 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x1983, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x218b, "HP", ALC269_FIXUP_LIMIT_INT_MIC_BOOST_MUTE_LED),
 	/* ALC282 */
+	SND_PCI_QUIRK(0x103c, 0x220d, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x220e, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x220f, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x2210, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x2211, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x2212, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x2213, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x2214, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x2266, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x2267, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x2268, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x2269, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x226a, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x226b, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x226c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x226d, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x226e, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x226f, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x227a, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x227b, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x229e, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
@@ -4821,6 +4831,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x22c8, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x22c3, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x22c4, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x2334, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x2335, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x2336, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+	SND_PCI_QUIRK(0x103c, 0x2337, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK_VENDOR(0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED),
 	SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
 	SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
#1 lore raw

At Fri, 13 Jun 2014 17:27:31 +0800,

Quoted 4 lines · Kailang

Hi Takashi,

Add more HP machine to support mute led functions.

Applied this now as is. But, the table looks bigger and bigger, which I don't like any more.

So, all these devices have no indication of mute LED in any DMI or whatever entries? In the past, most of HP machines had a DMI string showing the mute LED capability.

thanks,

Takashi

author
#2 lore raw
Quoted 5 lines

At Fri, 13 Jun 2014 17:27:31 +0800,

Quoted 3 lines · Kailang

Hi Takashi,

Quoted 9 lines
Quoted 1 line

Add more HP machine to support mute led functions.

Applied this now as is. But, the table looks bigger and bigger, which I don't like any more.

So, all these devices have no indication of mute LED in any DMI or whatever entries? In the past, most of HP machines had a DMI string showing the mute LED capability.

I will trace this.
But as i know, there are no DMI entries for realtek case. I don't like to add this, too. ^^

Thanks a lot.

Quoted 6 lines

thanks,

Takashi

------Please consider the environment before printing this e-mail.

author
#3 lore raw
In reply to Takashi Iwai
Quoted 5 lines

At Fri, 13 Jun 2014 17:27:31 +0800,

Quoted 3 lines · Kailang

Hi Takashi,

Quoted 9 lines
Quoted 1 line

Add more HP machine to support mute led functions.

Applied this now as is. But, the table looks bigger and bigger, which I don't like any more.

So, all these devices have no indication of mute LED in any DMI or whatever entries? In the past, most of HP machines had a DMI string showing the mute LED capability.

HP says that was support for IDT only.
If we want to use this string, we need to discuss with their BIOS manager. We will try to go this feature.

HP has new platform that had speaker mute led and capture mute led. HP_MUTE_LED_P_G => DMI string was not enough field for two leds. Do you have any idea for dmi string?

HP_MUTE_LED_P_G_G => last G for second led for capture mute led

Quoted 6 lines

thanks,

Takashi

------Please consider the environment before printing this e-mail.

#4 lore raw

At Wed, 18 Jun 2014 11:49:40 +0800,

Quoted 20 lines · Kailang
Quoted 6 lines

At Fri, 13 Jun 2014 17:27:31 +0800,

Quoted 3 lines · Kailang

Hi Takashi,

Quoted 9 lines
Quoted 1 line

Add more HP machine to support mute led functions.

Applied this now as is. But, the table looks bigger and bigger, which I don't like any more.

So, all these devices have no indication of mute LED in any DMI or whatever entries? In the past, most of HP machines had a DMI string showing the mute LED capability.

HP says that was support for IDT only.
If we want to use this string, we need to discuss with their BIOS manager. We will try to go this feature.

Quoted 5 lines

HP has new platform that had speaker mute led and capture mute led. HP_MUTE_LED_P_G => DMI string was not enough field for two leds. Do you have any idea for dmi string?

HP_MUTE_LED_P_G_G => last G for second led for capture mute led

This would work. If the mic LED might have a different polarity, it can be P_G_P_G, too.

thanks,

Takashi

Quoted 8 lines
Quoted 7 lines

thanks,

Takashi

------Please consider the environment before printing this e-mail.