Skip to contentSkip to conversation

OCFS + QUOTA - Many errors in dmesg - Mayby fix that?

Ocfs2-devel In review Marek Królikowski 3 participants 4 messages Aug 15, 2012

Subsystems (2)
VFS OCFS2
lore
Share & tools
lore

Marek Królikowski

author
#0 lore raw

Hey
I see You remove ocfs2_global_read_info errors from dmesg can You remove other stupid errors too? I got kernel 3.2.27 with enable quota on OCFS2 and i got many many errors likes:

(local,19395,1):ocfs2_write_begin:1953 ERROR: status = ?122

(courier-imapd,23881,13):ocfs2_rename:1474 ERROR: status = -122

(courier-imapd,23881,13):ocfs2_extend_dir:3363 ERROR: status = -122

(courier-imapd,23881,13):ocfs2_prepare_dx_dir_for_insert:4305 ERROR: status = -122

(local,32013,3):ocfs2_link:678 ERROR: status = -122

(local,32013,3):ocfs2_prepare_dir_for_insert:4392 ERROR: status = -122

(courier-imapd,27444,19):ocfs2_mknod:459 ERROR: status = -122

(courier-imapd,27444,19):ocfs2_create:629 ERROR: status = -122

s2_prepare_dir_for_insert:4367 ERROR: status = ?122

This all errors is when someone is over quota and try use imap/pop3/postfix.

Thanks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20120815/9db5abb9/attachment.html

maintainer
#1 lore raw
Quoted 5 lines · Marek Kr?likowski

Hey
I see You remove ocfs2_global_read_info errors from dmesg can You remove other stupid errors too? I got kernel 3.2.27 with enable quota on OCFS2 and i got many many errors likes:

(local,19395,1):ocfs2_write_begin:1953 ERROR: status = ?122

<snip>

You shouldn't see any of these. Patch coming.

Joel

Signature · 6 lines
Life's Little Instruction Book #444

	"Never underestimate the power of a kind word or deed."

			http://www.jlbec.org/
			jlbec at evilplan.org
maintainer
#2 lore raw

PATCH 1/1 ocfs2: Don't spam on -EDQUOT.

EDQUOT is a user-visible error, not a logic problem. Teach mlog_errno() to ignore it like it ignores -ENOSPC, etc.

Signed-off-by Joel Becker <[email protected]>
Cc Jan Kara <[email protected]>
Reported-by Marek Kr?likowski <[email protected]>
---
 fs/ocfs2/cluster/masklog.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/ocfs2/cluster/masklog.h +2 -1
index baa2b9e..2260fb9 100644
@@ -199,7 +199,8 @@ extern struct mlog_bits mlog_and_bits, mlog_not_bits;
 #define mlog_errno(st) do {						\
 	int _st = (st);							\
 	if (_st != -ERESTARTSYS && _st != -EINTR &&			\
-	    _st != AOP_TRUNCATED_PAGE && _st != -ENOSPC)		\
+	    _st != AOP_TRUNCATED_PAGE && _st != -ENOSPC &&		\
+	    _st != -EDQUOT)						\
 		mlog(ML_ERROR, "status = %lld\n", (long long)_st);	\
 } while (0)
Signature · 1 line
1.7.7.3
reviewer Reviewed-by on v1 1/1
#3 lore raw

Re: [PATCH] ocfs2: Don't spam on -EDQUOT.

Quoted 2 lines · Joel Becker

EDQUOT is a user-visible error, not a logic problem. Teach mlog_errno() to ignore it like it ignores -ENOSPC, etc.

Looks sane. You can add:

Reviewed-by Jan Kara <[email protected]>

Honza

Quoted 25 lines
Signed-off-by Joel Becker <[email protected]>
Cc Jan Kara <[email protected]>
Reported-by Marek Kr?likowski <[email protected]>
---
 fs/ocfs2/cluster/masklog.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/ocfs2/cluster/masklog.h +2 -1
index baa2b9e..2260fb9 100644
@@ -199,7 +199,8 @@ extern struct mlog_bits mlog_and_bits, mlog_not_bits;
 #define mlog_errno(st) do {						\
 	int _st = (st);							\
 	if (_st != -ERESTARTSYS && _st != -EINTR &&			\
-	    _st != AOP_TRUNCATED_PAGE && _st != -ENOSPC)		\
+	    _st != AOP_TRUNCATED_PAGE && _st != -ENOSPC &&		\
+	    _st != -EDQUOT)						\
 		mlog(ML_ERROR, "status = %lld\n", (long long)_st);	\
 } while (0)
Signature · 1 line
1.7.7.3
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR