Skip to contentSkip to conversation

lighttpd: Set SYSTEMD_PACKAGES as lighttpd-systemd.

meta-openembedded Elvis Dowson 2 participants 4 messages Jun 22, 2012 – Jun 28, 2012

lore
Share & tools
lore
#0 lore raw

This commit fixes WARNING:
/tool/yocto/poky/meta/recipes-extended/lighttpd/lighttpd_1.4.30.bb:
it is recommended to set SYSTEMD_PACKAGES as <existing-package>-systemd

---
 .../lighttpd/lighttpd_1.4.30.bbappend              |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-extended/lighttpd/lighttpd_1.4.30.bbappend +1 -1
index 1341405..b02f35c 100644
@@ -6,5 +6,5 @@ inherit systemd
 
 SRC_URI += "file://lighttpd.service"
 
-SYSTEMD_PACKAGES = "${PN}"
+SYSTEMD_PACKAGES = "${PN}-systemd"
 SYSTEMD_SERVICE_${PN} = "lighttpd.service"
Signature · 1 line
1.7.9.5
#1 lore raw

Hi,
I sent this patch a while back, and this still hasn't been applied. I just did a git pull and noticed this. Its a trivial patch, so would it be possible for someone to please apply it.

Elvis

Quoted 23 lines · Elvis Dowson

This commit fixes WARNING:
/tool/yocto/poky/meta/recipes-extended/lighttpd/lighttpd_1.4.30.bb:
it is recommended to set SYSTEMD_PACKAGES as <existing-package>-systemd

---
.../lighttpd/lighttpd_1.4.30.bbappend | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-extended/lighttpd/lighttpd_1.4.30.bbappend +0 -0
index 1341405..b02f35c 100644
@@ -6,5 +6,5 @@ inherit systemd
 

SRC_URI += "file://lighttpd.service"

meta-oe/recipes-extended/lighttpd/lighttpd_1.4.30.bbappend +1 -1
-SYSTEMD_PACKAGES = "${PN}"
+SYSTEMD_PACKAGES = "${PN}-systemd"

SYSTEMD_SERVICE_${PN} = "lighttpd.service"

Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 2 lines · Elvis Dowson

Hi,
I sent this patch a while back, and this still hasn't been applied. I just did a git pull and noticed this. Its a trivial patch, so would it be possible for someone to please apply it.

It's trivial but if some image or task had lighttpd in RDEPENDS then it got also systemd support with it.. so those images/tasks need to be fixed too.

I don't have such task/image, just explaining that it's not so trivial as this..

Cheers,

Quoted 34 lines

Elvis

Quoted 19 lines · Elvis Dowson

This commit fixes WARNING:
/tool/yocto/poky/meta/recipes-extended/lighttpd/lighttpd_1.4.30.bb:
it is recommended to set SYSTEMD_PACKAGES as <existing-package>-systemd

---
.../lighttpd/lighttpd_1.4.30.bbappend | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-extended/lighttpd/lighttpd_1.4.30.bbappend +0 -0
index 1341405..b02f35c 100644
@@ -6,5 +6,5 @@ inherit systemd
 

SRC_URI += "file://lighttpd.service"

meta-oe/recipes-extended/lighttpd/lighttpd_1.4.30.bbappend +1 -1
-SYSTEMD_PACKAGES = "${PN}"
+SYSTEMD_PACKAGES = "${PN}-systemd"
Quoted 4 lines

SYSTEMD_SERVICE_${PN} = "lighttpd.service"

Signature · 1 line
1.7.9.5

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw

HI Martin,

Quoted 6 lines · Martin Jansa
Quoted 1 line · Elvis Dowson

I sent this patch a while back, and this still hasn't been applied. I just did a git pull and noticed this. Its a trivial patch, so would it be possible for someone to please apply it.

It's trivial but if some image or task had lighttpd in RDEPENDS then it got also systemd support with it.. so those images/tasks need to be fixed too.

I did a full clean build, and the last three patches squashed all warnings for the following layers:

BBLAYERS ?= " \
/tool/yocto/poky/meta \
/tool/yocto/poky/meta-yocto \
/tool/yocto/meta-openembedded/meta-oe \
/tool/yocto/meta-xilinx \
"

I guess if someone else encounters some issues, they can fix recipes in their meta-layers accordingly.

Best regards,

Elvis Dowson