Improve error message about xm pause/unpase command
PATCH 1/1 Improve error message about xm pause/unpase command
Hi,
This patch improves error messages about xm pause/unpause command.
Without this patch you see:
# xm pause Domain-0 Error: Domain unable to be paused: (22, 'Invalid argument') Usage: xm pause <Domain>
Pause execution of a domain.
# xm unpause Domain-0 Error: Domain unable to be unpaused: (22, 'Invalid argument') Usage: xm unpause <Domain>
Unpause a paused domain.
With this patch applied:
# xm pause Domain-0 Error: Cannot pause privileged domain Domain-0 Usage: xm pause <Domain>
Pause execution of a domain.
# xm unpause Domain-0 Error: Cannot unpause privileged domain Domain-0 Usage: xm unpause <Domain>
Unpause a paused domain.
Signed-off-by Masaki Kanno <[email protected]>
Best regards,
Kan
tools/python/xen/xend/XendDomain.py +4 -2
@@ -948,10 +948,10 @@ class XendDomain: dominfo = self.domain_lookup_nr(domid) if not dominfo: raise XendInvalidDomain(str(domid)) - + if dominfo.getDomid() == DOM0_ID: + raise XendError("Cannot unpause privileged domain %s" % domid) log.info("Domain %s (%d) unpaused.", dominfo.getName(), int(dominfo.getDomid())) - dominfo.unpause() except XendInvalidDomain: log.exception("domain_unpause")
@@ -973,6 +973,8 @@ class XendDomain: dominfo = self.domain_lookup_nr(domid) if not dominfo: raise XendInvalidDomain(str(domid)) + if dominfo.getDomid() == DOM0_ID: + raise XendError("Cannot pause privileged domain %s" % domid) log.info("Domain %s (%d) paused.", dominfo.getName(), int(dominfo.getDomid())) dominfo.pause()
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Ewan Mellor
AppliedQuoted 3 lines · Masaki Kanno
Hi,
This patch improves error messages about xm pause/unpause command.
Applied, thank you.
Ewan.