Skip to contentSkip to conversation

setup.sh: install feature version which meets minimum version required

PATCH Superseded Tim Orling 1 participant 2 messages Jan 25, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Tim Orling

author
#0 lore raw

PATCH 1/1 setup.sh: install feature version which meets minimum version required

From: Chin Huat Ang <[email protected]>

When only minimum version is specified, install feature with version closest to the minimum specified.

---
 scripts/setup.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
scripts/setup.sh +6 -2
index 4b160ea16c4..024596bfb1e 100755
@@ -228,8 +228,12 @@ update_feature_remote()
       done
   else
       #only has minimum version requirement
-      local max_remote_ver="`get_version $1 $2 'max'`"
-      [ "$max_remote_ver" \> "$3" ] || [ "$max_remote_ver" = "$3" ] && installIU=$max_remote_ver
+      for i in $all_versions; do
+        if [ "$i" \> "$3" ] || [ "$i" = "$3" ]; then
+          installIU=$i
+          break
+        fi
+      done
   fi
 
   [ "x$installIU" = "x" ] && err_exit 1 "Can NOT find candidates of $2 version($3, $4) at $1!"
Signature · 1 line
2.13.6
author
#1 lore raw

Please note that there is a new eclipse-poky mailing list and we will stop sending these patches to [email protected] soon (we will announce the change, but this is the second heads up).

If you are interested in following eclipse-poky development, please register for the new list.

https://lists.yoctoproject.org/listinfo/eclipse-poky

Review comments for our own patches will be on the new list while we transition. We will comment on community patches sent to [email protected] that they should be sent to the new list.

Quoted 35 lines · Tim Orling

From: Chin Huat Ang <[email protected]>

When only minimum version is specified, install feature with version closest to the minimum specified.

---
scripts/setup.sh | 8 ++++++--

1 file changed, 6 insertions(+), 2 deletions(-)
scripts/setup.sh +6 -2
index 4b160ea16c4..024596bfb1e 100755
@@ -228,8 +228,12 @@ update_feature_remote()
      done
  else
      #only has minimum version requirement
-      local max_remote_ver="`get_version $1 $2 'max'`"
-      [ "$max_remote_ver" \> "$3" ] || [ "$max_remote_ver" = "$3" ] && installIU=$max_remote_ver
+      for i in $all_versions; do
+        if [ "$i" \> "$3" ] || [ "$i" = "$3" ]; then
+          installIU=$i
+          break
+        fi
+      done
  fi
 
  [ "x$installIU" = "x" ] && err_exit 1 "Can NOT find candidates of $2 version($3, $4) at $1!"
Signature · 1 line
2.13.6