Skip to contentSkip to conversation

Memory management bug

DISCUSSION [email protected] 1 participant 1 message Nov 15, 2000

lore
Share & tools
lore

[email protected]

author
#0 lore raw
Quoted 10 lines

Review

Quoted 7 lines
(quoted diff) +3 -0
+extern pte_t empty_bad_pte_table[];
 extern __inline__ void free_pte_fast(pte_t *pte)
 {
+       if (pte == empty_bad_pte_table)
+               return;

I guess that should be BUG() instead of return, so that the callers can be fixed.

Not really. pte_free and pmd_free are called from the common mm code but the concept of empty_bad_{pte,pmd}_table is architecture dependent. The trouble starts in arch/???/mm/init.c where these special arrays are inserted into the paging tables. So the solution to the problem should be in architecture dependent files too.

blue skies,
Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: [email protected]

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/