provide uniqe x2apicid for each vcpu in the cpuid leaf 0xb
PATCH 1/1 provide uniqe x2apicid for each vcpu in the cpuid leaf 0xb
Keir,
Just like the apicid, x2apicid is also unique to each cpu. x2apicid is coming from edx register of the cpuid leaf 0xb.
Please Apply/comment.
xen/arch/x86/hvm/hvm.c +4 -0
@@ -1687,6 +1687,10 @@ *ebx |= (v->vcpu_id *2 ) <<24 ;if (vlapic_hw_disabled (vcpu_vlapic (v)) )__clear_bit (X86_FEATURE_APIC &31 , edx); + }else if ( input ==0x0000000b ) + { +/* fix the x2apicid */ + *edx = v->vcpu_id *2 ; } }
What's the point of emulating an x2apicid when we don't emulate an x2apic?
-- Keir
Quoted 25 lines · Nitin A Kamble
Keir,
Just like the apicid, x2apicid is also unique to each cpu. x2apicid is coming from edx register of the cpuid leaf
0xb.Please Apply/comment.
Signed-off-by Nitin A Kamble <[email protected]>diff -r
08618cd10522xen/arch/x86/hvm/hvm.cxen/arch/x86/hvm/hvm.c Mon May 04 14:19:05 2009 -0700 renamed from xen/arch/x86/hvm/hvm.c Mon May 04 14:13:49 2009 -0700 +4
-0@@ -1687,6 +1687,10 @@ *ebx |= (v->vcpu_id * 2) << 24; if ( vlapic_hw_disabled(vcpu_vlapic(v)) ) __clear_bit(X86_FEATURE_APIC & 31, edx); + } else if ( input == 0x0000000b ) + { + /* fix the x2apicid */ + *edx = v->vcpu_id * 2; } }
Keir,
It is be used to find out the extended cpu topology of specified in the leaf 0xb.
Thanks & Regards,
Nitin
Linux Open Source Technology Center, Intel Corporation
----------------------------------------------------------------------------
The Mind is like a parachute; it works much better when it's open.
Quoted 40 lines
-----Original Message-----
From: Keir Fraser [mailto:[email protected]]
Sent: Thursday, May 07, 2009 12:05 AM
To: Kamble, Nitin A
Cc: [email protected]
Subject: Re: [patch] provide uniqe x2apicid for each vcpu in the cpuid leaf0xbWhat's the point of emulating an x2apicid when we don't emulate an x2apic?
-- Keir
Quoted 25 lines · Nitin A Kamble
Keir,
Just like the apicid, x2apicid is also unique to each cpu. x2apicid is coming from edx register of the cpuid leaf
0xb.Please Apply/comment.
Signed-off-by Nitin A Kamble <[email protected]>diff -r
08618cd10522xen/arch/x86/hvm/hvm.cxen/arch/x86/hvm/hvm.c Mon May 04 14:19:05 2009 -0700 renamed from xen/arch/x86/hvm/hvm.c Mon May 04 14:13:49 2009 -0700 +4
-0@@ -1687,6 +1687,10 @@ *ebx |= (v->vcpu_id * 2) << 24; if ( vlapic_hw_disabled(vcpu_vlapic(v)) ) __clear_bit(X86_FEATURE_APIC & 31, edx); + } else if ( input == 0x0000000b ) + { + /* fix the x2apicid */ + *edx = v->vcpu_id * 2; } }
Hm, ok, well I think it is a pretty inoffensive patch anyway. I can queue it for post 3.4.
- Keir
Quoted 51 lines · Nitin A
Keir,
It is be used to find out the extended cpu topology of specified in the
leaf0xb.Thanks & Regards,
Nitin
Linux Open Source Technology Center, Intel Corporation
----------------------------------------------------------------------------
The Mind is like a parachute; it works much better when it's open.Quoted 40 lines
-----Original Message-----
From: Keir Fraser [mailto:[email protected]]
Sent: Thursday, May 07, 2009 12:05 AM
To: Kamble, Nitin A
Cc: [email protected]
Subject: Re: [patch] provide uniqe x2apicid for each vcpu in the cpuid leaf0xbWhat's the point of emulating an x2apicid when we don't emulate an x2apic?
-- Keir
Quoted 25 lines · Nitin A Kamble
Keir,
Just like the apicid, x2apicid is also unique to each cpu. x2apicid is coming from edx register of the cpuid leaf
0xb.Please Apply/comment.
Signed-off-by Nitin A Kamble <[email protected]>diff -r
08618cd10522xen/arch/x86/hvm/hvm.cxen/arch/x86/hvm/hvm.c Mon May 04 14:19:05 2009 -0700 renamed from xen/arch/x86/hvm/hvm.c Mon May 04 14:13:49 2009 -0700 +4
-0@@ -1687,6 +1687,10 @@ *ebx |= (v->vcpu_id * 2) << 24; if ( vlapic_hw_disabled(vcpu_vlapic(v)) ) __clear_bit(X86_FEATURE_APIC & 31, edx); + } else if ( input == 0x0000000b ) + { + /* fix the x2apicid */ + *edx = v->vcpu_id * 2; } }
Thank you!
Quoted 65 lines
Hm, ok, well I think it is a pretty inoffensive patch anyway. I can queue it
for post 3.4.- Keir
Quoted 2 lines · Nitin A
Keir,
It is be used to find out the extended cpu topology specified inthe
Quoted 6 lines
leaf
0xb.Thanks & Regards,
Nitin
Linux Open Source Technology Center, Intel Corporation
----------------------------------------------------------------------------
Quoted 8 lines
The Mind is like a parachute; it works much better when it's open.
Quoted 6 lines
-----Original Message-----
From: Keir Fraser [mailto:[email protected]]
Sent: Thursday, May 07, 2009 12:05 AM
To: Kamble, Nitin A
Cc: [email protected]
Subject: Re: [patch] provide uniqe x2apicid for each vcpu in the cpuidleaf
Quoted 3 lines
Quoted 3 lines
0xbWhat's the point of emulating an x2apicid when we don't emulate an
x2apic?
Quoted 32 lines
Quoted 31 lines
-- Keir
Quoted 25 lines · Nitin A Kamble
Keir,
Just like the apicid, x2apicid is also unique to each cpu. x2apicid is coming from edx register of the cpuid leaf
0xb.Please Apply/comment.
Signed-off-by Nitin A Kamble <[email protected]>diff -r
08618cd10522xen/arch/x86/hvm/hvm.cxen/arch/x86/hvm/hvm.c Mon May 04 14:19:05 2009 -0700 renamed from xen/arch/x86/hvm/hvm.c Mon May 04 14:13:49 2009 -0700 +4
-0@@ -1687,6 +1687,10 @@ *ebx |= (v->vcpu_id * 2) << 24; if ( vlapic_hw_disabled(vcpu_vlapic(v)) ) __clear_bit(X86_FEATURE_APIC & 31, edx); + } else if ( input == 0x0000000b ) + { + /* fix the x2apicid */ + *edx = v->vcpu_id * 2; } }