cpu_user_regs * to __smp_call_function_interrupt
PATCH 1/1 cpu_user_regs * to __smp_call_function_interrupt
Hi,
Following simple and tiny patch will help prevent many un-necessary ifdef's in kdb, if you'll please apply.
Thanks,
Mukesh
xen/arch/x86/smp.c +4 -4
@@ -223,7 +223,7 @@* Structure and data for smp_call_function()/on_selected_cpus(). */ -static void __smp_call_function_interrupt (void ); +static void __smp_call_function_interrupt (struct cpu_user_regs *);static DEFINE_SPINLOCK (call_lock); static struct call_data_struct { void (*func) (void *info);
@@ -273,7 +273,7 @@if (cpu_isset (smp_processor_id (), call_data.selected) ) {local_irq_disable (); -__smp_call_function_interrupt (); +__smp_call_function_interrupt (NULL );local_irq_enable (); }
@@ -341,7 +341,7 @@perfc_incr (ipis); } -static void __smp_call_function_interrupt (void ) +static void __smp_call_function_interrupt (struct cpu_user_regs *regs) {void (*func)(void *info) = call_data.func;void *info = call_data.info;
@@ -371,5 +371,5 @@ {ack_APIC_irq ();perfc_incr (ipis); -__smp_call_function_interrupt (); +__smp_call_function_interrupt (regs); }
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Quoted 2 lines · Mukesh Rathor
Following simple and tiny patch will help prevent many un-necessary ifdef's in kdb, if you'll please apply.
Passing a new paramter to a function which then ignores it is pointless. I'll consider this as part of a patch that actually does something with it.
-- Keir
Quoted 9 lines · Keir Fraser
Quoted 2 lines · Mukesh Rathor
Following simple and tiny patch will help prevent many un-necessary ifdef's in kdb, if you'll please apply.
Passing a new paramter to a function which then ignores it is pointless. I'll consider this as part of a patch that actually does something with it.
-- Keir
It does, but in ext/debuggers.hg tree. Fine, I'll just nag you more now to pull in the debuggers in mainline :).
thanks,
Mukesh
Quoted 7 lines · Mukesh Rathor
Quoted 4 lines
Passing a new paramter to a function which then ignores it is pointless. I'll consider this as part of a patch that actually does something with it.
-- Keir
It does, but in ext/debuggers.hg tree. Fine, I'll just nag you more now to pull in the debuggers in mainline :).
It's like a 10-line patch. Just carry it!
-- Keir