e2fsck: fix problem comments to match actual message
PATCH 1/1 e2fsck: fix problem comments to match actual message
Fix the e2fsck problem comments to match the actual message printed, so that it is possible to find the problem code when searching by the message.
--- e2fsck/problem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
e2fsck/problem.c +2 -2
@@ -1118,12 +1118,12 @@ static struct e2fsck_problem problem_table[] = {N_ ("@n @i number for '.' in @d @i %i.\n" ), PROMPT_FIX, 0 }, -/* Directory entry has bad inode number */ +/* Entry 'xxxx' in /a/b/c has bad inode number.*/ { PR_2_BAD_INO,N_ ("@E has @n @i #: %Di.\n" ), PROMPT_CLEAR, 0 }, -/* Directory entry has deleted or unused inode */ +/* Entry 'xxxx' in /a/b/c has deleted/unused inode nnnnn.*/ { PR_2_UNUSED_INODE,N_ ("@E has @D/unused @i %Di. " ), PROMPT_CLEAR, PR_PREEN_OK },
Signature · 1 line
1.7.11.5
Quoted 3 lines · Andreas
Fix the e2fsck problem comments to match the actual message printed, so that it is possible to find the problem code when searching by the message.
Ted,
have you thought about getting rid of the error message compression in e2fsck? I think the compression isn't useful anymore, and the escape codes makes it much harder to debug and understand the code.
Cheers, Andreas
Quoted 28 lines
Signed-off-by Andreas Dilger <[email protected]>---
e2fsck/problem.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)e2fsck/problem.c +2
-2@@ -1118,12 +1118,12 @@ static struct e2fsck_problem problem_table[] = {N_ ("@n @i number for '.' in @d @i %i.\n" ), PROMPT_FIX, 0 }, -/* Directory entry has bad inode number */ +/* Entry 'xxxx' in /a/b/c has bad inode number.*/ { PR_2_BAD_INO,N_ ("@E has @n @i #: %Di.\n" ), PROMPT_CLEAR, 0 }, -/* Directory entry has deleted or unused inode */ +/* Entry 'xxxx' in /a/b/c has deleted/unused inode nnnnn.*/ { PR_2_UNUSED_INODE,N_ ("@E has @D/unused @i %Di. " ), PROMPT_CLEAR, PR_PREEN_OK },Signature · 1 line
1.7.11.5
Cheers, Andreas
Signature · 4 lines
Andreas Dilger Lustre Software Architect Intel High Performance Data Division
Theodore Ts'o
AppliedQuoted 5 lines · Andreas Dilger
Fix the e2fsck problem comments to match the actual message printed, so that it is possible to find the problem code when searching by the message.
Signed-off-by Andreas Dilger <[email protected]>
Thanks, applied.
- Ted