Skip to contentSkip to conversation

pseries/mobility: reset the RCU watchdogs after a LPM

PATCH Applied Laurent Dufour 3 participants 3 messages Nov 25, 2022 – Dec 8, 2022 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pseries/mobility: reset the RCU watchdogs after a LPM

The RCU watchdog timer should be reset when restarting the CPU after a Live Partition Mobility operation.

---
 arch/powerpc/platforms/pseries/mobility.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/powerpc/platforms/pseries/mobility.c +3 -1
index 634fac5db3f9..9e10f38dd9ad 100644
@@ -636,8 +636,10 @@ static int do_join(void *arg)
 	}
 	/*
 	 * Execution may have been suspended for several seconds, so
-	 * reset the watchdog.
+	 * reset the watchdogs.
 	 */
+	rcu_cpu_stall_reset();
+	/* touch_nmi_watchdog() also touch the soft lockup watchdog */
 	touch_nmi_watchdog();
 	return ret;
 }
Signature · 1 line
2.38.1
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Laurent Dufour

The RCU watchdog timer should be reset when restarting the CPU after a Live Partition Mobility operation.

Looks okay to me. xmon touches the softlockup watchdog explicitly but is that for architectures with unsynchronized clocks maybe.

Quoted 22 lines
---
 arch/powerpc/platforms/pseries/mobility.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/powerpc/platforms/pseries/mobility.c +3 -1
index 634fac5db3f9..9e10f38dd9ad 100644
@@ -636,8 +636,10 @@ static int do_join(void *arg)
 	}
 	/*
 	 * Execution may have been suspended for several seconds, so
-	 * reset the watchdog.
+	 * reset the watchdogs.
 	 */
+	rcu_cpu_stall_reset();
+	/* touch_nmi_watchdog() also touch the soft lockup watchdog */
 	touch_nmi_watchdog();
 	return ret;
 }
Signature · 1 line
2.38.1