What's cooking in git.git (Jan 2024, #06; Fri, 19)
Here are the topics that have been cooking in my tree. Commits prefixed with '+' are in 'next' (being in 'next' is a sign that a topic is stable enough to be used and are candidate to be in a future release). Commits prefixed with '-' are only in 'seen', and aren't considered "accepted" at all and may be annotated with an URL to a message that raises issues but they are no means exhaustive. A topic without enough support may be discarded after a long period of no activity (of course they can be resubmit when new interests arise).
Copies of the source code to Git live in many repositories, and the following is a list of the ones I push into or their mirrors. Some repositories have only a subset of branches.
With maint, master, next, seen, todo:
git://git.kernel.org/pub/scm/git/git.git/ git://repo.or.cz/alt-git.git/ https://kernel.googlesource.com/pub/scm/git/git/ https://github.com/git/git/ https://gitlab.com/git-vcs/git/
With all the integration branches and topics broken out:
https://github.com/gitster/git/
Even though the preformatted documentation in HTML and man format are not sources, they are published in these repositories for convenience (replace "htmldocs" with "manpages" for the manual pages):
git://git.kernel.org/pub/scm/git/git-htmldocs.git/
https://github.com/gitster/git-htmldocs.git/
Release tarballs are available at:
https://www.kernel.org/pub/software/scm/git/
--------------------------------------------------
[Graduated to 'master']
* bk/bisect-doc-fix (2024-01-10) 2 commits
(merged to 'next' on 2024-01-12 at bdb3609554)
+ doc: refer to pathspec instead of path
+ doc: use singular form of repeatable path arg
Synopsis fix.
source: <[email protected]>
* cp/t4129-pipefix (2024-01-10) 1 commit
(merged to 'next' on 2024-01-12 at fd9b72b71a)
+ t4129: prevent loss of exit code due to the use of pipes
Test update.
source: <[email protected]>
* ps/gitlab-ci-static-analysis (2024-01-08) 1 commit (merged to 'next' on 2024-01-10 at 71af34de07)
+ ci: add job performing static analysis on GitLab CI (this branch is used by ps/gitlab-ci-macos.)
GitLab CI update.
source: <1536a5ef07ad24dafb5d685b40099882f89e6cc5.1703761005.git.ps@pks.im>
* ps/p4-use-ref-api (2024-01-11) 1 commit
(merged to 'next' on 2024-01-12 at 3f89cf25f6)
+ git-p4: stop reaching into the refdb
"git p4" update to prepare for reftable
source: <33d6a062ec56be33ed50a42a420be0b023f6f4cf.1704980814.git.ps@pks.im>
* ps/prompt-parse-HEAD-futureproof (2024-01-08) 2 commits
(merged to 'next' on 2024-01-10 at f9515b9d89)
+ git-prompt: stop manually parsing HEAD with unknown ref formats
+ Merge branch 'ps/refstorage-extension' into ps/prompt-parse-HEAD-futureproof
Futureproof command line prompt support (in contrib/).
source: <ef4e36a5a40c369da138242a8fdc9e12a846613b.1704356313.git.ps@pks.im>
* rj/clarify-branch-doc-m (2024-01-08) 1 commit
(merged to 'next' on 2024-01-10 at 432eaa2c6b)
+ branch: clarify <oldbranch> term
Doc update.
source: <[email protected]>
* sk/mingw-owner-check-error-message-improvement (2024-01-10) 1 commit (merged to 'next' on 2024-01-12 at 05c56e151b)
+ mingw: give more details about unsafe directory's ownership
In addition to (rather cryptic) Security Identifiers, show username and domain in the error message when we barf on mismatch between the Git directory and the current user on Windows.
source: <[email protected]>
* tb/fetch-all-configuration (2024-01-08) 1 commit (merged to 'next' on 2024-01-12 at 6a05050382)
+ fetch: add new config option fetch.all
"git fetch" learned to pay attention to "fetch.all" configuration variable, which pretends as if "--all" was passed from the command line when no remote parameter was given.
source: <[email protected]>
--------------------------------------------------
[New Topics]
* kh/maintenance-use-xdg-when-it-should (2024-01-18) 4 commits (merged to 'next' on 2024-01-19 at 9c8c7b2e9d)
+ maintenance: use XDG config if it exists
+ config: factor out global config file retrieval
+ config: rename global config function
+ config: format newlines
When $HOME/.gitignore is missing but XDG config file available, we should write into the latter, not former. "git gc" and "git maintenance" wrote into a wrong "global config" file, which have been corrected.
Will merge to 'master'.
source: <[email protected]>
* ps/gitlab-ci-macos (2024-01-18) 6 commits
(merged to 'next' on 2024-01-19 at a239dc8140)
+ ci: add macOS jobs to GitLab CI
+ ci: make p4 setup on macOS more robust
+ ci: handle TEST_OUTPUT_DIRECTORY when printing test failures
+ Makefile: detect new Homebrew location for ARM-based Macs
+ t7527: decrease likelihood of racing with fsmonitor daemon
+ Merge branch 'ps/gitlab-ci-static-analysis' into ps/gitlab-ci-macos
CI for GitLab learned to drive macOS jobs.
Will merge to 'master'.
source: <[email protected]>
* ad/custom-merge-placeholder-for-symbolic-pathnames (2024-01-18) 1 commit
- merge-ll: expose revision names to custom drivers
source: <[email protected]>
* cp/unit-test-prio-queue (2024-01-17) 2 commits
- SQUASH???
- tests: move t0009-prio-queue.sh to the new unit testing framework
source: <[email protected]>
* jc/reffiles-tests (2024-01-19) 12 commits
- t5312: move reffiles specific tests to t0601
- t4202: move reffiles specific tests to t0600
- t3903: make drop stash test ref backend agnostic
- t1503: move reffiles specific tests to t0600
- t1415: move reffiles specific tests to t0601
- t1410: move reffiles specific tests to t0600
- t1406: move reffiles specific tests to t0600
- t1405: move reffiles specific tests to t0601
- t1404: move reffiles specific tests to t0600
- t1414: convert test to use Git commands instead of writing refs manually
- remove REFFILES prerequisite for some tests in t1405 and t2017
- t3210: move to t0601
source: <[email protected]>
* ml/log-merge-with-cherry-pick-and-other-pseudo-heads (2024-01-17) 2 commits
- revision: implement git log --merge also for rebase/cherry_pick/revert
- revision: ensure MERGE_HEAD is a ref in prepare_show_merge
source: <[email protected]>
* nb/rebase-x-shell-docfix (2024-01-17) 1 commit
- rebase: fix documentation about used shell in -x
source: <[email protected]>
* tc/show-ref-exists-fix (2024-01-18) 1 commit
- builtin/show-ref: treat directory as non-existing in --exists
source: <[email protected]>
* gt/t0024-style-fixes (2024-01-18) 2 commits
- t0024: style fix
- t0024: avoid losing exit status to pipes
source: <[email protected]>
* jc/majordomo-to-subspace (2024-01-19) 1 commit
- Docs: [email protected] has been decomissioned
source: <[email protected]>
* js/oss-fuzz-build-in-ci (2024-01-19) 2 commits
- ci: build and run minimal fuzzers in GitHub CI
- fuzz: fix fuzz test build rules
source: <[email protected]>
* kn/for-all-refs (2024-01-19) 5 commits
- for-each-ref: avoid filtering on empty pattern
- refs: introduce refs_for_each_all_refs()
- refs: extract out loose_fill_ref_dir_regular_file()
- refs: make is_pseudoref_syntax() stricter
- refs: expose is_pseudoref_syntax()
source: <[email protected]>
* ps/not-so-many-refs-are-special (2024-01-19) 7 commits
- Documentation: add "special refs" to the glossary
- refs: redefine special refs
- refs: convert MERGE_AUTOSTASH to become a normal pseudo-ref
- sequencer: introduce functions to handle autostashes via refs
- refs: convert AUTO_MERGE to become a normal pseudo-ref
- sequencer: delete REBASE_HEAD in correct repo when picking commits
- sequencer: clean up pseudo refs with REF_NO_DEREF
source: <[email protected]>
--------------------------------------------------
[Cooking]
* es/some-up-to-date-messages-must-stay (2024-01-12) 1 commit (merged to 'next' on 2024-01-16 at 2b598f7de2)
+ messages: mark some strings with "up-to-date" not to touch
Comment updates to help developers not to attempt to modify messages from plumbing commands that must stay constant.
It might make sense to reassess the plumbing needs every few years, but that should be done as a separate effort.
Will merge to 'master'.
source: <[email protected]>
* bk/complete-bisect (2024-01-18) 5 commits
- completion: git-bisect view recognized but not completed
- completion: custom git-bisect terms
- completion: move to maintain define-before-use
- completion: git-log opts to bisect visualize
- completion: complete new old actions, start opts
Command line completion support (in contrib/) has been updated for "git bisect".
Expecting a reroll.
cf. <ZaofJhHsFjRxx7a3@tanuki>
source: <[email protected]>
* bk/complete-dirname-for-am-and-format-patch (2024-01-12) 1 commit
- completion: dir-type optargs for am, format-patch
Command line completion support (in contrib/) has been updated for a few commands to complete directory names where a directory name is expected.
Needs review.
source: <[email protected]>
* bk/complete-send-email (2024-01-12) 1 commit
- completion: don't complete revs when --no-format-patch
Command line completion support (in contrib/) has been taught to avoid offering revision names as candidates to "git send-email" when the command is used to send pre-generated files.
Needs review.
source: <[email protected]>
* gt/test-commit-o-i-options (2024-01-17) 2 commits (merged to 'next' on 2024-01-19 at 0377e2c148)
+ t7501: add tests for --amend --signoff
+ t7501: add tests for --include and --only
A few tests to "git commit -o <pathspec>" and "git commit -i <pathspec>" has been added.
Will merge to 'master'.
source: <[email protected]>
* jt/tests-with-reftable (2024-01-12) 2 commits
(merged to 'next' on 2024-01-19 at 498d203a57)
+ t5541: remove lockfile creation
+ t1401: remove lockfile creation
Tweak a few tests not to manually modify the reference database (hence easier to work with other backends like reftable).
Will merge to 'master'.
source: <[email protected]>
* la/strvec-comment-fix (2024-01-12) 1 commit
(merged to 'next' on 2024-01-19 at 120ef16493)
+ strvec: use correct member name in comments
Comment fix.
Will merge to 'master'.
source: <[email protected]>
* la/trailer-api (2024-01-12) 10 commits
- trailer: delete obsolete argument handling code from API
- trailer: move arg handling to interpret-trailers.c
- trailer: prepare to move parse_trailers_from_command_line_args() to builtin
- trailer: spread usage of "trailer_block" language
- trailer: make trailer_info struct private
- sequencer: use the trailer iterator
- trailer: delete obsolete formatting functions
- trailer: unify trailer formatting machinery
- trailer: include "trailer" term in API functions
- trailer: move process_trailers() to interpret-trailers.c
Code clean-up.
Needs review.
source: <[email protected]>
* ps/tests-with-ref-files-backend (2024-01-12) 6 commits
- t: mark tests regarding git-pack-refs(1) to be backend specific
- t5526: break test submodule differently
- t1419: mark test suite as files-backend specific
- t1302: make tests more robust with new extensions
- t1301: mark test for core.sharedRepository as reffiles specific
- t1300: make tests more robust with non-default ref backends
Prepare existing tests on refs to work better with non-default backends.
Needs review.
source: <[email protected]>
* ne/doc-filter-blob-limit-fix (2024-01-16) 1 commit
(merged to 'next' on 2024-01-19 at 4f78975728)
+ rev-list-options: fix off-by-one in '--filter=blob:limit=<n>' explainer
Docfix.
Will merge to 'master'.
source: <[email protected]>
* ps/commit-graph-write-leakfix (2024-01-15) 1 commit (merged to 'next' on 2024-01-19 at df537fac39)
+ commit-graph: fix memory leak when not writing graph
Leakfix.
Will merge to 'master'.
source: <0feab5e7d5bc6275e2c7671cd8f6786ea86fd610.1702891190.git.ps@pks.im>
* rj/advice-delete-branch-not-fully-merged (2024-01-11) 3 commits (merged to 'next' on 2024-01-19 at 7102eb6b79)
+ branch: make the advice to force-deleting a conditional one
+ advice: fix an unexpected leading space
+ advice: sort the advice related lists
(this branch is used by rj/advice-disable-how-to-disable.)
The error message given when "git branch -d branch" fails due to commits unique to the branch has been split into an error and a new conditional advice message.
Will merge to 'master'.
source: <[email protected]>
* en/diffcore-delta-final-line-fix (2024-01-18) 1 commit
- diffcore-delta: avoid ignoring final 'line' of file
Rename detection logic ignored the final line of a file if it is an incomplete line.
Will merge to 'next'.
source: <[email protected]>
* mj/gitweb-unreadable-config-error (2024-01-10) 1 commit (merged to 'next' on 2024-01-19 at 790b7a7855)
+ gitweb: die when a configuration file cannot be read
When given an existing but unreadable file as a configuration file, gitweb behaved as if the file did not exist at all, but now it errors out. This is a change that may break backward compatibility.
Will merge to 'master'.
source: <[email protected]>
* ps/completion-with-reftable-fix (2024-01-16) 5 commits (merged to 'next' on 2024-01-19 at 8854a7d903)
+ completion: treat dangling symrefs as existing pseudorefs
+ completion: silence pseudoref existence check
+ completion: improve existence check for pseudo-refs
+ t9902: verify that completion does not print anything
+ completion: discover repo path in __git_pseudoref_exists ()
Completion update to prepare for reftable
Will merge to 'master'.
source: <[email protected]>
* ps/reftable-optimize-io (2024-01-18) 7 commits
- reftable/stack: fix race in up-to-date check
- reftable/stack: unconditionally reload stack after commit (merged to 'next' on 2024-01-12 at 4096e880e0)
+ reftable/blocksource: use mmap to read tables
+ reftable/blocksource: refactor code to match our coding style
+ reftable/stack: use stat info to avoid re-reading stack list
+ reftable/stack: refactor reloading to use file descriptor
+ reftable/stack: refactor stack reloading to have common exit path
Low-level I/O optimization for reftable.
The two commits at the tip are new.
Will merge to 'next' and then to 'master'?
source: <[email protected]>
source: <[email protected]>
* rj/advice-disable-how-to-disable (2024-01-16) 2 commits
- advice: allow disabling the automatic hint in advise_if_enabled()
- Merge branch 'rj/advice-delete-branch-not-fully-merged' into rj/advice-disable-how-to-disable (this branch uses rj/advice-delete-branch-not-fully-merged.)
All conditional "advice" messages show how to turn them off, which becomes repetitive. Add a configuration variable to omit the instruction.
Will merge to 'next'?
source: <[email protected]>
* vd/fsck-submodule-url-test (2024-01-19) 4 commits (merged to 'next' on 2024-01-19 at dad35ae82c)
+ submodule-config.c: strengthen URL fsck check
+ t7450: test submodule urls
+ test-submodule: remove command line handling for check-name
+ submodule-config.h: move check_submodule_url
Tighten URL checks fsck makes in a URL recorded for submodules.
Will merge to 'master'.
source: <[email protected]>
* sd/negotiate-trace-fix (2024-01-03) 1 commit
- push: region_leave trace for negotiate_using_fetch
Tracing fix.
Waiting for a review response.
cf. <[email protected]>
source: <[email protected]>
* ps/worktree-refdb-initialization (2024-01-08) 7 commits
(merged to 'next' on 2024-01-19 at e8c649a3ac)
+ builtin/worktree: create refdb via ref backend
+ worktree: expose interface to look up worktree by name
+ builtin/worktree: move setup of commondir file earlier
+ refs/files: skip creation of "refs/{heads,tags}" for worktrees
+ setup: move creation of "refs/" into the files backend
+ refs: prepare refs_init_db() for initializing worktree refs
+ Merge branch 'ps/refstorage-extension' into ps/worktree-refdb-initialization
Instead of manually creating refs/ hierarchy on disk upon a creation of a secondary worktree, which is only usable via the files backend, use the refs API to populate it.
Will merge to 'master'.
source: <[email protected]>
* cp/apply-core-filemode (2023-12-26) 3 commits
- apply: code simplification
- apply: correctly reverse patch's pre- and post-image mode bits
- apply: ignore working tree filemode when !core.filemode
"git apply" on a filesystem without filemode support have learned to take a hint from what is in the index for the path, even when not working with the "--index" or "--cached" option, when checking the executable bit match what is required by the preimage in the patch.
Needs review.
source: <[email protected]>
* al/unit-test-ctype (2024-01-16) 1 commit
(merged to 'next' on 2024-01-19 at fcdad0d06c)
+ unit-tests: rewrite t/helper/test-ctype.c as a unit test
Move test-ctype helper to the unit-test framework.
Will merge to 'master'.
source: <[email protected]>
* ja/doc-placeholders-fix (2023-12-26) 2 commits
- doc: enforce placeholders in documentation
- doc: enforce dashes in placeholders
Docfix.
Needs review.
source: <[email protected]>
* jc/bisect-doc (2023-12-09) 1 commit
- bisect: document "terms" subcommand more fully
Doc update.
Needs review.
source: <[email protected]>
* tb/pair-chunk-expect (2023-11-10) 8 commits
- midx: read OOFF chunk with pair_chunk_expect()
- midx: read OIDL chunk with pair_chunk_expect()
- commit-graph: read BIDX chunk with pair_chunk_expect()
- commit-graph: read GDAT chunk with pair_chunk_expect()
- commit-graph: read CDAT chunk with pair_chunk_expect()
- commit-graph: read OIDL chunk with pair_chunk_expect()
- chunk-format: introduce pair_chunk_expect() helper
- Merge branch 'jk/chunk-bounds-more' into HEAD
Further code clean-up.
Needs review.
source: <[email protected]>
* tb/path-filter-fix (2024-01-16) 17 commits
- bloom: introduce deinit_bloom_filters()
- commit-graph: reuse existing Bloom filters where possible
- object.h: fix mis-aligned flag bits table
- commit-graph: drop unnecessary graph_read_bloom_data_context
- commit-graph.c: unconditionally load Bloom filters
- bloom: prepare to discard incompatible Bloom filters
- bloom: annotate filters with hash version
- commit-graph: new Bloom filter version that fixes murmur3
- repo-settings: introduce commitgraph.changedPathsVersion
- t4216: test changed path filters with high bit paths
- t/helper/test-read-graph: implement bloom-filters mode
- bloom.h: make load_bloom_filter_from_graph() public
- t/helper/test-read-graph.c: extract dump_graph_info()
- gitformat-commit-graph: describe version 2 of BDAT
- commit-graph: ensure Bloom filters are read with consistent settings
- revision.c: consult Bloom filters for root commits
- t/t4216-log-bloom.sh: harden test_bloom_filters_not_used()
The Bloom filter used for path limited history traversal was broken on systems whose "char" is unsigned; update the implementation and bump the format version to 2.
Will merge to 'next'?
source: <[email protected]>
* ak/color-decorate-symbols (2023-10-23) 7 commits
- log: add color.decorate.pseudoref config variable
- refs: exempt pseudorefs from pattern prefixing
- refs: add pseudorefs array and iteration functions
- log: add color.decorate.ref config variable
- log: add color.decorate.symbol config variable
- log: use designated inits for decoration_colors
- config: restructure color.decorate documentation
A new config for coloring.
Needs review.
source: <[email protected]>
* eb/hash-transition (2023-10-02) 30 commits
- t1016-compatObjectFormat: add tests to verify the conversion between objects
- t1006: test oid compatibility with cat-file
- t1006: rename sha1 to oid
- test-lib: compute the compatibility hash so tests may use it
- builtin/ls-tree: let the oid determine the output algorithm
- object-file: handle compat objects in check_object_signature
- tree-walk: init_tree_desc take an oid to get the hash algorithm
- builtin/cat-file: let the oid determine the output algorithm
- rev-parse: add an --output-object-format parameter
- repository: implement extensions.compatObjectFormat
- object-file: update object_info_extended to reencode objects
- object-file-convert: convert commits that embed signed tags
- object-file-convert: convert commit objects when writing
- object-file-convert: don't leak when converting tag objects
- object-file-convert: convert tag objects when writing
- object-file-convert: add a function to convert trees between algorithms
- object: factor out parse_mode out of fast-import and tree-walk into in object.h
- cache: add a function to read an OID of a specific algorithm
- tag: sign both hashes
- commit: export add_header_signature to support handling signatures on tags
- commit: convert mergetag before computing the signature of a commit
- commit: write commits for both hashes
- object-file: add a compat_oid_in parameter to write_object_file_flags
- object-file: update the loose object map when writing loose objects
- loose: compatibilty short name support
- loose: add a mapping between SHA-1 and SHA-256 for loose objects
- repository: add a compatibility hash algorithm
- object-names: support input of oids in any supported hash
- oid-array: teach oid-array to handle multiple kinds of oids
- object-file-convert: stubs for converting from one object format to another
Teach a repository to work with both SHA-1 and SHA-256 hash algorithms.
Needs review.
source: <[email protected]>
* jx/remote-archive-over-smart-http (2024-01-16) 6 commits
- transport-helper: call do_take_over() in process_connect
- transport-helper: call do_take_over() in connect_helper
- http-backend: new rpc-service for git-upload-archive
- transport-helper: protocol-v2 supports upload-archive
- remote-curl: supports git-upload-archive service
- transport-helper: no connection restriction in connect_helper
"git archive --remote=<remote>" learned to talk over the smart http (aka stateless) transport.
Will merge to 'next'?
source: <[email protected]>
* jc/rerere-cleanup (2023-08-25) 4 commits
- rerere: modernize use of empty strbuf
- rerere: try_merge() should use LL_MERGE_ERROR when it means an error
- rerere: fix comment on handle_file() helper
- rerere: simplify check_one_conflict() helper function
Code clean-up.
Not ready to be reviewed yet.
source: <[email protected]>
Quoted 5 lines · Junio C Hamano
* gt/t0024-style-fixes (2024-01-18) 2 commits
- t0024: style fix
- t0024: avoid losing exit status to pipessource: <[email protected]>
I have rerolled this series, cause it was breaking CI on alpine due to a syntax issue which is described here:
https://lore.kernel.org/git/[email protected]/
Thanks.
Quoted 5 lines · Ghanshyam Thakkar
Quoted 4 lines · Junio C Hamano
* gt/t0024-style-fixes (2024-01-18) 2 commits
- t0024: style fix
- t0024: avoid losing exit status to pipes
Quoted 7 lines
Quoted 1 line
source: <[email protected]>
I have rerolled this series, cause it was breaking CI on alpine due to a syntax issue which is described here:
https://lore.kernel.org/git/[email protected]/Thanks.
Thanks for pinging. Yeah, there was that buggy implementation of tar that requires dash in "-C". Will replace.
Re: ps/reftable-optimize-io (was: What's cooking in git.git (Jan 2024, #06; Fri, 19))
In reply to Junio C HamanoQuoted 10 lines · Junio C Hamano
* ps/reftable-optimize-io (2024-01-18) 7 commits
- reftable/stack: fix race in up-to-date check
- reftable/stack: unconditionally reload stack after commit (merged to 'next' on 2024-01-12 at4096e880e0)
+ reftable/blocksource: use mmap to read tables
+ reftable/blocksource: refactor code to match our coding style
+ reftable/stack: use stat info to avoid re-reading stack list
+ reftable/stack: refactor reloading to use file descriptor
+ reftable/stack: refactor stack reloading to have common exit path
Quoted 6 lines
Low-level I/O optimization for reftable.
The two commits at the tip are new.
Will merge to 'next' and then to 'master'?
source: <[email protected]>
source: <[email protected]>
Yeah, this topic is good to go from my point of view.
Patrick
Re: sd/negotiate-trace-fix (was: What's cooking in git.git (Jan 2024, #06; Fri, 19))
In reply to Junio C HamanoOn 2024.01.19 17:56, Junio C Hamano wrote:
[snip]
Quoted 8 lines
* sd/negotiate-trace-fix (2024-01-03) 1 commit
- push:region_leavetrace fornegotiate_using_fetchTracing fix.
Waiting for a review response.
cf. <[email protected]>
source: <[email protected]>
Hi Junio,
Were there other open questions you had on this series? It looks like Sam answered all the questions in your [email protected] reply. In your other followup you mentioned running CI with tracing enabled for all tests. This is something that we suggested before [1] but it was pretty thoroughly rejected for runtime reasons. Perhaps a more efficient check for region_enter/leave pairs could be an option, though.
Re: sd/negotiate-trace-fix
Quoted 7 lines · Josh Steadmon
On 2024.01.19 17:56, Junio C Hamano wrote:
[snip]Quoted 5 lines
* sd/negotiate-trace-fix (2024-01-03) 1 commit
- push:region_leavetrace fornegotiate_using_fetchTracing fix.
Quoted 8 lines
Quoted 3 lines
Waiting for a review response.
cf. <[email protected]>
source: <[email protected]>Hi Junio,
Were there other open questions you had on this series? It looks like Sam answered all the questions in your [email protected] reply.
Thanks for a reminder.
Quoted 4 lines
In your other followup you mentioned running CI with tracing enabled for all tests. This is something that we suggested before [1] but it was pretty thoroughly rejected for runtime reasons. Perhaps a more efficient check for region_enter/leave pairs could be an option, though.
Yeah, perhaps. It does not sound like an issue that must block this patch in either case.
Thanks.