Skip to contentSkip to conversation

dmaengine: tegra186: Fix residual calculation

PATCH RESEND Applied Akhil R 3 participants 3 messages Mar 15, 2024 – Mar 28, 2024

Subsystems (3)
lore
Share & tools
lore

Akhil R

author
#0 lore raw

PATCH RESEND v2 1/1 dmaengine: tegra186: Fix residual calculation

The existing residual calculation returns an incorrect value when bytes_xfer == bytes_req. This scenario occurs particularly with drivers like UART where DMA is scheduled for maximum number of bytes and is terminated when the bytes inflow stops. At higher baud rates, it could request the tx_status while there is no bytes left to transfer. This will lead to incorrect residual being set. Hence return residual as '0' when bytes transferred equals to the bytes requested.

Fixes ee17028009d4 ("dmaengine: tegra: Add tegra gpcdma driver")

---
v1->v2:
* corrected typo - s/exisiting/existing/

 drivers/dma/tegra186-gpc-dma.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/dma/tegra186-gpc-dma.c +3 -0
index 88547a23825b..3642508e88bb 100644
@@ -746,6 +746,9 @@ static int tegra_dma_get_residual(struct tegra_dma_channel *tdc)
 	bytes_xfer = dma_desc->bytes_xfer +
 		     sg_req[dma_desc->sg_idx].len - (wcount * 4);
 
+	if (dma_desc->bytes_req == bytes_xfer)
+		return 0;
+
 	residual = dma_desc->bytes_req - (bytes_xfer % dma_desc->bytes_req);
 
 	return residual;
Signature · 1 line
2.43.2
Acked-by on v2 1/1
#1 lore raw
Quoted 11 lines · Akhil R

The existing residual calculation returns an incorrect value when bytes_xfer == bytes_req. This scenario occurs particularly with drivers like UART where DMA is scheduled for maximum number of bytes and is terminated when the bytes inflow stops. At higher baud rates, it could request the tx_status while there is no bytes left to transfer. This will lead to incorrect residual being set. Hence return residual as '0' when bytes transferred equals to the bytes requested.

Fixes ee17028009d4 ("dmaengine: tegra: Add tegra gpcdma driver")
Quoted 6 lines

---
v1->v2:
* corrected typo - s/exisiting/existing/

 drivers/dma/tegra186-gpc-dma.c | 3 +++
 1 file changed, 3 insertions(+)
maintainer Applied
#2 lore raw
In reply to Akhil R
Quoted 9 lines · Akhil R

The existing residual calculation returns an incorrect value when bytes_xfer == bytes_req. This scenario occurs particularly with drivers like UART where DMA is scheduled for maximum number of bytes and is terminated when the bytes inflow stops. At higher baud rates, it could request the tx_status while there is no bytes left to transfer. This will lead to incorrect residual being set. Hence return residual as '0' when bytes transferred equals to the bytes requested.

[...]

Applied, thanks!

[1/1] dmaengine: tegra186: Fix residual calculation

      commit: 30f0ced9971b2d8c8c24ae75786f9079489a012d

Best regards,

Signature · 1 line
~Vinod