Skip to contentSkip to conversation

mtd: spi-nor: spansion: Add support for infineon cy15v102qsn

PATCH In review Hui Wang 2 participants 7 messages Apr 8, 2024 – Apr 10, 2024

Subsystems (2)
lore
Share & tools
lore

Hui Wang

author
#0 lore raw

PATCH 1/1 mtd: spi-nor: spansion: Add support for infineon cy15v102qsn

It is 2Mbit F-RAM which is logically organized as 256K x 8.

---
 drivers/mtd/spi-nor/spansion.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/mtd/spi-nor/spansion.c +6 -0
index 6cc237c24e07..5dc94926b2cb 100644
@@ -981,6 +981,12 @@ static const struct flash_info spansion_nor_parts[] = {
 		.name = "s28hs02gt",
 		.mfr_flags = USE_CLPEF,
 		.fixups = &s28hx_t_fixups,
+	}, {
+		.id = SNOR_ID(0x48, 0x51, 0x80, 0x06, 0x00, 0x00),
+		.name = "cy15v102qsn",
+		.size = SZ_256K,
+		.sector_size = SZ_256K,
+		.flags = SPI_NOR_NO_ERASE,
 	}, {
 		.id = SNOR_ID(0xef, 0x40, 0x13),
 		.name = "s25fl004k",
Signature · 6 lines
2.34.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
maintainer
#1 lore raw

Hi,

Quoted 1 line · Hui Wang

It is 2Mbit F-RAM which is logically organized as 256K x 8.

Please have a look at drivers/misc/at25.c. I'm trying to get rid of the NO_ERASE flag. This is more of an EEPROM like device. The at25 driver already have some kind of FRAM type support.

Quoted 10 lines
---
 drivers/mtd/spi-nor/spansion.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/mtd/spi-nor/spansion.c +0 -0
index 6cc237c24e07..5dc94926b2cb 100644

drivers/mtd/spi-nor/spansion.c static const struct flash_info spansion_nor_parts[] = { · line 985

Quoted 5 lines
drivers/mtd/spi-nor/spansion.c +2 -0
@@ -981,6 +981,12 @@ static const struct flash_info spansion_nor_parts[] = {
 		.name = "s28hs02gt",
 		.mfr_flags = USE_CLPEF,
 		.fixups = &s28hx_t_fixups,
+	}, {
+		.id = SNOR_ID(0x48, 0x51, 0x80, 0x06, 0x00, 0x00),

This doesn't look like a JEDEC id. The datasheet says it is a 11bit manufacturer id?

-michael

drivers/mtd/spi-nor/spansion.c static const struct flash_info spansion_nor_parts[] = { · line 992

Quoted 7 lines
drivers/mtd/spi-nor/spansion.c +4 -0
+		.name = "cy15v102qsn",
+		.size = SZ_256K,
+		.sector_size = SZ_256K,
+		.flags = SPI_NOR_NO_ERASE,
 	}, {
 		.id = SNOR_ID(0xef, 0x40, 0x13),
 		.name = "s25fl004k",

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

author
#2 lore raw
Quoted 7 lines · Michael Walle

Hi,

Quoted 1 line · Hui Wang

It is 2Mbit F-RAM which is logically organized as 256K x 8.

Please have a look at drivers/misc/at25.c. I'm trying to get rid of the NO_ERASE flag. This is more of an EEPROM like device. The at25 driver already have some kind of FRAM type support.

After reading your comment, I checked the drivers/misc/at25.c, I found It couldn't work on my hardware. In my case, the F-RAM is under a spi bus (spi-nxp-fspi.c) which only supports spi_mem transfer mode. So currently, the mtd/spi-nor is the only choice.

Quoted 18 lines
Quoted 10 lines
---
  drivers/mtd/spi-nor/spansion.c | 6 ++++++
  1 file changed, 6 insertions(+)
drivers/mtd/spi-nor/spansion.c +0 -0
index 6cc237c24e07..5dc94926b2cb 100644

drivers/mtd/spi-nor/spansion.c static const struct flash_info spansion_nor_parts[] = { · line 985

Quoted 5 lines
drivers/mtd/spi-nor/spansion.c +2 -0
@@ -981,6 +981,12 @@ static const struct flash_info spansion_nor_parts[] = {
  		.name = "s28hs02gt",
  		.mfr_flags = USE_CLPEF,
  		.fixups = &s28hx_t_fixups,
+	}, {
+		.id = SNOR_ID(0x48, 0x51, 0x80, 0x06, 0x00, 0x00),

This doesn't look like a JEDEC id. The datasheet says it is a 11bit manufacturer id?

Quoted 1 line

-michael

From the page 82 of datasheet, the Device ID is 0000000006805148, and the ID read by spi_nor_read_id() matches it (id[0] is 0x48, id[1] is 0x51, ...).

Thanks,

Hui.

Quoted 8 lines

drivers/mtd/spi-nor/spansion.c static const struct flash_info spansion_nor_parts[] = { · line 992

Quoted 8 lines
drivers/mtd/spi-nor/spansion.c +4 -0
+		.name = "cy15v102qsn",
+		.size = SZ_256K,
+		.sector_size = SZ_256K,
+		.flags = SPI_NOR_NO_ERASE,
  	}, {
  		.id = SNOR_ID(0xef, 0x40, 0x13),
  		.name = "s25fl004k",

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

maintainer
#3 lore raw

Hi,

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

It is 2Mbit F-RAM which is logically organized as 256K x 8.

Please have a look at drivers/misc/at25.c. I'm trying to get rid of the NO_ERASE flag. This is more of an EEPROM like device. The at25 driver already have some kind of FRAM type support.

After reading your comment, I checked the drivers/misc/at25.c, I found It couldn't work on my hardware. In my case, the F-RAM is under a spi bus (spi-nxp-fspi.c) which only supports spi_mem transfer mode. So currently, the mtd/spi-nor is the only choice.

Then it will be a great opportunity to make the at25 driver spi-mem ready :)

Quoted 18 lines
Quoted 18 lines
Quoted 10 lines
---
  drivers/mtd/spi-nor/spansion.c | 6 ++++++
  1 file changed, 6 insertions(+)
drivers/mtd/spi-nor/spansion.c +0 -0
index 6cc237c24e07..5dc94926b2cb 100644

drivers/mtd/spi-nor/spansion.c static const struct flash_info spansion_nor_parts[] = { · line 985

Quoted 5 lines
drivers/mtd/spi-nor/spansion.c +2 -0
@@ -981,6 +981,12 @@ static const struct flash_info spansion_nor_parts[] = {
  		.name = "s28hs02gt",
  		.mfr_flags = USE_CLPEF,
  		.fixups = &s28hx_t_fixups,
+	}, {
+		.id = SNOR_ID(0x48, 0x51, 0x80, 0x06, 0x00, 0x00),

This doesn't look like a JEDEC id. The datasheet says it is a 11bit manufacturer id?

Quoted 5 lines
Quoted 1 line

-michael

From the page 82 of datasheet, the Device ID is 0000000006805148, and
the ID read by spi_nor_read_id() matches it (id[0] is 0x48, id[1] is 0x51, ...).

JEDEC manufacturer IDs are not 11bit wide.

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

author
#4 lore raw
Quoted 6 lines · Michael Walle

Hi,

Quoted 4 lines
Quoted 4 lines
Quoted 1 line

It is 2Mbit F-RAM which is logically organized as 256K x 8.

Please have a look at drivers/misc/at25.c. I'm trying to get rid of the NO_ERASE flag. This is more of an EEPROM like device. The at25 driver already have some kind of FRAM type support.

Quoted 6 lines
Quoted 4 lines

After reading your comment, I checked the drivers/misc/at25.c, I found It couldn't work on my hardware. In my case, the F-RAM is under a spi bus (spi-nxp-fspi.c) which only supports spi_mem transfer mode. So currently, the mtd/spi-nor is the only choice.

Then it will be a great opportunity to make the at25 driver spi-mem ready :)

OK. :-)

Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 10 lines
---
   drivers/mtd/spi-nor/spansion.c | 6 ++++++
   1 file changed, 6 insertions(+)
drivers/mtd/spi-nor/spansion.c +0 -0
index 6cc237c24e07..5dc94926b2cb 100644

drivers/mtd/spi-nor/spansion.c static const struct flash_info spansion_nor_parts[] = { · line 985

Quoted 5 lines
drivers/mtd/spi-nor/spansion.c +2 -0
@@ -981,6 +981,12 @@ static const struct flash_info spansion_nor_parts[] = {
   		.name = "s28hs02gt",
   		.mfr_flags = USE_CLPEF,
   		.fixups = &s28hx_t_fixups,
+	}, {
+		.id = SNOR_ID(0x48, 0x51, 0x80, 0x06, 0x00, 0x00),

This doesn't look like a JEDEC id. The datasheet says it is a 11bit manufacturer id?

Quoted 5 lines
Quoted 4 lines
Quoted 1 line

-michael

From the page 82 of datasheet, the Device ID is 0000000006805148, and
the ID read by spi_nor_read_id() matches it (id[0] is 0x48, id[1] is 0x51, ...).

JEDEC manufacturer IDs are not 11bit wide.

Have no idea here. I thought it is same as the cy15x104q and the spansion.c has the support for cy15x104q.

Quoted 2 lines

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

maintainer
#5 lore raw

Hi,

Quoted 29 lines
Quoted 10 lines
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

It is 2Mbit F-RAM which is logically organized as 256K x 8.

Please have a look at drivers/misc/at25.c. I'm trying to get rid of the NO_ERASE flag. This is more of an EEPROM like device. The at25 driver already have some kind of FRAM type support.

After reading your comment, I checked the drivers/misc/at25.c, I found It couldn't work on my hardware. In my case, the F-RAM is under a spi bus (spi-nxp-fspi.c) which only supports spi_mem transfer mode. So currently, the mtd/spi-nor is the only choice.

Then it will be a great opportunity to make the at25 driver spi-mem ready :)

OK. :-)

Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 10 lines
---
   drivers/mtd/spi-nor/spansion.c | 6 ++++++
   1 file changed, 6 insertions(+)
drivers/mtd/spi-nor/spansion.c +0 -0
index 6cc237c24e07..5dc94926b2cb 100644

drivers/mtd/spi-nor/spansion.c static const struct flash_info spansion_nor_parts[] = { · line 985

Quoted 5 lines
drivers/mtd/spi-nor/spansion.c +2 -0
@@ -981,6 +981,12 @@ static const struct flash_info spansion_nor_parts[] = {
   		.name = "s28hs02gt",
   		.mfr_flags = USE_CLPEF,
   		.fixups = &s28hx_t_fixups,
+	}, {
+		.id = SNOR_ID(0x48, 0x51, 0x80, 0x06, 0x00, 0x00),

This doesn't look like a JEDEC id. The datasheet says it is a 11bit manufacturer id?

Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

-michael

From the page 82 of datasheet, the Device ID is 0000000006805148, and
the ID read by spi_nor_read_id() matches it (id[0] is 0x48, id[1] is 0x51, ...).

JEDEC manufacturer IDs are not 11bit wide.

Have no idea here. I thought it is same as the cy15x104q and the spansion.c has the support for cy15x104q.

That one was already broken (and I'd like to move that one to the at25 too); it had the ID bits reversed and this one is even more broken :(

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

author
#6 lore raw
Quoted 35 lines · Michael Walle

Hi,

Quoted 33 lines
Quoted 10 lines
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

It is 2Mbit F-RAM which is logically organized as 256K x 8.

Please have a look at drivers/misc/at25.c. I'm trying to get rid of the NO_ERASE flag. This is more of an EEPROM like device. The at25 driver already have some kind of FRAM type support.

After reading your comment, I checked the drivers/misc/at25.c, I found It couldn't work on my hardware. In my case, the F-RAM is under a spi bus (spi-nxp-fspi.c) which only supports spi_mem transfer mode. So currently, the mtd/spi-nor is the only choice.

Then it will be a great opportunity to make the at25 driver spi-mem ready :)

OK. :-)

Quoted 22 lines
Quoted 22 lines
Quoted 18 lines
Quoted 10 lines
---
    drivers/mtd/spi-nor/spansion.c | 6 ++++++
    1 file changed, 6 insertions(+)
drivers/mtd/spi-nor/spansion.c +0 -0
index 6cc237c24e07..5dc94926b2cb 100644

drivers/mtd/spi-nor/spansion.c static const struct flash_info spansion_nor_parts[] = { · line 985

Quoted 5 lines
drivers/mtd/spi-nor/spansion.c +2 -0
@@ -981,6 +981,12 @@ static const struct flash_info spansion_nor_parts[] = {
    		.name = "s28hs02gt",
    		.mfr_flags = USE_CLPEF,
    		.fixups = &s28hx_t_fixups,
+	}, {
+		.id = SNOR_ID(0x48, 0x51, 0x80, 0x06, 0x00, 0x00),

This doesn't look like a JEDEC id. The datasheet says it is a 11bit manufacturer id?

Quoted 1 line

-michael

From the page 82 of datasheet, the Device ID is 0000000006805148, and
the ID read by spi_nor_read_id() matches it (id[0] is 0x48, id[1] is 0x51, ...).

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

JEDEC manufacturer IDs are not 11bit wide.

Have no idea here. I thought it is same as the cy15x104q and the spansion.c has the support for cy15x104q.

That one was already broken (and I'd like to move that one to the at25 too); it had the ID bits reversed and this one is even more broken :(

OK, got it. :-)  will focus on at25 then.

Quoted 1 line

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/