Skip to contentSkip to conversation

small changes

PATCH Applied Stephen Hemminger 7 participants 11 messages Apr 8, 2015 – Aug 3, 2015 2 messages not in the archive Network drivers

lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

cover small changes

These are trivial patches found by review

Stephen Hemminger (2):
enic: silence log message
tools: fix comment in bind script

 lib/librte_pmd_enic/enic_main.c | 2 --
 tools/dpdk_nic_bind.py          | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)
Signature · 1 line
2.1.4

A message that is not in the archive (sent off-list or not yet received): 1428514670-7982-1-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org

author
#2 lore raw

PATCH 1/2 enic: silence log message

From: Stephen Hemminger <[email protected]>

Silence is normal. drivers should speak only when spoken to and not be chatty.

Signed-off-by Stephen Hemminger <[email protected]>
---
 lib/librte_pmd_enic/enic_main.c | 2 --
 1 file changed, 2 deletions(-)
lib/librte_pmd_enic/enic_main.c +0 -2
index 0892b3e..508621e 100644
@@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic)
 	struct rte_pci_device *pdev = enic->pdev;
 	int err = -1;
 
-	dev_debug(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
-
 	enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
 	enic->bar0.len = pdev->mem_resource[0].len;
Signature · 1 line
2.1.4
Acked-by on v1 1/2
#3 lore raw

Re: [PATCH 1/2] enic: silence log message

Quoted 6 lines · Stephen Hemminger

From: Stephen Hemminger <[email protected]>

Silence is normal. drivers should speak only when spoken to and not be chatty.

Signed-off-by Stephen Hemminger <[email protected]>
Acked-by Bruce Richardson <[email protected]>
Quoted 20 lines
---
 lib/librte_pmd_enic/enic_main.c | 2 --
 1 file changed, 2 deletions(-)
lib/librte_pmd_enic/enic_main.c +0 -2
index 0892b3e..508621e 100644
@@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic)
 	struct rte_pci_device *pdev = enic->pdev;
 	int err = -1;
 
-	dev_debug(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
-
 	enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
 	enic->bar0.len = pdev->mem_resource[0].len;
Signature · 1 line
2.1.4
#4 lore raw

Re: [PATCH 1/2] enic: silence log message

Quoted 23 lines · Bruce Richardson
Quoted 6 lines · Stephen Hemminger

From: Stephen Hemminger <[email protected]>

Silence is normal. drivers should speak only when spoken to and not be chatty.

Signed-off-by Stephen Hemminger <[email protected]>
Acked-by Bruce Richardson <[email protected]>
Quoted 13 lines
---
 lib/librte_pmd_enic/enic_main.c | 2 --
 1 file changed, 2 deletions(-)
lib/librte_pmd_enic/enic_main.c +0 -0
index 0892b3e..508621e 100644
@@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic)
 	struct rte_pci_device *pdev = enic->pdev;
 	int err = -1;
Quoted 2 lines

lib/librte_pmd_enic/enic_main.c int enic_probe(struct enic *enic) · line 1052

Quoted 2 lines
lib/librte_pmd_enic/enic_main.c +0 -2
-	dev_debug(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
-

It would be good to retain this under RTE_LIBRTE_ENIC_DEBUG.

Quoted 6 lines
Quoted 6 lines
lib/librte_pmd_enic/enic_main.c +0 -0
 	enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
 	enic->bar0.len = pdev->mem_resource[0].len;
Signature · 1 line
2.1.4
#5 lore raw

Re: [PATCH 1/2] enic: silence log message

Other drivers are quiet, why does this one need to be noisy

Quoted 42 lines · Sujith Sankar (ssujith)
Quoted 23 lines · Bruce Richardson
Quoted 6 lines · Stephen Hemminger

From: Stephen Hemminger <[email protected]>

Silence is normal. drivers should speak only when spoken to and not be chatty.

Signed-off-by Stephen Hemminger <[email protected]>
Acked-by Bruce Richardson <[email protected]>
Quoted 13 lines
---
 lib/librte_pmd_enic/enic_main.c | 2 --
 1 file changed, 2 deletions(-)
lib/librte_pmd_enic/enic_main.c +0 -0
index 0892b3e..508621e 100644
@@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic)
     struct rte_pci_device *pdev = enic->pdev;
     int err = -1;
Quoted 1 line

lib/librte_pmd_enic/enic_main.c int enic_probe(struct enic *enic) · line 1051

Quoted 1 line
lib/librte_pmd_enic/enic_main.c +0 -1
-    dev_debug(enic, " Initializing ENIC PMD version %s\n",

DRV_VERSION);

Quoted 1 line

lib/librte_pmd_enic/enic_main.c int enic_probe(struct enic *enic) · line 1052

Quoted 1 line
lib/librte_pmd_enic/enic_main.c +0 -1
-

It would be good to retain this under RTE_LIBRTE_ENIC_DEBUG.

Quoted 6 lines
Quoted 6 lines
lib/librte_pmd_enic/enic_main.c +0 -1
     enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
     enic->bar0.len = pdev->mem_resource[0].len;
 
--

2.1.4

#6 lore raw

Re: [PATCH 1/2] enic: silence log message

Stephen,
The enic debug flag is off by default. So it is going to print the version only if the user wants it to.
Isn¹t that fine?

Thanks,
-Sujith

From:  Stephen Hemminger <[email protected]>
Date:  Wednesday, 20 May 2015 11:17 pm
To:  "Sujith Sankar (ssujith)" <[email protected]>

Cc: Bruce Richardson <[email protected]>, "[email protected]" <[email protected]>, Stephen Hemminger <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 1/2] enic: silence log message

Other drivers are quiet, why does this one need to be noisy

On Wed, May 20, 2015 at 9:30 AM, Sujith Sankar (ssujith) <[email protected]> wrote:

Quoted 23 lines · Bruce Richardson
Quoted 6 lines · Stephen Hemminger

From: Stephen Hemminger <[email protected]>

Silence is normal. drivers should speak only when spoken to and not be chatty.

Signed-off-by Stephen Hemminger <[email protected]>
Acked-by Bruce Richardson <[email protected]>
Quoted 13 lines
---
 lib/librte_pmd_enic/enic_main.c | 2 --
 1 file changed, 2 deletions(-)
lib/librte_pmd_enic/enic_main.c +0 -0
index 0892b3e..508621e 100644
@@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic)
     struct rte_pci_device *pdev = enic->pdev;
     int err = -1;
Quoted 3 lines

lib/librte_pmd_enic/enic_main.c int enic_probe(struct enic *enic) · line 1053

Quoted 3 lines
lib/librte_pmd_enic/enic_main.c +0 -2
-    dev_debug(enic, " Initializing ENIC PMD version %s\n",
 DRV_VERSION);
-

It would be good to retain this under RTE_LIBRTE_ENIC_DEBUG.

Quoted 6 lines
Quoted 6 lines
lib/librte_pmd_enic/enic_main.c +0 -1
     enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
     enic->bar0.len = pdev->mem_resource[0].len;
 
--

2.1.4

#7 lore raw

PATCH v2 1/1 enic: silence log message unless debug enabled

In reply to Stephen Hemminger

This blocks the annoying ENIC driver initialization message unless debug is enabled. Drivers should speak only when spoken to and not be chatty.

Signed-off-by Stephen Hemminger <[email protected]>
---
 drivers/net/enic/enic_compat.h | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/enic/enic_compat.h +4 -0
index f3598ed..94656c8 100644
@@ -82,7 +82,11 @@
 #define dev_err(x, args...) dev_printk(ERR, args)
 #define dev_info(x, args...) dev_printk(INFO,  args)
 #define dev_warning(x, args...) dev_printk(WARNING, args)
+#ifdef RTE_LIBRTE_ENIC_DEBUG
 #define dev_debug(x, args...) dev_printk(DEBUG, args)
+#else
+#define dev_debug(x, args...) do { } while(0)
+#endif
 
 #define __le16 u16
 #define __le32 u32
Signature · 1 line
2.1.4
#8 lore raw

Re: [PATCH v2] enic: silence log message unless debug enabled

2015-07-30 10:03, Stephen Hemminger:

drivers/net/enic/enic_compat.h line 89

Quoted 11 lines
drivers/net/enic/enic_compat.h +4 -0
@@ -82,7 +82,11 @@
 #define dev_err(x, args...) dev_printk(ERR, args)
 #define dev_info(x, args...) dev_printk(INFO,  args)
 #define dev_warning(x, args...) dev_printk(WARNING, args)
+#ifdef RTE_LIBRTE_ENIC_DEBUG
 #define dev_debug(x, args...) dev_printk(DEBUG, args)
+#else
+#define dev_debug(x, args...) do { } while(0)
+#endif

I don't understand why it is needed:
dev_debug won't print anything if the log level is higher than DEBUG.

author
#9 lore raw

PATCH 2/2 tools: fix comment in bind script

In reply to a message not in the archive

From: Stephen Hemminger <[email protected]>

The function documentation was obviously copied and not updated.

Signed-off-by Stephen Hemminger <[email protected]>
---
 tools/dpdk_nic_bind.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/dpdk_nic_bind.py +1 -1
index 8523f82..b7bd877 100755
@@ -391,7 +391,7 @@ def unbind_all(dev_list, force=False):
         unbind_one(d, force)
 
 def bind_all(dev_list, driver, force=False):
-    """Unbind method, takes a list of device locations"""
+    """Bind method, takes a list of device locations"""
     global devices
 
     dev_list = map(dev_id_from_dev_name, dev_list)
Signature · 1 line
2.1.4

A message that is not in the archive (sent off-list or not yet received): 1428514670-7982-3-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org

Acked-by
#11 lore raw

Re: [PATCH 2/2] tools: fix comment in bind script

Quoted 5 lines · Stephen Hemminger

From: Stephen Hemminger <[email protected]>

The function documentation was obviously copied and not updated.

Signed-off-by Stephen Hemminger <[email protected]>
Acked-by Bruce Richardson <[email protected]>
Quoted 20 lines
---
 tools/dpdk_nic_bind.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/dpdk_nic_bind.py +1 -1
index 8523f82..b7bd877 100755
@@ -391,7 +391,7 @@ def unbind_all(dev_list, force=False):
         unbind_one(d, force)
 
 def bind_all(dev_list, driver, force=False):
-    """Unbind method, takes a list of device locations"""
+    """Bind method, takes a list of device locations"""
     global devices
 
     dev_list = map(dev_id_from_dev_name, dev_list)
Signature · 1 line
2.1.4