staging/lustre: Remove unused MDS_CLOSE_CLEANUP define

PATCH New Ben Evans 2 participants 3 messages Jul 6, 2015 Staging

lore

Share & tools

lore

Ben Evans

author

2015-07-06 18:30 UTC #0 lore raw

PATCH 1/1 staging/lustre: Remove unused MDS_CLOSE_CLEANUP define

Previously, MDS_CLOSE_CLEANUP was used to detect file closing, due to eviction. This flag is no longer used.

Signed-off-by Aurelien Degremont <[email protected]>

Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
Reviewed-on: http://review.whamcloud.com/7195

Reviewed-by Andreas Dilger <[email protected]>

Reviewed-by Jinshan Xiong <[email protected]>

Reviewed-by John L. Hammond <[email protected]>

Reviewed-by Fan Yong <[email protected]>

Reviewed-by Oleg Drokin <[email protected]>

Signed-off-by Ben Evans <[email protected]>

---
 .../lustre/lustre/include/lustre/lustre_idl.h      |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +1 -1

index 4d72d6e..14547d1 100644
@@ -2390,7 +2390,7 @@ enum mds_op_bias {
 	MDS_PERM_BYPASS		= 1 << 3,
 	MDS_SOM			= 1 << 4,
 	MDS_QUOTA_IGNORE	= 1 << 5,
-	MDS_CLOSE_CLEANUP	= 1 << 6,
+	/* MDS_UNUSED	= 1 << 6, */
 	MDS_KEEP_ORPHAN		= 1 << 7,
 	MDS_RECOV_OPEN		= 1 << 8,
 	MDS_DATA_MODIFIED	= 1 << 9,

Signature · 1 line

1.6.5.6

Dilger

2015-07-06 20:36 UTC #1 lore raw

PATCH 1/1 staging/lustre: Remove unused MDS_CLOSE_CLEANUP define

The character between "unused" and "MDS" in the patch summary line appears to be a tab instead of a space.

Quoted 23 lines · Ben Evans

Previously, MDS_CLOSE_CLEANUP was used to detect file closing, due to eviction.
This flag is no longer used.
Signed-off-by Aurelien Degremont <[email protected]>
Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
Reviewed-on: http://review.whamcloud.com/7195
Reviewed-by Andreas Dilger <[email protected]>
Reviewed-by Jinshan Xiong <[email protected]>
Reviewed-by John L. Hammond <[email protected]>
Reviewed-by Fan Yong <[email protected]>
Reviewed-by Oleg Drokin <[email protected]>
Signed-off-by Ben Evans <[email protected]>
---
.../lustre/lustre/include/lustre/lustre_idl.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +0 -0
index 4d72d6e..14547d1 100644

drivers/staging/lustre/lustre/include/lustre/lustre_idl.h enum mds_op_bias { · line 2393

Quoted 5 lines

drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +1 -1

@@ -2390,7 +2390,7 @@ enum mds_op_bias {
 	MDS_PERM_BYPASS		= 1 << 3,
 	MDS_SOM			= 1 << 4,
 	MDS_QUOTA_IGNORE	= 1 << 5,
-	MDS_CLOSE_CLEANUP	= 1 << 6,
+	/* MDS_UNUSED	= 1 << 6, */

When wire protocol definess are removed, it is better to use something like:

        /* MDS_CLOSE_CLEANUP = 1 << 6, obsolete since 2.4.0 */

The version is from "git describe 5165cdd" from the original commit.

drivers/staging/lustre/lustre/include/lustre/lustre_idl.h enum mds_op_bias { · line 2396

Quoted 3 lines

drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +0 -0
 	MDS_KEEP_ORPHAN		= 1 << 7,
 	MDS_RECOV_OPEN		= 1 << 8,
 	MDS_DATA_MODIFIED	= 1 << 9,

I think after these changes you could add the upstream maintainers to the "To:" and "CC:" so that the patch can be accepted upstream.

Cheers, Andreas

Signature · 4 lines

Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division

Ben Evans

author

2015-07-06 20:39 UTC #2 lore raw

PATCH 1/1 staging/lustre: Remove unused MDS_CLOSE_CLEANUP define

Ok, I'll clean it up. Thanks for all the help with the feedback

-Ben

-----Original Message-----
From: Dilger, Andreas [mailto:andreas.dilger at intel.com]
Sent: Monday, July 06, 2015 4:37 PM
To: Ben Evans
Cc: lustre-devel at lists.lustre.org
Subject: Re: [lustre-devel] [PATCH] staging/lustre: Remove unused MDS_CLOSE_CLEANUP define

The character between "unused" and "MDS" in the patch summary line appears to be a tab instead of a space.

Quoted 23 lines · Ben Evans

Previously, MDS_CLOSE_CLEANUP was used to detect file closing, due to eviction.
This flag is no longer used.
Signed-off-by Aurelien Degremont <[email protected]>
Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
Reviewed-on: http://review.whamcloud.com/7195
Reviewed-by Andreas Dilger <[email protected]>
Reviewed-by Jinshan Xiong <[email protected]>
Reviewed-by John L. Hammond <[email protected]>
Reviewed-by Fan Yong <[email protected]>
Reviewed-by Oleg Drokin <[email protected]>
Signed-off-by Ben Evans <[email protected]>
---
.../lustre/lustre/include/lustre/lustre_idl.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +0 -0
index 4d72d6e..14547d1 100644

drivers/staging/lustre/lustre/include/lustre/lustre_idl.h enum mds_op_bias { · line 2393

Quoted 5 lines

drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +1 -1

@@ -2390,7 +2390,7 @@ enum mds_op_bias {
 	MDS_PERM_BYPASS		= 1 << 3,
 	MDS_SOM			= 1 << 4,
 	MDS_QUOTA_IGNORE	= 1 << 5,
-	MDS_CLOSE_CLEANUP	= 1 << 6,
+	/* MDS_UNUSED	= 1 << 6, */

When wire protocol definess are removed, it is better to use something like:

        /* MDS_CLOSE_CLEANUP = 1 << 6, obsolete since 2.4.0 */

The version is from "git describe 5165cdd" from the original commit.

drivers/staging/lustre/lustre/include/lustre/lustre_idl.h enum mds_op_bias { · line 2396

Quoted 3 lines

drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +0 -0
 	MDS_KEEP_ORPHAN		= 1 << 7,
 	MDS_RECOV_OPEN		= 1 << 8,
 	MDS_DATA_MODIFIED	= 1 << 9,

I think after these changes you could add the upstream maintainers to the "To:" and "CC:" so that the patch can be accepted upstream.

Cheers, Andreas
--
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division