Skip to contentSkip to conversation

tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

PATCH Applied Stefan Berger 3 participants 4 messages Jul 29, 2024 – Aug 1, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

Commit d2add27cf2b8 ("tpm: Add NULL primary creation") introduced CONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the following message appears in the kernel log due to a missing call to tpm2_sessions_init().

[    2.654549] tpm tpm0: auth session is not active

Add the missing call to tpm2_session_init() to the ibmvtpm driver to resolve this issue.

Fixes d2add27cf2b8 ("tpm: Add NULL primary creation")
---
 drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/char/tpm/tpm_ibmvtpm.c +4 -0
index d3989b257f42..1e5b107d1f3b 100644
@@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
 		rc = tpm2_get_cc_attrs_tbl(chip);
 		if (rc)
 			goto init_irq_cleanup;
+
+		rc = tpm2_sessions_init(chip);
+		if (rc)
+			goto init_irq_cleanup;
 	}
 
 	return tpm_chip_register(chip);
Signature · 1 line
2.45.2
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 21 lines · Stefan Berger

Commit d2add27cf2b8 ("tpm: Add NULL primary creation") introduced CONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the following message appears in the kernel log due to a missing call to tpm2_sessions_init().

[    2.654549] tpm tpm0: auth session is not active

Add the missing call to tpm2_session_init() to the ibmvtpm driver to resolve this issue.

Fixes d2add27cf2b8 ("tpm: Add NULL primary creation")
---
 drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/char/tpm/tpm_ibmvtpm.c +0 -0
index d3989b257f42..1e5b107d1f3b 100644

drivers/char/tpm/tpm_ibmvtpm.c static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, · line 707

Quoted 10 lines
drivers/char/tpm/tpm_ibmvtpm.c +4 -0
@@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
 		rc = tpm2_get_cc_attrs_tbl(chip);
 		if (rc)
 			goto init_irq_cleanup;
+
+		rc = tpm2_sessions_init(chip);
+		if (rc)
+			goto init_irq_cleanup;
 	}
 
 	return tpm_chip_register(chip);

BR, Jarkko

maintainer
#2 lore raw
In reply to Stefan Berger
Quoted 21 lines · Stefan Berger

Commit d2add27cf2b8 ("tpm: Add NULL primary creation") introduced CONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the following message appears in the kernel log due to a missing call to tpm2_sessions_init().

[    2.654549] tpm tpm0: auth session is not active

Add the missing call to tpm2_session_init() to the ibmvtpm driver to resolve this issue.

Fixes d2add27cf2b8 ("tpm: Add NULL primary creation")
---
 drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/char/tpm/tpm_ibmvtpm.c +0 -0
index d3989b257f42..1e5b107d1f3b 100644

drivers/char/tpm/tpm_ibmvtpm.c static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, · line 707

Quoted 10 lines
drivers/char/tpm/tpm_ibmvtpm.c +4 -0
@@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
 		rc = tpm2_get_cc_attrs_tbl(chip);
 		if (rc)
 			goto init_irq_cleanup;
+
+		rc = tpm2_sessions_init(chip);
+		if (rc)
+			goto init_irq_cleanup;
 	}
 
 	return tpm_chip_register(chip);

Cannot get emails working with my Linux machine given

https://bugzilla.redhat.com/show_bug.cgi?id=2302132

I'll try to sort this out first and then do a pull request.

BR, Jarkko

#3 lore raw
In reply to Stefan Berger
Quoted 21 lines · Stefan Berger

Commit d2add27cf2b8 ("tpm: Add NULL primary creation") introduced CONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the following message appears in the kernel log due to a missing call to tpm2_sessions_init().

[    2.654549] tpm tpm0: auth session is not active

Add the missing call to tpm2_session_init() to the ibmvtpm driver to resolve this issue.

Fixes d2add27cf2b8 ("tpm: Add NULL primary creation")
---
 drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/char/tpm/tpm_ibmvtpm.c +0 -0
index d3989b257f42..1e5b107d1f3b 100644

drivers/char/tpm/tpm_ibmvtpm.c static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, · line 707

Quoted 10 lines
drivers/char/tpm/tpm_ibmvtpm.c +4 -0
@@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
 		rc = tpm2_get_cc_attrs_tbl(chip);
 		if (rc)
 			goto init_irq_cleanup;
+
+		rc = tpm2_sessions_init(chip);
+		if (rc)
+			goto init_irq_cleanup;
 	}
 
 	return tpm_chip_register(chip);

Applied!

BR, Jarkko