tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support
Subsystems (3)
PATCH v2 1/1 tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support
Commit d2add27cf2b8 ("tpm: Add NULL primary creation") introduced CONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the following message appears in the kernel log due to a missing call to tpm2_sessions_init().
[ 2.654549] tpm tpm0: auth session is not active
Add the missing call to tpm2_session_init() to the ibmvtpm driver to resolve this issue.
--- drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/char/tpm/tpm_ibmvtpm.c +4 -0
@@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, rc =tpm2_get_cc_attrs_tbl (chip);if (rc) goto init_irq_cleanup; + + rc =tpm2_sessions_init (chip); +if (rc) + goto init_irq_cleanup; }return tpm_chip_register (chip);
Signature · 1 line
2.45.2
Quoted 21 lines · Stefan Berger
Commit
d2add27cf2b8("tpm: Add NULL primary creation") introducedCONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the following message appears in the kernel log due to a missing call totpm2_sessions_init().[ 2.654549] tpm tpm0: auth session is not activeAdd the missing call to
tpm2_session_init()to the ibmvtpm driver to resolve this issue.Fixes d2add27cf2b8 ("tpm: Add NULL primary creation")Signed-off-by Stefan Berger <[email protected]>--- drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/char/tpm/tpm_ibmvtpm.c +0
-0
drivers/char/tpm/tpm_ibmvtpm.c static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, · line 707
Quoted 10 lines
drivers/char/tpm/tpm_ibmvtpm.c +4
-0@@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, rc =tpm2_get_cc_attrs_tbl (chip);if (rc) goto init_irq_cleanup; + + rc =tpm2_sessions_init (chip); +if (rc) + goto init_irq_cleanup; }return tpm_chip_register (chip);
BR, Jarkko
Jarkko Sakkinen
maintainerQuoted 21 lines · Stefan Berger
Commit
d2add27cf2b8("tpm: Add NULL primary creation") introducedCONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the following message appears in the kernel log due to a missing call totpm2_sessions_init().[ 2.654549] tpm tpm0: auth session is not activeAdd the missing call to
tpm2_session_init()to the ibmvtpm driver to resolve this issue.Fixes d2add27cf2b8 ("tpm: Add NULL primary creation")Signed-off-by Stefan Berger <[email protected]>--- drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/char/tpm/tpm_ibmvtpm.c +0
-0
drivers/char/tpm/tpm_ibmvtpm.c static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, · line 707
Quoted 10 lines
drivers/char/tpm/tpm_ibmvtpm.c +4
-0@@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, rc =tpm2_get_cc_attrs_tbl (chip);if (rc) goto init_irq_cleanup; + + rc =tpm2_sessions_init (chip); +if (rc) + goto init_irq_cleanup; }return tpm_chip_register (chip);
Cannot get emails working with my Linux machine given
https://bugzilla.redhat.com/show_bug.cgi?id=2302132
I'll try to sort this out first and then do a pull request.
BR, Jarkko
Jarkko Sakkinen
AppliedQuoted 21 lines · Stefan Berger
Commit
d2add27cf2b8("tpm: Add NULL primary creation") introducedCONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the following message appears in the kernel log due to a missing call totpm2_sessions_init().[ 2.654549] tpm tpm0: auth session is not activeAdd the missing call to
tpm2_session_init()to the ibmvtpm driver to resolve this issue.Fixes d2add27cf2b8 ("tpm: Add NULL primary creation")Signed-off-by Stefan Berger <[email protected]>--- drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/char/tpm/tpm_ibmvtpm.c +0
-0
drivers/char/tpm/tpm_ibmvtpm.c static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, · line 707
Quoted 10 lines
drivers/char/tpm/tpm_ibmvtpm.c +4
-0@@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, rc =tpm2_get_cc_attrs_tbl (chip);if (rc) goto init_irq_cleanup; + + rc =tpm2_sessions_init (chip); +if (rc) + goto init_irq_cleanup; }return tpm_chip_register (chip);
Applied!
BR, Jarkko