Skip to contentSkip to conversation

ASoC: cs4270: fix DAPM stream name mismatch

PATCH Superseded murray foster 4 participants 6 messages Jul 2, 2016 – Oct 6, 2016 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 201607021540.sGu2oITV%[email protected]

#1 lore raw

PATCH v2 1/1 ASoC: cs4270: fix DAPM stream name mismatch

Mismatching stream names in DAPM route and widget definitions are causing compilation errors. Fixing these names allows the cs4270 driver to compile and function.

---
Changes in v2:
- Remove the 's' typo at the beginning of the codec driver.

 sound/soc/codecs/cs4270.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
sound/soc/codecs/cs4270.c +4 -4
index e07807d..3670086 100644
@@ -148,11 +148,11 @@ SND_SOC_DAPM_OUTPUT("AOUTR"),
 };
 
 static const struct snd_soc_dapm_route cs4270_dapm_routes[] = {
-	{ "Capture", NULL, "AINA" },
-	{ "Capture", NULL, "AINB" },
+	{ "Capture", NULL, "AINL" },
+	{ "Capture", NULL, "AINR" },
 
-	{ "AOUTA", NULL, "Playback" },
-	{ "AOUTB", NULL, "Playback" },
+	{ "AOUTL", NULL, "Playback" },
+	{ "AOUTR", NULL, "Playback" },
 };
 
 /**
Signature · 1 line
2.4.9
Acked-by on v2 1/1
#2 lore raw
Quoted 21 lines · murray foster

Mismatching stream names in DAPM route and widget definitions are causing compilation errors. Fixing these names allows the cs4270 driver to compile and function.

---
Changes in v2:
- Remove the 's' typo at the beginning of the codec driver.

sound/soc/codecs/cs4270.c | 8 ++++----

1 file changed, 4 insertions(+), 4 deletions(-)
sound/soc/codecs/cs4270.c +0 -0
index e07807d..3670086 100644
@@ -148,11 +148,11 @@ SND_SOC_DAPM_OUTPUT("AOUTR"),
 };
 
 static const struct snd_soc_dapm_route cs4270_dapm_routes[] = {

sound/soc/codecs/cs4270.c SND_SOC_DAPM_OUTPUT("AOUTR"), · line 156

Quoted 10 lines
sound/soc/codecs/cs4270.c +4 -4
-	{ "Capture", NULL, "AINA" },
-	{ "Capture", NULL, "AINB" },
+	{ "Capture", NULL, "AINL" },
+	{ "Capture", NULL, "AINR" },
 
-	{ "AOUTA", NULL, "Playback" },
-	{ "AOUTB", NULL, "Playback" },
+	{ "AOUTL", NULL, "Playback" },
+	{ "AOUTR", NULL, "Playback" },
 };
#4 lore raw
Quoted 9 lines · murray foster
Quoted 3 lines · Paul

What's the next step after patch acknowledgement? I'm a newbie on the list so I'm sure there's some step I've missed or misinterpreted.

Apply is the next step. But sometimes patches get lost, simply due to the sheer volume.

Best is to re-send the patch with the Acked-by added to the commit message and make sure send the patch to maintainers (Mark and Liam) with the ALSA list on Cc. This will make sure that they see the patch and it gets applied.

maintainer
#5 lore raw
Quoted 3 lines · Lars-Peter Clausen

Best is to re-send the patch with the Acked-by added to the commit message and make sure send the patch to maintainers (Mark and Liam) with the ALSA list on Cc. This will make sure that they see the patch and it gets applied.

I didn't get sent the original e-mail in the first place :(

maintainer
#6 lore raw
In reply to murray foster
Quoted 2 lines · murray foster

What's the next step after patch acknowledgement? I'm a newbie on the list so I'm sure there's some step I've missed or misinterpreted.

As documented in SubmittingPatches please send patches to the maintainers for the code you would like to change. The normal kernel workflow is that people apply patches from their inboxes, if they aren't copied they are likely to not see the patch at all and it is much more difficult to apply patches.