drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms
Subsystems (3)
PATCH 1/1 drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms
From: Bob Paauwe <[email protected]>
The WA specifies that we need to toggle a SDE chicken bit on and then off as the final step in preparation for s0ix entry.
Bspec: 33450
Bspec: 8402However, something is happening after we toggle the bit that causes the WA to be invalidated. This makes dispcnlunit1_cp_xosc_clkreq active being already in s0ix state i.e SLP_S0 counter incremented. Tweaking the Wa_14010685332 by setting the bit on suspend and clearing it on resume turns down the dispcnlunit1_cp_xosc_clkreq. B.Spec has Documented this tweaked sequence of WA as an alternative. Let keep this tweaked WA for Gen11 platforms and keep untweaked WA for other platforms which never observed this issue.
v2 (MattR):
- Change the comment on the workaround to give PCH names rather than platform names. Although the bspec is setup to list workarounds by platform, the hardware team has confirmed that the actual issue being worked around here is something that was introduced back in the Cannon Lake PCH and carried forward to subsequent PCH's.
- Extend the untweaked version of the workaround to include PCH_CNP as well. Note that since PCH_CNP is used to represent CMP, this will apply on CML and some variants of RKL too.
- Cap the untweaked version of the workaround so that it won't apply to "fake" PCH's (i.e., DG1). The issue we're working around really is an issue in the PCH itself, not the South Display, so it shouldn't apply when there isn't a real PCH.
--- .../drm/i915/display/intel_display_power.c | 21 +++++++++++++++++-- drivers/gpu/drm/i915/i915_irq.c | 6 ++++-- 2 files changed, 23 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +19 -2
@@ -5858,17 +5858,34 @@ static void intel_power_domains_verify_state(struct drm_i915_private *i915)void intel_display_power_suspend_late (struct drm_i915_private *i915) { -if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) +u32 val; + +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {bxt_enable_dc9 (i915); -else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val |=SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val); + } + }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_enable_pc8 (i915); + } }void intel_display_power_resume_early (struct drm_i915_private *i915) { +u32 val; +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {gen9_sanitize_dc_state (i915);bxt_disable_dc9 (i915); +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val &= ~SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val); + } }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_disable_pc8 (i915); }
drivers/gpu/drm/i915/i915_irq.c +4 -2
@@ -3055,8 +3055,10 @@ static void gen11_display_irq_reset(struct drm_i915_private *dev_priv)if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP )GEN3_IRQ_RESET (uncore,SDE ); -/* Wa_14010685332:icl,jsl,ehl,tgl,rkl */ -if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP ) { +/* Wa_14010685332:cnp/cmp,tgp,adp */ +if (INTEL_PCH_TYPE (dev_priv) ==PCH_CNP || + (INTEL_PCH_TYPE (dev_priv) >=PCH_TGP && +INTEL_PCH_TYPE (dev_priv) <PCH_DG1 )) {intel_uncore_rmw (uncore,SOUTH_CHICKEN1 ,SBCLK_RUN_REFCLK_DIS ,SBCLK_RUN_REFCLK_DIS ); intel_uncore_rmw(uncore, SOUTH_CHICKEN1,
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms
== Series Details ==
== Series Details ==
Series: drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms
URL : https://patchwork.freedesktop.org/series/83233/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9224 -> Patchwork_18811
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/index.html
New tests
---------
New tests have been introduced between CI_DRM_9224 and Patchwork_18811:
### New CI tests (1) ###
* boot:
- Statuses : 39 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18811 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#1982] / [k.org#205379])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-tgl-y/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-tgl-y/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [PASS][3] -> [DMESG-WARN][4] ([i915#2605])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-skl-lmem/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-skl-lmem/igt@[email protected]
* igt@kms_busy@basic@flip:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-tgl-y/igt@kms_busy@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-tgl-y/igt@kms_busy@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-icl-u2/igt@kms_flip@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-icl-u2/igt@kms_flip@[email protected]
* igt@prime_vgem@basic-gtt:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#402]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-tgl-y/igt@[email protected]
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-kbl-7500u: [DMESG-WARN][11] -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-kbl-7500u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-kbl-7500u/igt@[email protected]
* igt@i915_module_load@reload:
- fi-byt-j1900: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-byt-j1900/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-byt-j1900/igt@[email protected]
- fi-apl-guc: [DMESG-WARN][15] ([i915#1635] / [i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-apl-guc/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-apl-guc/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-icl-y: [INCOMPLETE][17] ([i915#2276]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-icl-y/igt@i915_selftest@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-icl-y/igt@i915_selftest@[email protected]
* igt@kms_busy@basic@flip:
- {fi-tgl-dsi}: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-tgl-dsi/igt@kms_busy@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-tgl-dsi/igt@kms_busy@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-cml-u2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-cml-u2/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bxt-dsi: [DMESG-WARN][23] ([i915#1635] / [i915#1982]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-bxt-dsi/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-bxt-dsi/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- fi-tgl-y: [DMESG-WARN][25] ([i915#402]) -> [PASS][26] +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-tgl-y/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-tgl-y/igt@[email protected]
#### Warnings ####
* igt@i915_module_load@reload:
- fi-icl-u2: [DMESG-WARN][27] ([i915#289]) -> [DMESG-WARN][28] ([i915#1982] / [i915#289])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/fi-icl-u2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/fi-icl-u2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2417]: https://gitlab.freedesktop.org/drm/intel/issues/2417
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (43 -> 39)
------------------------------
Missing (4): fi-kbl-soraka fi-bsw-cyan fi-bdw-samus fi-tgl-u2
Build changes
-------------
* Linux: CI_DRM_9224 -> Patchwork_18811
CI-20190529: 20190529
CI_DRM_9224: a2bcd1ea633c3d2f5872eedb12a9255a2e5b1fc7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5828: db972bdaab8ada43b742bc9621bb0fc9d56a6fc6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18811: 64158c17654257f7f00863d152e36eda712ac320 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
64158c176542 drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms
In reply to Anshuman Gupta== Series Details ==
== Series Details ==
Series: drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms
URL : https://patchwork.freedesktop.org/series/83233/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9224_full -> Patchwork_18811_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18811_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18811_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18811_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_parallel@contexts@bcs0:
- shard-snb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-snb5/igt@gem_exec_parallel@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-snb7/igt@gem_exec_parallel@[email protected]
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-snb: [PASS][3] -> [DMESG-FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-snb4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-snb4/igt@[email protected]
#### Warnings ####
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-glk: [FAIL][5] ([i915#1119]) -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-glk9/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-glk9/igt@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_9224_full and Patchwork_18811_full:
### New CI tests (1) ###
* boot:
- Statuses : 175 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18811_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#658])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-iclb2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-iclb6/igt@[email protected]
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-kbl6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-kbl2/igt@[email protected]
* igt@i915_pm_backlight@fade_with_suspend:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([i915#146])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl7/igt@i915_pm_backlight@fade_with_suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl9/igt@i915_pm_backlight@fade_with_suspend.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][13] -> [FAIL][14] ([i915#454])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-iclb4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-iclb8/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#1635] / [i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-apl3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-apl3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#54]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl6/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-kbl1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-kbl4/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
- shard-tglb: [PASS][21] -> [FAIL][22] ([i915#2346])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-tglb5/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-tglb3/igt@[email protected]
* igt@kms_cursor_legacy@short-flip-before-cursor-toggle:
- shard-glk: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-glk5/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-glk1/igt@[email protected]
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][25] -> [DMESG-WARN][26] ([i915#118] / [i915#95])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-glk1/igt@kms_flip@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-glk9/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#79])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl9/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-panning-interruptible@a-edp1:
- shard-skl: [PASS][29] -> [DMESG-WARN][30] ([i915#1982]) +6 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl3/igt@kms_flip@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl10/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@a-edp1:
- shard-skl: [PASS][31] -> [FAIL][32] ([i915#2122])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl9/igt@kms_flip@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl10/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][33] -> [FAIL][34] ([i915#1188])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl9/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl10/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#1036])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][37] -> [FAIL][38] ([fdo#108145] / [i915#265])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl6/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109642] / [fdo#111068])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-iclb2/igt@kms_psr2_su@page_flip.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-iclb3/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109441]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-d:
- shard-tglb: [PASS][43] -> [DMESG-WARN][44] ([i915#1982])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-tglb5/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-tglb3/igt@[email protected]
#### Possible fixes ####
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-tglb: [FAIL][45] ([i915#2521]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-tglb1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-tglb5/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-skl: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl4/igt@[email protected]
* igt@kms_big_fb@x-tiled-16bpp-rotate-0:
- shard-kbl: [DMESG-WARN][49] ([i915#1982]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-kbl7/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-kbl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x128-random:
- shard-skl: [FAIL][51] ([i915#54]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl8/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- shard-apl: [DMESG-WARN][53] ([i915#1635] / [i915#1982]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-apl3/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-apl7/igt@[email protected]
* igt@kms_flip@2x-flip-vs-panning@ab-hdmi-a1-hdmi-a2:
- shard-glk: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56] +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-glk5/igt@kms_flip@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-glk2/igt@kms_flip@[email protected]
* igt@kms_flip@blocking-wf_vblank@c-edp1:
- shard-skl: [FAIL][57] ([i915#2122]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl6/igt@kms_flip@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][59] ([i915#79]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl4/igt@kms_flip@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-iclb: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][63] ([fdo#108145] / [i915#265]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl1/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl7/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-iclb5/igt@kms_psr@psr2_cursor_render.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@sysfs_heartbeat_interval@mixed@vcs0:
- shard-skl: [INCOMPLETE][67] ([i915#1731] / [i915#198]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl4/igt@sysfs_heartbeat_interval@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl4/igt@sysfs_heartbeat_interval@[email protected]
#### Warnings ####
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-skl: [DMESG-FAIL][69] ([i915#1982]) -> [DMESG-WARN][70] ([i915#1982])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl7/igt@[email protected]
* igt@kms_setmode@basic:
- shard-skl: [FAIL][71] ([i915#31]) -> [DMESG-FAIL][72] ([i915#1982] / [i915#31])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9224/shard-skl3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/shard-skl4/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1036]: https://gitlab.freedesktop.org/drm/intel/issues/1036
[i915#1119]: https://gitlab.freedesktop.org/drm/intel/issues/1119
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9224 -> Patchwork_18811
CI-20190529: 20190529
CI_DRM_9224: a2bcd1ea633c3d2f5872eedb12a9255a2e5b1fc7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5828: db972bdaab8ada43b742bc9621bb0fc9d56a6fc6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18811: 64158c17654257f7f00863d152e36eda712ac320 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18811/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms (rev2)
In reply to Anshuman Gupta== Series Details ==
== Series Details ==
Series: drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms (rev2)
URL : https://patchwork.freedesktop.org/series/83233/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9246 -> Patchwork_18827
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/index.html
New tests
---------
New tests have been introduced between CI_DRM_9246 and Patchwork_18827:
### New CI tests (1) ###
* boot:
- Statuses : 39 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18827 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-skl-6700k2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-skl-6700k2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-skl-6700k2/igt@[email protected]
- fi-skl-lmem: [PASS][3] -> [DMESG-WARN][4] ([i915#2605])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-skl-lmem/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-skl-lmem/igt@[email protected]
- fi-tgl-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-tgl-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-tgl-u2/igt@[email protected]
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [PASS][7] -> [FAIL][8] ([i915#1888])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-tgl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-tgl-u2/igt@[email protected]
* igt@i915_module_load@reload:
- fi-bsw-n3050: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-bsw-n3050/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-bsw-n3050/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-bsw-kefka/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-bsw-kefka/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-icl-u2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-icl-u2/igt@[email protected]
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-icl-u2: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-icl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-icl-u2/igt@[email protected]
- fi-tgl-u2: [DMESG-WARN][17] ([i915#1982] / [k.org#205379]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-tgl-u2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-tgl-u2/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-apl-guc: [DMESG-WARN][19] ([i915#1635] / [i915#1982]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-apl-guc/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-apl-guc/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- {fi-tgl-dsi}: [INCOMPLETE][21] ([i915#2601]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [DMESG-WARN][23] ([i915#1982]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-cml-u2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-cml-u2/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- {fi-kbl-7560u}: [DMESG-WARN][25] ([i915#1982]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-kbl-7560u/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-kbl-7560u/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- {fi-tgl-dsi}: [DMESG-WARN][27] ([i915#1982]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-tgl-dsi/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-tgl-dsi/igt@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [SKIP][29] ([fdo#109271]) -> [FAIL][30] ([i915#579])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/fi-kbl-guc/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/fi-kbl-guc/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2601]: https://gitlab.freedesktop.org/drm/intel/issues/2601
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (44 -> 39)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-tgl-y fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9246 -> Patchwork_18827
CI-20190529: 20190529
CI_DRM_9246: b870a15d5fca59aa694df1d2e42446c757f134ac @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5830: 12d370cb57e0cfcb781c87ad9e15e68b17a1f41f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18827: bc0260df12fd34582ab1fa6691f5f81c122ef80b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
bc0260df12fd drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms (rev2)
In reply to Anshuman Gupta== Series Details ==
== Series Details ==
Series: drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms (rev2)
URL : https://patchwork.freedesktop.org/series/83233/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9246_full -> Patchwork_18827_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18827_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18827_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18827_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_fence@invalid-fence-array:
- shard-snb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-snb6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-snb4/igt@[email protected]
#### Warnings ####
* igt@kms_flip@flip-vs-suspend-interruptible@d-edp1:
- shard-tglb: [DMESG-WARN][3] ([i915#2411]) -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-tglb1/igt@kms_flip@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-tglb3/igt@kms_flip@[email protected]
### Piglit changes ###
#### Possible regressions ####
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-double_dmat3x4-double_dmat2_array2-position (NEW):
- {pig-icl-1065g7}: NOTRUN -> [INCOMPLETE][5] +7 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/pig-icl-1065g7/spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-double_dmat3x4-double_dmat2_array2-position.html
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-float_float_array3-double_dmat2x4_array2-position (NEW):
- {pig-icl-1065g7}: NOTRUN -> [CRASH][6] +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/pig-icl-1065g7/spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-float_float_array3-double_dmat2x4_array2-position.html
New tests
---------
New tests have been introduced between CI_DRM_9246_full and Patchwork_18827_full:
### New CI tests (1) ###
* boot:
- Statuses : 175 pass(s)
- Exec time: [0.0] s
### New Piglit tests (11) ###
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-double_dmat2-double_double-position:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-double_dmat3x4-double_dmat2_array2-position:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-double_dmat4-position-float_vec2:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-float_float_array3-double_dmat2x4_array2-position:
- Statuses : 1 crash(s)
- Exec time: [0.73] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-int_int-double_dmat3x4-position:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-double_dmat4-double_dvec4:
- Statuses : 1 crash(s)
- Exec time: [0.65] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-float_vec3_array3-double_dmat3:
- Statuses : 1 crash(s)
- Exec time: [0.70] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-uint_uint_array3-double_dmat3x4:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-uint_uvec2-double_dmat2x3:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-ushort_uvec3-double_dmat3x4:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-uint_uint-position-double_dmat4x2:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18827_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-snb: [PASS][7] -> [INCOMPLETE][8] ([i915#82])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-snb6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-snb4/igt@[email protected]
* igt@kms_big_fb@y-tiled-16bpp-rotate-0:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-kbl1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-kbl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#54]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl10/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl6/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled:
- shard-skl: [PASS][13] -> [FAIL][14] ([i915#52] / [i915#54])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl10/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl6/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#1635] / [i915#1982]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-apl1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-apl4/igt@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#2122])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-glk3/igt@kms_flip@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-glk5/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-edp1:
- shard-skl: [PASS][19] -> [INCOMPLETE][20] ([i915#198])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl3/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl3/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#2122]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl3/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl3/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +9 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl3/igt@kms_flip@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl3/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-glk: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-glk9/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-glk4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- shard-glk: [PASS][27] -> [DMESG-FAIL][28] ([i915#118] / [i915#95])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-glk6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-glk7/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][29] -> [INCOMPLETE][30] ([i915#123])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl3/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl10/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#108145] / [i915#265]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl3/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-iclb3/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@perf@polling-parameterized:
- shard-glk: [PASS][35] -> [FAIL][36] ([i915#1542])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-glk8/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-glk6/igt@[email protected]
#### Possible fixes ####
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][37] ([i915#1436] / [i915#716]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl8/igt@[email protected]
* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- shard-skl: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl10/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding:
- shard-skl: [FAIL][41] ([i915#54]) -> [PASS][42] +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl8/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl1/igt@[email protected]
* igt@kms_cursor_legacy@cursorb-vs-flipa-legacy:
- shard-glk: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-glk5/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-glk9/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][45] ([i915#2346]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [FAIL][47] ([i915#79]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl1/igt@kms_flip@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl1/igt@kms_flip@[email protected]
* igt@kms_flip_tiling@flip-to-yf-tiled:
- shard-kbl: [DMESG-WARN][49] ([i915#1982]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-kbl4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-kbl4/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][51] ([i915#1188]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl4/igt@[email protected]
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-c:
- shard-skl: [FAIL][53] -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl6/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: [INCOMPLETE][55] ([i915#1185] / [i915#250]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-iclb8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][57] ([fdo#108145] / [i915#265]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl9/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl3/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][59] ([fdo#109642] / [fdo#111068]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb7/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][61] ([fdo#109441]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_gtt.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][63] ([i915#1635] / [i915#31]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-apl7/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-apl3/igt@[email protected]
* igt@kms_vblank@pipe-b-wait-forked-busy-hang:
- shard-apl: [DMESG-WARN][65] ([i915#1635] / [i915#1982]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-apl4/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-apl6/igt@[email protected]
* igt@perf_pmu@module-unload:
- shard-iclb: [DMESG-WARN][67] ([i915#1982]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb5/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-iclb5/igt@[email protected]
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][69] ([i915#588]) -> [SKIP][70] ([i915#658])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb2/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-iclb4/igt@[email protected]
* igt@kms_color@pipe-a-ctm-red-to-blue:
- shard-skl: [DMESG-WARN][71] ([i915#1982]) -> [DMESG-FAIL][72] ([i915#1982]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl10/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [DMESG-FAIL][73] ([i915#1982]) -> [DMESG-WARN][74] ([i915#1982])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl6/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl10/igt@[email protected]
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][75] ([i915#1226]) -> [SKIP][76] ([fdo#109349])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-iclb2/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-iclb1/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [DMESG-WARN][77] ([i915#2411]) -> [DMESG-WARN][78] ([i915#1436] / [i915#2411])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-tglb1/igt@kms_flip@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-tglb3/igt@kms_flip@[email protected]
* igt@kms_flip_tiling@flip-x-tiled:
- shard-skl: [DMESG-WARN][79] ([i915#1982]) -> [DMESG-FAIL][80] ([fdo#108145] / [i915#1982])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-skl10/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: [FAIL][81] ([fdo#108145] / [i915#1635] / [i915#265]) -> [DMESG-FAIL][82] ([fdo#108145] / [i915#1635] / [i915#1982])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-apl8/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-apl4/igt@[email protected]
* igt@runner@aborted:
- shard-tglb: [FAIL][83] ([i915#2439]) -> ([FAIL][84], [FAIL][85]) ([i915#2248] / [i915#2439])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9246/shard-tglb6/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-tglb5/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/shard-tglb3/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2248]: https://gitlab.freedesktop.org/drm/intel/issues/2248
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9246 -> Patchwork_18827
CI-20190529: 20190529
CI_DRM_9246: b870a15d5fca59aa694df1d2e42446c757f134ac @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5830: 12d370cb57e0cfcb781c87ad9e15e68b17a1f41f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18827: bc0260df12fd34582ab1fa6691f5f81c122ef80b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18827/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerQuoted 49 lines · Anshuman Gupta
From: Bob Paauwe <[email protected]>
The WA specifies that we need to toggle a SDE chicken bit on and then off as the final step in preparation for s0ix entry.
Bspec: 33450 Bspec: 8402However, something is happening after we toggle the bit that causes the WA to be invalidated. This makes
dispcnlunit1_cp_xosc_clkreqactive being already in s0ix state i.eSLP_S0counter incremented. Tweaking theWa_14010685332by setting the bit on suspend and clearing it on resume turns down thedispcnlunit1_cp_xosc_clkreq. B.Spec has Documented this tweaked sequence of WA as an alternative. Let keep this tweaked WA for Gen11 platforms and keep untweaked WA for other platforms which never observed this issue.v2 (MattR):
- Change the comment on the workaround to give PCH names rather than platform names. Although the bspec is setup to list workarounds by platform, the hardware team has confirmed that the actual issue being worked around here is something that was introduced back in the Cannon Lake PCH and carried forward to subsequent PCH's.
- Extend the untweaked version of the workaround to includePCH_CNPas well. Note that sincePCH_CNPis used to represent CMP, this will apply on CML and some variants of RKL too.
- Cap the untweaked version of the workaround so that it won't apply to "fake" PCH's (i.e., DG1). The issue we're working around really is an issue in the PCH itself, not the South Display, so it shouldn't apply when there isn't a real PCH.Cc Rodrigo Vivi <[email protected]>Signed-off-by Bob Paauwe <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>Signed-off-by Matt Roper <[email protected]>--- .../drm/i915/display/intel_display_power.c | 21 +++++++++++++++++-- drivers/gpu/drm/i915/i915_irq.c | 6 ++++-- 2 files changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +0
-1@@ -5858,17 +5858,34 @@ static void intel_power_domains_verify_state(struct drm_i915_private *i915)void intel_display_power_suspend_late (struct drm_i915_private *i915) { -if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915))
drivers/gpu/drm/i915/display/intel_display_power.c static void intel_power_domains_verify_state(struct drm_i915_private *i915) · line 5869
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_power.c +8
-1+u32 val; + +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {bxt_enable_dc9 (i915); - else if (IS_HASWELL(i915) || IS_BROADWELL(i915)) +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val |=SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val);
could we use intel_de_rmw here?
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_power.c +3
-0+ } + }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_enable_pc8 (i915); + } }void intel_display_power_resume_early (struct drm_i915_private *i915) {
drivers/gpu/drm/i915/display/intel_display_power.c static void intel_power_domains_verify_state(struct drm_i915_private *i915) · line 5887
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_power.c +7
-0+u32 val; +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {gen9_sanitize_dc_state (i915);bxt_disable_dc9 (i915); +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val &= ~SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val);
and here?
sorry for not having spotted that sooner.
Quoted 28 lines
drivers/gpu/drm/i915/display/intel_display_power.c +1
-0+ } }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_disable_pc8 (i915); }drivers/gpu/drm/i915/i915_irq.c +4
-2@@ -3055,8 +3055,10 @@ static void gen11_display_irq_reset(struct drm_i915_private *dev_priv)if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP )GEN3_IRQ_RESET (uncore,SDE ); -/* Wa_14010685332:icl,jsl,ehl,tgl,rkl */ -if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP ) { +/* Wa_14010685332:cnp/cmp,tgp,adp */ +if (INTEL_PCH_TYPE (dev_priv) ==PCH_CNP || + (INTEL_PCH_TYPE (dev_priv) >=PCH_TGP && +INTEL_PCH_TYPE (dev_priv) <PCH_DG1 )) {intel_uncore_rmw (uncore,SOUTH_CHICKEN1 ,SBCLK_RUN_REFCLK_DIS ,SBCLK_RUN_REFCLK_DIS ); intel_uncore_rmw(uncore, SOUTH_CHICKEN1,Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 47 lines · Rodrigo Vivi
Quoted 46 lines · Anshuman Gupta
From: Bob Paauwe <[email protected]>
The WA specifies that we need to toggle a SDE chicken bit on and then off as the final step in preparation for s0ix entry.
Bspec: 33450 Bspec: 8402However, something is happening after we toggle the bit that causes the WA to be invalidated. This makes
dispcnlunit1_cp_xosc_clkreqactive being already in s0ix state i.eSLP_S0counter incremented. Tweaking theWa_14010685332by setting the bit on suspend and clearing it on resume turns down thedispcnlunit1_cp_xosc_clkreq. B.Spec has Documented this tweaked sequence of WA as an alternative. Let keep this tweaked WA for Gen11 platforms and keep untweaked WA for other platforms which never observed this issue.v2 (MattR):
- Change the comment on the workaround to give PCH names rather than platform names. Although the bspec is setup to list workarounds by platform, the hardware team has confirmed that the actual issue being worked around here is something that was introduced back in the Cannon Lake PCH and carried forward to subsequent PCH's.
- Extend the untweaked version of the workaround to includePCH_CNPas well. Note that sincePCH_CNPis used to represent CMP, this will apply on CML and some variants of RKL too.
- Cap the untweaked version of the workaround so that it won't apply to "fake" PCH's (i.e., DG1). The issue we're working around really is an issue in the PCH itself, not the South Display, so it shouldn't apply when there isn't a real PCH.Cc Rodrigo Vivi <[email protected]>Signed-off-by Bob Paauwe <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>Signed-off-by Matt Roper <[email protected]>--- .../drm/i915/display/intel_display_power.c | 21 +++++++++++++++++-- drivers/gpu/drm/i915/i915_irq.c | 6 ++++-- 2 files changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +0
-0@@ -5858,17 +5858,34 @@ static void intel_power_domains_verify_state(struct drm_i915_private *i915)
Quoted 15 lines
drivers/gpu/drm/i915/display/intel_display_power.c static void intel_power_domains_verify_state(struct drm_i915_private *i915) · line 5869
Quoted 13 lines
drivers/gpu/drm/i915/display/intel_display_power.c +8
-2void intel_display_power_suspend_late (struct drm_i915_private *i915) { -if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) +u32 val; + +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {bxt_enable_dc9 (i915); -else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val |=SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val);could we use
intel_de_rmwhere?
May be i had misunderstod it earlier, i thought it was your recommendation to use manual read, modify write without using intel_uncore_rmw(),
Was the actual idea to use intel_de_rmw flavour of API instead of intel_uncore_rmw? Also would it require to use at original Wa in gen11_display_irq_reset as well? Thanks,
Anshuman Gupta.
Quoted 48 lines
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display_power.c +3
-0+ } + }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_enable_pc8 (i915); + } }void intel_display_power_resume_early (struct drm_i915_private *i915) {drivers/gpu/drm/i915/display/intel_display_power.c static void intel_power_domains_verify_state(struct drm_i915_private *i915) · line 5887
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_power.c +7
-0+u32 val; +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {gen9_sanitize_dc_state (i915);bxt_disable_dc9 (i915); +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val &= ~SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val);and here?
sorry for not having spotted that sooner.
Quoted 24 lines
drivers/gpu/drm/i915/display/intel_display_power.c +1
-0+ } }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_disable_pc8 (i915); }drivers/gpu/drm/i915/i915_irq.c +4
-2@@ -3055,8 +3055,10 @@ static void gen11_display_irq_reset(struct drm_i915_private *dev_priv)if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP )GEN3_IRQ_RESET (uncore,SDE ); -/* Wa_14010685332:icl,jsl,ehl,tgl,rkl */ -if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP ) { +/* Wa_14010685332:cnp/cmp,tgp,adp */ +if (INTEL_PCH_TYPE (dev_priv) ==PCH_CNP || + (INTEL_PCH_TYPE (dev_priv) >=PCH_TGP && +INTEL_PCH_TYPE (dev_priv) <PCH_DG1 )) {intel_uncore_rmw (uncore,SOUTH_CHICKEN1 ,SBCLK_RUN_REFCLK_DIS ,SBCLK_RUN_REFCLK_DIS ); intel_uncore_rmw(uncore, SOUTH_CHICKEN1,Signature · 1 line
2.26.2
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 63 lines · Anshuman Gupta
Quoted 47 lines · Rodrigo Vivi
Quoted 46 lines · Anshuman Gupta
From: Bob Paauwe <[email protected]>
The WA specifies that we need to toggle a SDE chicken bit on and then off as the final step in preparation for s0ix entry.
Bspec: 33450 Bspec: 8402However, something is happening after we toggle the bit that causes the WA to be invalidated. This makes
dispcnlunit1_cp_xosc_clkreqactive being already in s0ix state i.eSLP_S0counter incremented. Tweaking theWa_14010685332by setting the bit on suspend and clearing it on resume turns down thedispcnlunit1_cp_xosc_clkreq. B.Spec has Documented this tweaked sequence of WA as an alternative. Let keep this tweaked WA for Gen11 platforms and keep untweaked WA for other platforms which never observed this issue.v2 (MattR):
- Change the comment on the workaround to give PCH names rather than platform names. Although the bspec is setup to list workarounds by platform, the hardware team has confirmed that the actual issue being worked around here is something that was introduced back in the Cannon Lake PCH and carried forward to subsequent PCH's.
- Extend the untweaked version of the workaround to includePCH_CNPas well. Note that sincePCH_CNPis used to represent CMP, this will apply on CML and some variants of RKL too.
- Cap the untweaked version of the workaround so that it won't apply to "fake" PCH's (i.e., DG1). The issue we're working around really is an issue in the PCH itself, not the South Display, so it shouldn't apply when there isn't a real PCH.Cc Rodrigo Vivi <[email protected]>Signed-off-by Bob Paauwe <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>Signed-off-by Matt Roper <[email protected]>--- .../drm/i915/display/intel_display_power.c | 21 +++++++++++++++++-- drivers/gpu/drm/i915/i915_irq.c | 6 ++++-- 2 files changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +0
-0@@ -5858,17 +5858,34 @@ static void intel_power_domains_verify_state(struct drm_i915_private *i915)Quoted 15 lines
drivers/gpu/drm/i915/display/intel_display_power.c static void intel_power_domains_verify_state(struct drm_i915_private *i915) · line 5869
Quoted 13 lines
drivers/gpu/drm/i915/display/intel_display_power.c +8
-2void intel_display_power_suspend_late (struct drm_i915_private *i915) { -if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) +u32 val; + +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {bxt_enable_dc9 (i915); -else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val |=SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val);could we use
intel_de_rmwhere?
Quoted 3 lines
May be i had misunderstod it earlier, i thought it was your recommendation to use manual read, modify write without using
intel_uncore_rmw(),
Was the actual idea to useintel_de_rmwflavour of API instead ofintel_uncore_rmw?
intel_de_rmw() is the exact equivalent of what's done above. As this is a PCH register I think it would be appropriate to use intel_de_*
Jani, is intel_de_* meant to be only a shortcut or are we going to enforce accessing only DE registers with it?
Quoted 1 line
Also would it require to use at original Wa in
gen11_display_irq_resetas well?
since that file is outside display/ we'd need to be very careful in using intel_de_* there.
thanks
Lucas De Marchi
Quoted 50 lines
Thanks,
Anshuman Gupta.Quoted 48 lines
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display_power.c +3
-0+ } + }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_enable_pc8 (i915); + } }void intel_display_power_resume_early (struct drm_i915_private *i915) {drivers/gpu/drm/i915/display/intel_display_power.c static void intel_power_domains_verify_state(struct drm_i915_private *i915) · line 5887
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_power.c +7
-0+u32 val; +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {gen9_sanitize_dc_state (i915);bxt_disable_dc9 (i915); +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val &= ~SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val);and here?
sorry for not having spotted that sooner.
Quoted 24 lines
drivers/gpu/drm/i915/display/intel_display_power.c +1
-0+ } }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_disable_pc8 (i915); }drivers/gpu/drm/i915/i915_irq.c +4
-3@@ -3055,8 +3055,10 @@ static void gen11_display_irq_reset(struct drm_i915_private *dev_priv)if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP )GEN3_IRQ_RESET (uncore,SDE ); -/* Wa_14010685332:icl,jsl,ehl,tgl,rkl */ -if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP ) { +/* Wa_14010685332:cnp/cmp,tgp,adp */ +if (INTEL_PCH_TYPE (dev_priv) ==PCH_CNP || + (INTEL_PCH_TYPE (dev_priv) >=PCH_TGP && +INTEL_PCH_TYPE (dev_priv) <PCH_DG1 )) {intel_uncore_rmw (uncore,SOUTH_CHICKEN1 ,SBCLK_RUN_REFCLK_DIS ,SBCLK_RUN_REFCLK_DIS ); intel_uncore_rmw(uncore, SOUTH_CHICKEN1, --2.26.2
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 68 lines · Lucas De Marchi
Quoted 63 lines · Anshuman Gupta
Quoted 47 lines · Rodrigo Vivi
Quoted 46 lines · Anshuman Gupta
From: Bob Paauwe <[email protected]>
The WA specifies that we need to toggle a SDE chicken bit on and then off as the final step in preparation for s0ix entry.
Bspec: 33450 Bspec: 8402However, something is happening after we toggle the bit that causes the WA to be invalidated. This makes
dispcnlunit1_cp_xosc_clkreqactive being already in s0ix state i.eSLP_S0counter incremented. Tweaking theWa_14010685332by setting the bit on suspend and clearing it on resume turns down thedispcnlunit1_cp_xosc_clkreq. B.Spec has Documented this tweaked sequence of WA as an alternative. Let keep this tweaked WA for Gen11 platforms and keep untweaked WA for other platforms which never observed this issue.v2 (MattR):
- Change the comment on the workaround to give PCH names rather than platform names. Although the bspec is setup to list workarounds by platform, the hardware team has confirmed that the actual issue being worked around here is something that was introduced back in the Cannon Lake PCH and carried forward to subsequent PCH's.
- Extend the untweaked version of the workaround to includePCH_CNPas well. Note that sincePCH_CNPis used to represent CMP, this will apply on CML and some variants of RKL too.
- Cap the untweaked version of the workaround so that it won't apply to "fake" PCH's (i.e., DG1). The issue we're working around really is an issue in the PCH itself, not the South Display, so it shouldn't apply when there isn't a real PCH.Cc Rodrigo Vivi <[email protected]>Signed-off-by Bob Paauwe <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>Signed-off-by Matt Roper <[email protected]>--- .../drm/i915/display/intel_display_power.c | 21 +++++++++++++++++-- drivers/gpu/drm/i915/i915_irq.c | 6 ++++-- 2 files changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +0
-0@@ -5858,17 +5858,34 @@ static void intel_power_domains_verify_state(struct drm_i915_private *i915)Quoted 15 lines
drivers/gpu/drm/i915/display/intel_display_power.c static void intel_power_domains_verify_state(struct drm_i915_private *i915) · line 5869
Quoted 13 lines
drivers/gpu/drm/i915/display/intel_display_power.c +8
-2void intel_display_power_suspend_late (struct drm_i915_private *i915) { -if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) +u32 val; + +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {bxt_enable_dc9 (i915); -else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val |=SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val);could we use
intel_de_rmwhere?Quoted 3 lines
May be i had misunderstod it earlier, i thought it was your recommendation to use manual read, modify write without using
intel_uncore_rmw(),
Was the actual idea to useintel_de_rmwflavour of API instead ofintel_uncore_rmw?
Quoted 5 lines
intel_de_rmw()is the exact equivalent of what's done above. As this is a PCH register I think it would be appropriate to use intel_de_*Jani, is intel_de_* meant to be only a shortcut or are we going to enforce accessing only DE registers with it?
The intel_de_* family of functions should only be used for DE registers, and you should assume it'll be enforced in the future.
BR,
Jani.
Quoted 67 lines
Quoted 2 lines
Also would it require to use at original Wa in
gen11_display_irq_resetas well?since that file is outside display/ we'd need to be very careful in using intel_de_* there.
thanks
Lucas De MarchiQuoted 58 lines
Thanks,
Anshuman Gupta.Quoted 48 lines
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display_power.c +3
-0+ } + }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_enable_pc8 (i915); + } }void intel_display_power_resume_early (struct drm_i915_private *i915) {drivers/gpu/drm/i915/display/intel_display_power.c static void intel_power_domains_verify_state(struct drm_i915_private *i915) · line 5887
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_power.c +7
-0+u32 val; +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {gen9_sanitize_dc_state (i915);bxt_disable_dc9 (i915); +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val &= ~SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val);and here?
sorry for not having spotted that sooner.
Quoted 24 lines
drivers/gpu/drm/i915/display/intel_display_power.c +1
-0+ } }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_disable_pc8 (i915); }drivers/gpu/drm/i915/i915_irq.c +4
-3@@ -3055,8 +3055,10 @@ static void gen11_display_irq_reset(struct drm_i915_private *dev_priv)if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP )GEN3_IRQ_RESET (uncore,SDE ); -/* Wa_14010685332:icl,jsl,ehl,tgl,rkl */ -if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP ) { +/* Wa_14010685332:cnp/cmp,tgp,adp */ +if (INTEL_PCH_TYPE (dev_priv) ==PCH_CNP || + (INTEL_PCH_TYPE (dev_priv) >=PCH_TGP && +INTEL_PCH_TYPE (dev_priv) <PCH_DG1 )) {intel_uncore_rmw (uncore,SOUTH_CHICKEN1 ,SBCLK_RUN_REFCLK_DIS ,SBCLK_RUN_REFCLK_DIS ); intel_uncore_rmw(uncore, SOUTH_CHICKEN1, --2.26.2
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Vivi, Rodrigo
maintainerQuoted 67 lines · Anshuman Gupta
Quoted 47 lines · Rodrigo Vivi
Quoted 46 lines · Anshuman Gupta
From: Bob Paauwe <[email protected]>
The WA specifies that we need to toggle a SDE chicken bit on and then off as the final step in preparation for s0ix entry.
Bspec: 33450 Bspec: 8402However, something is happening after we toggle the bit that causes the WA to be invalidated. This makes
dispcnlunit1_cp_xosc_clkreqactive being already in s0ix state i.eSLP_S0counter incremented. Tweaking theWa_14010685332by setting the bit on suspend and clearing it on resume turns down thedispcnlunit1_cp_xosc_clkreq. B.Spec has Documented this tweaked sequence of WA as an alternative. Let keep this tweaked WA for Gen11 platforms and keep untweaked WA for other platforms which never observed this issue.v2 (MattR):
- Change the comment on the workaround to give PCH names rather than platform names. Although the bspec is setup to list workarounds by platform, the hardware team has confirmed that the actual issue being worked around here is something that was introduced back in the Cannon Lake PCH and carried forward to subsequent PCH's.
- Extend the untweaked version of the workaround to includePCH_CNPas well. Note that sincePCH_CNPis used to represent CMP, this will apply on CML and some variants of RKL too.
- Cap the untweaked version of the workaround so that it won't apply to "fake" PCH's (i.e., DG1). The issue we're working around really is an issue in the PCH itself, not the South Display, so it shouldn't apply when there isn't a real PCH.Cc Rodrigo Vivi <[email protected]>Signed-off-by Bob Paauwe <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>Signed-off-by Matt Roper <[email protected]>---
.../drm/i915/display/intel_display_power.c| 21 +++++++++++++++++--drivers/gpu/drm/i915/i915_irq.c| 6 ++++--2 files changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +0
-0@@ -5858,17 +5858,34 @@ static void intel_power_domains_verify_state(struct drm_i915_private *i915)Quoted 15 lines
drivers/gpu/drm/i915/display/intel_display_power.c static void intel_power_domains_verify_state(struct drm_i915_private *i915) · line 5869
Quoted 13 lines
drivers/gpu/drm/i915/display/intel_display_power.c +8
-2void intel_display_power_suspend_late (struct drm_i915_private *i915) { -if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) +u32 val; + +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {bxt_enable_dc9 (i915); -else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val |=SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val);could we use
intel_de_rmwhere?
Quoted 2 lines
May be i had misunderstod it earlier, i thought it was your recommendation to use manual read, modify write without using
intel_uncore_rmw(),
ouch, I'm really sorry for causing this confusion here. My recommendation was for debug purposes only on the original w/a I haven't noticed it had expanded to the alternate/tweaked one. This shouldn't be needed here.
Quoted 1 line
Was the actual idea to use
intel_de_rmwflavour of API instead ofintel_uncore_rmw?
I'm assuming that both south or north registers would still be considered display engine. Jani can correct me if I'm wrong here.
But I believe _de_ is more appropriated here.
Quoted 1 line
Also would it require to use at original Wa in
gen11_display_irq_resetas well?
any modification there could be done in separated patches as needed.
Quoted 51 lines
Thanks,
Anshuman Gupta.Quoted 48 lines
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display_power.c +3
-0+ } + }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_enable_pc8 (i915); + } }void intel_display_power_resume_early (struct drm_i915_private *i915) {drivers/gpu/drm/i915/display/intel_display_power.c static void intel_power_domains_verify_state(struct drm_i915_private *i915) · line 5887
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_power.c +7
-0+u32 val; +if (INTEL_GEN (i915) >=11 ||IS_GEN9_LP (i915)) {gen9_sanitize_dc_state (i915);bxt_disable_dc9 (i915); +/* Tweaked Wa_14010685332:icp,jsp,mcc */ +if (INTEL_PCH_TYPE (i915) >=PCH_ICP &&INTEL_PCH_TYPE (i915) <=PCH_MCC ) { + val =intel_de_read (i915,SOUTH_CHICKEN1 ); + val &= ~SBCLK_RUN_REFCLK_DIS ; +intel_de_write (i915,SOUTH_CHICKEN1 , val);and here?
sorry for not having spotted that sooner.
Quoted 24 lines
drivers/gpu/drm/i915/display/intel_display_power.c +1
-0+ } }else if (IS_HASWELL (i915) ||IS_BROADWELL (i915)) {hsw_disable_pc8 (i915); }drivers/gpu/drm/i915/i915_irq.c +4
-2@@ -3055,8 +3055,10 @@ static void gen11_display_irq_reset(struct drm_i915_private *dev_priv)if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP )GEN3_IRQ_RESET (uncore,SDE ); -/* Wa_14010685332:icl,jsl,ehl,tgl,rkl */ -if (INTEL_PCH_TYPE (dev_priv) >=PCH_ICP ) { +/* Wa_14010685332:cnp/cmp,tgp,adp */ +if (INTEL_PCH_TYPE (dev_priv) ==PCH_CNP || + (INTEL_PCH_TYPE (dev_priv) >=PCH_TGP && +INTEL_PCH_TYPE (dev_priv) <PCH_DG1 )) {intel_uncore_rmw (uncore,SOUTH_CHICKEN1 ,SBCLK_RUN_REFCLK_DIS ,SBCLK_RUN_REFCLK_DIS ); intel_uncore_rmw(uncore, SOUTH_CHICKEN1,Signature · 1 line
2.26.2
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx