Skip to contentSkip to conversation

Fixing a minor typo in YAML document

PATCH In review Jihed Chaibi 4 participants 7 messages May 17, 2025 – May 22, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fixing a minor typo in YAML document

A small typo in the rockchip,rk3399 YAML document ; "less then" should become: "less than"

---
 .../bindings/memory-controllers/rockchip,rk3399-dmc.yaml    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/memory-controllers/rockchip,rk3399-dmc.yaml +3 -3
index 1f58ee99b..1a96c743e 100644
@@ -128,7 +128,7 @@ properties:
     minimum: 1000000  # In case anyone thought this was MHz.
     description:
       When the DRAM type is DDR3, this parameter defines the ODT disable
-      frequency in Hz. When the DDR frequency is less then ddr3_odt_dis_freq,
+      frequency in Hz. When the DDR frequency is less than ddr3_odt_dis_freq,
       the ODT on the DRAM side and controller side are both disabled.
 
   rockchip,ddr3_drv:
@@ -176,7 +176,7 @@ properties:
     minimum: 1000000  # In case anyone thought this was MHz.
     description:
       When the DRAM type is LPDDR3, this parameter defines then ODT disable
-      frequency in Hz. When DDR frequency is less then ddr3_odt_dis_freq, the
+      frequency in Hz. When DDR frequency is less than ddr3_odt_dis_freq, the
       ODT on the DRAM side and controller side are both disabled.
 
   rockchip,lpddr3_drv:
@@ -223,7 +223,7 @@ properties:
     minimum: 1000000  # In case anyone thought this was MHz.
     description:
       When the DRAM type is LPDDR4, this parameter defines the ODT disable
-      frequency in Hz. When the DDR frequency is less then ddr3_odt_dis_freq,
+      frequency in Hz. When the DDR frequency is less than ddr3_odt_dis_freq,
       the ODT on the DRAM side and controller side are both disabled.
 
   rockchip,lpddr4_drv:
Signature · 1 line
2.39.5
#1 lore raw
Quoted 6 lines · Jihed Chaibi

A small typo in the rockchip,rk3399 YAML document ; "less then" should become: "less than"

---
 .../bindings/memory-controllers/rockchip,rk3399-dmc.yaml    | 6 +++---

You not only skipped me as DT maintainer for this file but also skipped me as the actual subsystem maintainer.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument, so you will not CC people just because they made one commit years ago). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about b4 prep --auto-to-cc if you added new patches to the patchset.
</form letter>

Best regards,
Krzysztof

#2 lore raw

Thanks for the feedback, this fix being kind of "trivial" I didn't initially want to include everyone and thought it would end up to the main maintainer after being reviewed by the reviewers/authors of the file, sorry for that, I will make sure every maintainer is included in future patches.

On the other hand, I can confirm that I'm using the last kernel version.

Best regards,

Quoted 30 lines · Krzysztof Kozlowski
Quoted 6 lines · Jihed Chaibi

A small typo in the rockchip,rk3399 YAML document ; "less then" should become: "less than"

---
 .../bindings/memory-controllers/rockchip,rk3399-dmc.yaml    | 6 +++---

You not only skipped me as DT maintainer for this file but also skipped me as the actual subsystem maintainer.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument, so you will not CC people just because they made one commit years ago). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about b4 prep --auto-to-cc if you added new patches to the patchset.
</form letter>

Best regards,
Krzysztof

#3 lore raw
Quoted 7 lines · Jihed Chaibi

Thanks for the feedback, this fix being kind of "trivial" I didn't initially want to include everyone and thought it would end up to the main maintainer after being reviewed by the reviewers/authors of the file, sorry for that, I will make sure every maintainer is included in future patches.

On the other hand, I can confirm that I'm using the last kernel version.

Please don't top post. If you do not Cc maintainers, how is it supposed to be picked up by these maintainers?

Best regards,
Krzysztof

#4 lore raw
Quoted 11 lines · Krzysztof Kozlowski
Quoted 7 lines · Jihed Chaibi

Thanks for the feedback, this fix being kind of "trivial" I didn't initially want to include everyone and thought it would end up to the main maintainer after being reviewed by the reviewers/authors of the file, sorry for that, I will make sure every maintainer is included in future patches.

On the other hand, I can confirm that I'm using the last kernel version.

Quoted 6 lines

Please don't top post. If you do not Cc maintainers, how is it supposed to be picked up by these maintainers?

Best regards,
Krzysztof

My apologies again for not CC'ing the correct maintainers and for top posting in my previous reply. I understand the importance of both for the workflow and proper communication.

I've taken note of your feedback and will ensure I follow the recommended procedures for future submissions.

As I'm still learning the contribution process, I appreciate the guidance. Best regards,

#5 lore raw
In reply to Krzysztof Kozlowski
Quoted 2 lines · Krzysztof Kozlowski

If you do not Cc maintainers, how is it supposed
to be picked up by these maintainers?

While I understand that Jihed made an egregious error in not Cc'ing everyone listed by get_maintainers.pl, I also appreciate the irony in the subsystem maintainer complaining that this change isn't going to be picked up by the subsystem maintainer.

How _did_ you catch this patch without being Cc'ed? Care to explain to the uninitiated?

Thanks,
Brigham

Acked-by on v1 1/1
#6 lore raw
In reply to Jihed Chaibi

(CC a few more)

Hi Jihed,

Quoted 4 lines · Jihed Chaibi

A small typo in the rockchip,rk3399 YAML document ; "less then" should become: "less than"

The content is fine:

(Feel free to include that line in your patch for v2 submission, assuming you don't make massive changes.)

But you might consider looking through 'git log Documentation/devicetree/bindings/memory-controllers/' to see what kind of commit subjects are used. You should probably title it:

dt-bindings: memory-controllers: rk3399-dmc: ...

Or something similar.

Since you suggested you're still learning the contribution process, I'd suggest this as a good starter:

https://docs.kernel.org/devicetree/bindings/submitting-patches.html

and also its links out to other general documentation, like:

https://docs.kernel.org/process/submitting-patches.html

Regards,
Brian