phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties
Subsystems (2)
PATCH 1/1 phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties
property "qcom,tune-usb2-preem" is for EUSB2_TUNE_USB2_PREEM property "qcom,tune-usb2-amplitude" is for EUSB2_TUNE_IUSB2
The downstream correspondence is as follows:EUSB2_TUNE_USB2_PREEM: Tx pre-emphasis tuningEUSB2_TUNE_IUSB2: HS trasmit amplitudeEUSB2_TUNE_SQUELCH_U: Squelch detection thresholdEUSB2_TUNE_HSDISC: HS disconnect thresholdEUSB2_TUNE_EUSB_SLEW: slew rate
--- drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c +2 -2
@@ -127,13 +127,13 @@ static int eusb2_repeater_init(struct phy *phy) rptr->cfg->init_tbl[i].value);/* Override registers from devicetree values */ -if (!of_property_read_u8 (np,"qcom,tune-usb2-amplitude" , &val)) +if (!of_property_read_u8 (np,"qcom,tune-usb2-preem" , &val))regmap_write (regmap, base +EUSB2_TUNE_USB2_PREEM , val);if (!of_property_read_u8 (np,"qcom,tune-usb2-disc-thres" , &val))regmap_write (regmap, base +EUSB2_TUNE_HSDISC , val); -if (!of_property_read_u8 (np,"qcom,tune-usb2-preem" , &val)) +if (!of_property_read_u8 (np,"qcom,tune-usb2-amplitude" , &val))regmap_write (regmap, base +EUSB2_TUNE_IUSB2 , val);/* Wait for status OK */
Signature · 1 line
2.50.1
Quoted 9 lines · Pengyu Luo
property "qcom,tune-usb2-preem" is for
EUSB2_TUNE_USB2_PREEMproperty "qcom,tune-usb2-amplitude" is forEUSB2_TUNE_IUSB2The downstream correspondence is as follows:
EUSB2_TUNE_USB2_PREEM: Tx pre-emphasis tuningEUSB2_TUNE_IUSB2: HS trasmit amplitudeEUSB2_TUNE_SQUELCH_U: Squelch detection thresholdEUSB2_TUNE_HSDISC: HS disconnect thresholdEUSB2_TUNE_EUSB_SLEW: slew rate
The commit message is a bit.. dry.. but I suppose it conveys what the problem is
Quoted 4 lines
Fixes 31bc94de7602 ("phy: qualcomm: phy-qcom-eusb2-repeater: Don't zero-out registers")Signed-off-by Pengyu Luo <[email protected]>---
Konrad
Quoted 11 lines · Pengyu Luo
property "qcom,tune-usb2-preem" is for
EUSB2_TUNE_USB2_PREEMproperty "qcom,tune-usb2-amplitude" is forEUSB2_TUNE_IUSB2The downstream correspondence is as follows:
EUSB2_TUNE_USB2_PREEM: Tx pre-emphasis tuningEUSB2_TUNE_IUSB2: HS trasmit amplitudeEUSB2_TUNE_SQUELCH_U: Squelch detection thresholdEUSB2_TUNE_HSDISC: HS disconnect thresholdEUSB2_TUNE_EUSB_SLEW: slew rateFixes 31bc94de7602 ("phy: qualcomm: phy-qcom-eusb2-repeater: Don't zero-out registers")
Oh, not sure how this happened. Thanks for catching this, I do see the problem in my original commit.
Regards
Luca
Quoted 25 lines
Signed-off-by Pengyu Luo <[email protected]>--- drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c +2
-2@@ -127,13 +127,13 @@ static int eusb2_repeater_init(struct phy *phy) rptr->cfg->init_tbl[i].value);/* Override registers from devicetree values */ -if (!of_property_read_u8 (np,"qcom,tune-usb2-amplitude" , &val)) +if (!of_property_read_u8 (np,"qcom,tune-usb2-preem" , &val))regmap_write (regmap, base +EUSB2_TUNE_USB2_PREEM , val);if (!of_property_read_u8 (np,"qcom,tune-usb2-disc-thres" , &val))regmap_write (regmap, base +EUSB2_TUNE_HSDISC , val); -if (!of_property_read_u8 (np,"qcom,tune-usb2-preem" , &val)) +if (!of_property_read_u8 (np,"qcom,tune-usb2-amplitude" , &val))regmap_write (regmap, base +EUSB2_TUNE_IUSB2 , val);/* Wait for status OK */
Quoted 11 lines · Pengyu Luo
property "qcom,tune-usb2-preem" is for
EUSB2_TUNE_USB2_PREEMproperty "qcom,tune-usb2-amplitude" is forEUSB2_TUNE_IUSB2The downstream correspondence is as follows:
EUSB2_TUNE_USB2_PREEM: Tx pre-emphasis tuningEUSB2_TUNE_IUSB2: HS trasmit amplitudeEUSB2_TUNE_SQUELCH_U: Squelch detection thresholdEUSB2_TUNE_HSDISC: HS disconnect thresholdEUSB2_TUNE_EUSB_SLEW: slew rate[...]
Applied, thanks!
[1/1] phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties
commit: 942e47ab228c7dd27c2ae043c17e7aab2028082c
Best regards,
Signature · 1 line
~Vinod