Skip to contentSkip to conversation

drm: nova: depend on CONFIG_64BIT

PATCH In review Danilo Krummrich 4 participants 8 messages Oct 28, 2025 – Oct 30, 2025

Subsystems (4)
DRM drivers Rust DRM Rust nova-drm (Rust)
lore
Share & tools
lore

Danilo Krummrich

author maintainer
#0 lore raw

PATCH 1/2 drm: nova: depend on CONFIG_64BIT

nova-core already depends on CONFIG_64BIT, hence also depend on CONFIG_64BIT for nova-drm.

Signed-off-by Danilo Krummrich <[email protected]>
---
 drivers/gpu/drm/nova/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/nova/Kconfig +1 -0
index cca6a3fea879..2a70aac64d7e 100644
@@ -1,5 +1,6 @@
 config DRM_NOVA
 	tristate "Nova DRM driver"
+	depends on 64BIT
 	depends on DRM=y
 	depends on PCI
 	depends on RUST
Signature · 1 line
2.51.0
author maintainer
#1 lore raw

PATCH 2/2 drm: nova: select NOVA_CORE

The nova-drm driver does not provide any value without nova-core being selected as well, hence select NOVA_CORE.

Fixes cdeaeb9dd762 ("drm: nova-drm: add initial driver skeleton")
Signed-off-by Danilo Krummrich <[email protected]>
---
 drivers/gpu/drm/nova/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/nova/Kconfig +1 -0
index 2a70aac64d7e..3e637ad7b5ba 100644
@@ -5,6 +5,7 @@ config DRM_NOVA
 	depends on PCI
 	depends on RUST
 	select AUXILIARY_BUS
+	select NOVA_CORE
 	default n
 	help
 	  Choose this if you want to build the Nova DRM driver for Nvidia
Signature · 1 line
2.51.0
Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] drm: nova: select NOVA_CORE

In reply to Danilo Krummrich
Quoted 8 lines · Danilo Krummrich

The nova-drm driver does not provide any value without nova-core being selected as well, hence select NOVA_CORE.

Fixes cdeaeb9dd762 ("drm: nova-drm: add initial driver skeleton")
Signed-off-by Danilo Krummrich <[email protected]>
---
  drivers/gpu/drm/nova/Kconfig | 1 +
  1 file changed, 1 insertion(+)
Reviewed-by John Hubbard <[email protected]>

thanks,
John Hubbard

Quoted 13 lines
drivers/gpu/drm/nova/Kconfig +1 -0
index 2a70aac64d7e..3e637ad7b5ba 100644
@@ -5,6 +5,7 @@ config DRM_NOVA
  	depends on PCI
  	depends on RUST
  	select AUXILIARY_BUS
+	select NOVA_CORE
  	default n
  	help
  	  Choose this if you want to build the Nova DRM driver for Nvidia
#4 lore raw

Re: [PATCH 2/2] drm: nova: select NOVA_CORE

In reply to Danilo Krummrich
Quoted 2 lines · Danilo Krummrich

The nova-drm driver does not provide any value without nova-core being selected as well, hence select NOVA_CORE.

Isn't the converse also true? nova-core doesn't do anything of value without a DRM driver.

#5 lore raw

Re: [PATCH 2/2] drm: nova: select NOVA_CORE

Quoted 5 lines · Timur Tabi
Quoted 2 lines · Danilo Krummrich

The nova-drm driver does not provide any value without nova-core being selected as well, hence select NOVA_CORE.

Isn't the converse also true? nova-core doesn't do anything of value without a DRM driver.

Absolutely not true. See: vGPU on Nova. :)

thanks,

Signature · 1 line
John Hubbard
Reviewed-by on v1 1/2
#7 lore raw
In reply to Danilo Krummrich
Quoted 7 lines · Danilo Krummrich

nova-core already depends on CONFIG_64BIT, hence also depend on CONFIG_64BIT for nova-drm.

Signed-off-by Danilo Krummrich <[email protected]>
---
 drivers/gpu/drm/nova/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Reviewed-by John Hubbard <[email protected]>

thanks,
John Hubbard

Quoted 12 lines
drivers/gpu/drm/nova/Kconfig +1 -0
index cca6a3fea879..2a70aac64d7e 100644
@@ -1,5 +1,6 @@
 config DRM_NOVA
 	tristate "Nova DRM driver"
+	depends on 64BIT
 	depends on DRM=y
 	depends on PCI
 	depends on RUST