rust: miscdevice: use `pin_init::zeroed()` for C type initialization
Subsystems (2)
PATCH v2 1/1 rust: miscdevice: use `pin_init::zeroed()` for C type initialization
Replace manual zero-initialization using MaybeUninit::zeroed().assume_init() with pin_init::zeroed(). The pin_init helper provides a safer and clearer API for zero-initializing C structs without requiring an unsafe block.
Signed-off-by Atharv Dubey <[email protected]>
---
Changes in v2:
- Remove the Unwanted Comments.
rust/kernel/miscdevice.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
rust/kernel/miscdevice.rs +3 -5
@@ -20,7 +20,7 @@ seq_file::SeqFile, types::{ForeignOwnable, Opaque}, }; -use core::{marker::PhantomData , mem::MaybeUninit , pin::Pin }; +use core::{marker::PhantomData , pin::Pin };/// Options for creating a misc device. #[derive( Copy , Clone )]
@@ -32,8 +32,7 @@ pub struct MiscDeviceOptions {impl MiscDeviceOptions {/// Create a raw `struct miscdev` ready for registration. pub const fn into_raw <T :MiscDevice >(self) -> bindings::miscdevice { -// SAFETY: All zeros is valid for this C type. -let mut result: bindings::miscdevice =unsafe {MaybeUninit ::zeroed ().assume_init () }; +let mut result: bindings::miscdevice = pin_init::zeroed (); result.minor = bindings::MISC_DYNAMIC_MINOR as ffi::c_int ; result.name =crate ::str::as_char_ptr_in_const_context (self.name); result.fops =MiscdeviceVTable ::<T >::build ();
@@ -420,8 +419,7 @@ impl<T: MiscDevice> MiscdeviceVTable<T> { }else {None }, -// SAFETY: All zeros is a valid value for `bindings::file_operations`. - ..unsafe {MaybeUninit ::zeroed ().assume_init () } + ..pin_init::zeroed () };const fn build () -> &'static bindings::file_operations {
Signature · 1 line
2.43.0
Quoted 7 lines · Atharv Dubey
Replace manual zero-initialization using
MaybeUninit::zeroed().assume_init()withpin_init::zeroed(). Thepin_inithelper provides a safer and clearer API for zero-initializing C structs without requiring anunsafeblock.
Reviewed-by Alexandre Courbot <[email protected]>