Skip to contentSkip to conversation

staging: greybus: resolved checkpatch checks for fw-management.c

PATCH In review Rachit Dhar 2 participants 2 messages Feb 2

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 staging: greybus: resolved checkpatch checks for fw-management.c

Resolved two checks highlighted by checkpatch.pl:
- added comment to mutex declaration
- fixed styling issue

---
 drivers/staging/greybus/fw-management.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/greybus/fw-management.c +3 -2
index 152949c23d65..cf917ddb79c4 100644
@@ -28,7 +28,7 @@ struct fw_mgmt {
 
 	/* Common id-map for interface and backend firmware requests */
 	struct ida		id_map;
-	struct mutex		mutex;
+	struct mutex		mutex; /* protects fw_mgmt->disabled, and serializes ioctl */
 	struct completion	completion;
 	struct cdev		cdev;
 	struct device		*class_device;
@@ -434,7 +434,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd,
 			return -EFAULT;
 
 		ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
-				intf_load.load_method, intf_load.firmware_tag);
+							  intf_load.load_method,
+							  intf_load.firmware_tag);
 		if (ret)
 			return ret;
 
Signature · 1 line
2.43.0
#1 lore raw

drivers/staging/greybus/fw-management.c static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd, · line 440

Quoted 7 lines · Rachit Dhar
drivers/staging/greybus/fw-management.c +2 -1
 		ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
-				intf_load.load_method, intf_load.firmware_tag);
+							  intf_load.load_method,
+							  intf_load.firmware_tag);
 		if (ret)
 			return ret;

This should be it's own style patch. Please keep one logical change per patch.

ET