Skip to contentSkip to conversation

python3-packaging: upgrade 25.0 -> 26.0

PATCH Superseded Wang Mingyu 3 participants 4 messages Feb 3 – Feb 10

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 python3-packaging: upgrade 25.0 -> 26.0

From: Wang Mingyu <[email protected]>

Modify run-ptest.in to skip test_pylock.py.

---
 meta/recipes-devtools/python/python3-packaging/run-ptest.in     | 2 +-
 .../{python3-packaging_25.0.bb => python3-packaging_26.0.bb}    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename meta/recipes-devtools/python/{python3-packaging_25.0.bb => python3-packaging_26.0.bb} (93%)
meta/recipes-devtools/python/python3-packaging/run-ptest.in +1 -1
index 508538463b..3e43931c0f 100644
@@ -1,2 +1,2 @@
 #!/bin/sh
-pytest --automake IGNOREDTESTS
+pytest --automake IGNOREDTESTS --ignore tests/test_pylock.py
meta/recipes-devtools/python/python3-packaging_26.0.bb renamed from meta/recipes-devtools/python/python3-packaging_25.0.bb +1 -1
similarity index 93%
rename from meta/recipes-devtools/python/python3-packaging_25.0.bb
rename to meta/recipes-devtools/python/python3-packaging_26.0.bb
index 9cb5c68f58..cadf913db8 100644
@@ -3,7 +3,7 @@ HOMEPAGE = "https://github.com/pypa/packaging"
 LICENSE = "Apache-2.0 | BSD-2-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=faadaedca9251a90b205c9167578ce91"
 
-SRC_URI[sha256sum] = "d443872c98d677bf60f6a1f2f8c1cb748e8fe762d2bf9d3148b5599295b0fc4f"
+SRC_URI[sha256sum] = "00243ae351a257117b6a241061796684b084ed1c516a08c48a3f7e147a9d80b4"
 
 SRC_URI += "file://run-ptest.in"
 
Signature · 1 line
2.43.0
#1 lore raw
Quoted 4 lines · wangmy via lists.openembedded.org

From: Wang Mingyu <[email protected]>

Modify run-ptest.in to skip test_pylock.py.

Hi Wang,

Thanks for the new version.

This was reviewed during the today patch review session, and two comments were made:
- First, the commit message should explain why this test is being disabled. I know this is linked with the tomli dependency, but please say so into the commit message.
- The second point is about the disabling itself. Did you had a look at possibilities to modify the test so it can still run in oe setup?

Thanks,
Mathieu

Signature · 3 lines
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw
In reply to Wang Mingyu

meta/recipes-devtools/python/python3-packaging/run-ptest.in line 2

Quoted 2 lines · wangmy via lists.openembedded.org
meta/recipes-devtools/python/python3-packaging/run-ptest.in +1 -1
-pytest --automake IGNOREDTESTS
+pytest --automake IGNOREDTESTS --ignore tests/test_pylock.py

Instead of adding more ignores to this file, can you add this to SKIPLIST in the recipe. Add a comment explaining why we’re skipping this test so we can enable it again if toml_w appears in core, and be sure to change the musl-specific override to an append.

Thanks,
Ross

#3 lore raw
Quoted 6 lines · Ross Burton via lists.openembedded.org

meta/recipes-devtools/python/python3-packaging/run-ptest.in line 2

Quoted 2 lines · wangmy via lists.openembedded.org
meta/recipes-devtools/python/python3-packaging/run-ptest.in +1 -1
-pytest --automake IGNOREDTESTS
+pytest --automake IGNOREDTESTS --ignore tests/test_pylock.py

Instead of adding more ignores to this file, can you add this to SKIPLIST in the recipe. Add a comment explaining why we’re skipping this test so we can enable it again if toml_w appears in core, and be sure to change the musl-specific override to an append.

In the interest of expediating this upgrade as without it we have failing tests, I just did this.

Ross