Skip to contentSkip to conversation

staging: rtl8723bs: remove shadowed variable in sdio_halinit

PATCH In review Haroen Tmimi 2 participants 2 messages Feb 10 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: rtl8723bs: remove shadowed variable in sdio_halinit

The variable 'bMacPwrCtrlOn' was redeclared in the function CardEnable, shadowing a variable of the same name declared at the top of the function (line 21).

Remove the redundant 'u8' type declaration to use the existing outer variable and resolve a -Wshadow warning.

---
Changes in v3:
Resending clean patch (v2 accidentally included unrelated changes from another commit due to an oversight).

Changes in v2:
Removed incorrect blank line after the opening brace that was left behind when removing the Adapter variable.

drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/sdio_halinit.c +1 -1
index 0fa1b22fdf9a..861d5162de15 100644
@@ -30,7 +30,7 @@ static u8 CardEnable(struct adapter *padapter)
 
 		ret = HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_card_enable_flow);
 		if (ret == _SUCCESS) {
-			u8 bMacPwrCtrlOn = true;
+			bMacPwrCtrlOn = true;
 			rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn);
 		}
 	} else
Signature · 1 line
2.53.0
Reviewed-by on v3 1/1
#1 lore raw
Quoted 9 lines · Haroen Tmimi

The variable 'bMacPwrCtrlOn' was redeclared in the function CardEnable, shadowing a variable of the same name declared at the top of the function (line 21).

Remove the redundant 'u8' type declaration to use the existing outer variable and resolve a -Wshadow warning.

---

LGTM.

Thanks,

ET