thermal: add new test group
PATCH v7 1/1 thermal: add new test group
This is a new test for checking thermal interrupt events. Addresses Andrea's feedback and adds x86_pkg_temp_thermal to needs_drivers.
--- runtest/thermal | 3 + scenario_groups/default | 1 + testcases/kernel/Makefile | 1 + testcases/kernel/thermal/.gitignore | 1 + testcases/kernel/thermal/Makefile | 9 + .../kernel/thermal/thermal_interrupt_events.c | 212 ++++++++++++++++++ 6 files changed, 227 insertions(+) create mode 100644 runtest/thermal create mode 100644 testcases/kernel/thermal/.gitignore create mode 100644 testcases/kernel/thermal/Makefile create mode 100644 testcases/kernel/thermal/thermal_interrupt_events.c
runtest/thermal new file +3 -0
@@ -0,0 +1,3 @@ +# Thermal driver API +# https://docs.kernel.org/driver-api/thermal/ +thermal_interrupt_events thermal_interrupt_events
scenario_groups/default +1 -0
@@ -26,3 +26,4 @@ crypto kernel_misc uevent watchqueue +thermal
testcases/kernel/Makefile +1 -0
@@ -36,6 +36,7 @@ SUBDIRS += connectors \ sched \ security \ sound \ + thermal \ tracing \ uevents \ watchqueue \
testcases/kernel/thermal/.gitignore new file +1 -0
@@ -0,0 +1 @@ +thermal_interrupt_events
testcases/kernel/thermal/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2025, Intel Corporation. All rights reserved. +# Author:Piotr Kubaj <[email protected]> + +top_srcdir ?= ../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/thermal/thermal_interrupt_events.c new file +212 -0
212 lines not on this page · raw message
Signature · 13 lines
2.47.3 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Almost there, but there are still a couple of issues :-)
Quoted 3 lines · Piotr Kubaj
This is a new test for checking thermal interrupt events. Addresses Andrea's feedback and adds
x86_pkg_temp_thermaltoneeds_drivers.
Please provide a meaningful description in the git commit message.
This is the commit message that will be merged in our upstream, so it has to refer to the test and what it does. You can comment the patch version by typing this message after Signed-off-by and the "---" sign. Git will ignore it once patch is merged.
Quoted 182 lines
Signed-off-by Piotr Kubaj <[email protected]>--- runtest/thermal | 3 + scenario_groups/default | 1 + testcases/kernel/Makefile | 1 + testcases/kernel/thermal/.gitignore | 1 + testcases/kernel/thermal/Makefile | 9 + .../kernel/thermal/thermal_interrupt_events.c | 212 ++++++++++++++++++ 6 files changed, 227 insertions(+) create mode 100644 runtest/thermal create mode 100644 testcases/kernel/thermal/.gitignore create mode 100644 testcases/kernel/thermal/Makefile create mode 100644 testcases/kernel/thermal/thermal_interrupt_events.cruntest/thermal new file +3
-0@@ -0,0 +1,3 @@ +# Thermal driver API +# https://docs.kernel.org/driver-api/thermal/ +thermal_interrupt_events thermal_interrupt_eventsscenario_groups/default +1
-0@@ -26,3 +26,4 @@ crypto kernel_misc uevent watchqueue +thermaltestcases/kernel/Makefile +1
-0@@ -36,6 +36,7 @@ SUBDIRS += connectors \ sched \ security \ sound \ + thermal \ tracing \ uevents \ watchqueue \testcases/kernel/thermal/.gitignore new file +1
-0@@ -0,0 +1 @@ +thermal_interrupt_eventstestcases/kernel/thermal/Makefile new file +9
-0@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2025, Intel Corporation. All rights reserved. +# Author:Piotr Kubaj <[email protected]> + +top_srcdir ?= ../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mktestcases/kernel/thermal/thermal_interrupt_events.c new file +109
-0@@ -0,0 +1,212 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +/* +* Copyright (C) 2026 Intel - http://www.intel.com/ +*/ + +/*\ +* Tests the CPU package thermal sensor interface for Intel platforms. + +* Works by checking the initial count of thermal interrupts. Then it +* decreases the threshold for sending a thermal interrupt to just above +* the current temperature and runs a workload on the CPU. Finally, it restores +* the original thermal threshold and checks whether the number of thermal +* interrupts increased. +*/ + +#include "tst_safe_stdio.h" +#include "tst_test.h" + +#define RUNTIME 30 +#define SLEEP 10 +#define TEMP_INCREMENT 10 + +static bool x86_pkg_temp_tz_found, *x86_pkg_temp_tz; +static char temp_path[NAME_MAX ], trip_path[NAME_MAX ]; +static int nproc, temp_high, temp, trip, tz_counter; +static uint64_t *interrupt_init, *interrupt_later; + +static void read_interrupts (uint64_t *interrupts,const int nproc) +{ +bool interrupts_found = false; +char line[8192 ]; + +memset (interrupts,0 , nproc *sizeof (*interrupts)); +FILE *fp =SAFE_FOPEN ("/proc/interrupts" ,"r" ); + +while (fgets (line,sizeof (line), fp)) { +if (strstr (line,"Thermal event interrupts" )) { + interrupts_found = true; +char *token =strtok (line," " ); + + token =strtok (NULL ," " ); +int i =0 ; + +while (!!strncmp (token,"Thermal" ,7 )) { + interrupts[i++] =atoll (token); + token =strtok (NULL ," " ); +tst_res (TDEBUG ,"interrupts[%d]: %ld" , i -1 , interrupts[i -1 ]); + } +break ; + } + } +SAFE_FCLOSE (fp); +if (!interrupts_found) +tst_brk (TCONF ,"No Thermal event interrupts line in /proc/interrupts" ); +} + +static void setup (void ) +{ +char line[8192 ]; + + nproc =tst_ncpus (); +tst_res (TDEBUG ,"Number of logical cores: %d" , nproc); + interrupt_init =calloc (nproc,sizeof (uint64_t )); + interrupt_later =calloc (nproc,sizeof (uint64_t )); + +DIR *dir =SAFE_OPENDIR ("/sys/class/thermal/" ); +struct dirent *entry; + +while ((entry =SAFE_READDIR (dir))) { +if ((strncmp (entry->d_name,"thermal_zone" ,sizeof ("thermal_zone" ))) >0 ) + tz_counter++; + } +SAFE_CLOSEDIR (dir); +tst_res (TDEBUG ,"Found %d thermal zone(s)" , tz_counter); + +read_interrupts (interrupt_init, nproc); + + x86_pkg_temp_tz =calloc (tz_counter,sizeof (bool )); + +for (int i =0 ; i < tz_counter; i++) { +char path[NAME_MAX ]; + +snprintf (path,NAME_MAX ,"/sys/class/thermal/thermal_zone%d/type" , i); +tst_res (TDEBUG ,"Checking whether %s is x86_pkg_temp" , path); + +SAFE_FILE_SCANF (path,"%s" , line); +if (strstr (line,"x86_pkg_temp" )) { +tst_res (TDEBUG ,"Thermal zone %d uses x86_pkg_temp" , i); + x86_pkg_temp_tz[i] =1 ; + x86_pkg_temp_tz_found =1 ; + } + } + +if (!x86_pkg_temp_tz_found) +tst_brk (TCONF ,"No thermal zone uses x86_pkg_temp" ); +} + +static void *cpu_workload (double run_time) +{ +time_t start_time =time (NULL ); +int num =2 ; + +while (difftime (time (NULL ), start_time) < run_time) { +for (int i =2 ; i * i <= num; i++) { +if (num % i ==0 ) +break ; + } + num++;
testcases/kernel/thermal/thermal_interrupt_events.c line 119
Quoted 10 lines
testcases/kernel/thermal/thermal_interrupt_events.c new file +10
-0+SAFE_FILE_SCANF (temp_path,"%d" , &temp); + +if (temp > temp_high) +break ; + } +return NULL ; +} + +static void test_zone (int i) +{
Why now we have this 3 tabs indentation? This is not passing the coding style rules, where only one TAB is accepted.
testcases/kernel/thermal/thermal_interrupt_events.c line 123
Quoted 4 lines
testcases/kernel/thermal/thermal_interrupt_events.c new file +4
-0+char path[NAME_MAX ] = {0 }; +int sleep_time =SLEEP ; +double run_time =RUNTIME ; +
Kind regards,
Signature · 7 lines
Andrea Cervesato SUSE QE Automation Engineer Linux [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp