Skip to contentSkip to conversation

staging: rtl8723bs: fix CamelCase variable name

PATCH Superseded Rivka Bukchin 2 participants 2 messages Feb 26 – Feb 27 Staging

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: rtl8723bs: fix CamelCase variable name

Rename pHT_info_ie to ht_info_ie to address checkpatch warning.

---
v2:
- Use full real name in Signed-off-by and From fields

---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +3 -3
index 67197c7d4..9ab2219cd 100644
@@ -802,7 +802,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	int ret = _SUCCESS;
 	u8 *p;
 	u8 *pHT_caps_ie = NULL;
-	u8 *pHT_info_ie = NULL;
+	u8 *ht_info_ie = NULL;
 	struct sta_info *psta = NULL;
 	u16 cap, ht_cap = false;
 	uint ie_len = 0;
@@ -1060,7 +1060,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 		       &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p && ie_len > 0)
-		pHT_info_ie = p;
+		ht_info_ie = p;
 
 	switch (network_type) {
 	case WIRELESS_11B:
@@ -1097,7 +1097,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 		HT_caps_handler(padapter, (struct ndis_80211_var_ie *)pHT_caps_ie);
 
-		HT_info_handler(padapter, (struct ndis_80211_var_ie *)pHT_info_ie);
+		HT_info_handler(padapter, (struct ndis_80211_var_ie *)ht_info_ie);
 	}
 
 	pbss_network->length =
Signature · 1 line
2.34.1
#1 lore raw
Quoted 11 lines · Rivka Bukchin

Rename pHT_info_ie to ht_info_ie to address checkpatch warning.

---
v2:
- Use full real name in Signed-off-by and From fields

---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

You have a few issues with your commit body, please view this on how to send a v2:

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

drivers/staging/rtl8723bs/core/rtw_ap.c int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) · line 804

Quoted 3 lines
drivers/staging/rtl8723bs/core/rtw_ap.c +0 -0
 	int ret = _SUCCESS;
 	u8 *p;
 	u8 *pHT_caps_ie = NULL;

It'd be nice if you changed this to snake_case too.

Thanks,

ET