Skip to contentSkip to conversation

staging: rtl8723bs: fix function header alignment

PATCH In review Dhyan K Prajapati 2 participants 3 messages Feb 25 – Feb 27 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: fix function header alignment

fixed header alignment in hal_sdio_get_cmd_addr_8723b that violated kernel coding style, cleaned the header by pulling arguments onto the same line.

---
 drivers/staging/rtl8723bs/hal/sdio_ops.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/staging/rtl8723bs/hal/sdio_ops.c +2 -6
index c9cb20c61..18eb50c6f 100644
@@ -13,12 +13,8 @@
 /*  */
 /*  Creadted by Roger, 2011.01.31. */
 /*  */
-static void hal_sdio_get_cmd_addr_8723b(
-	struct adapter *adapter,
-	u8 device_id,
-	u32 addr,
-	u32 *cmdaddr
-)
+static void hal_sdio_get_cmd_addr_8723b(struct adapter *adapter, u8 device_id,
+					u32 addr, u32 *cmdaddr)
 {
 	switch (device_id) {
 	case SDIO_LOCAL_DEVICE_ID:
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Dhyan K Prajapati

fixed header alignment in hal_sdio_get_cmd_addr_8723b that violated kernel coding style, cleaned the header by pulling arguments onto the same line.

---

LGTM. However, next time say parameter alignment instead of header. Was a little confused what you meant at first until I read your subject line.

Thanks,

ET

#2 lore raw
Quoted 12 lines · Ethan Tidmore
Quoted 6 lines · Dhyan K Prajapati

fixed header alignment in hal_sdio_get_cmd_addr_8723b that violated kernel coding style, cleaned the header by pulling arguments onto the same line.

---

LGTM. However, next time say parameter alignment instead of header. Was a little confused what you meant at first until I read your subject line.

Quoted 5 lines

Thanks,

ET

seconded, i'll keep that in mind the next time.