Skip to contentSkip to conversation

staging: vme_user: remove unimplemented #if 0 code blocks

PATCH In review Albab Hasan 2 participants 2 messages Feb 28 – Mar 1

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vme_user: remove unimplemented #if 0 code blocks

Remove dead code in #if 0 blocks from struct vme_master and struct vme_slave. these were never implemented or compiled in.

checkpatch.pl reports:

WARNING: Consider removing the code enclosed by this #if 0 and its #endif

No functional changes.

---
 drivers/staging/vme_user/vme_user.h | 10 ----------
 1 file changed, 10 deletions(-)
drivers/staging/vme_user/vme_user.h +0 -10
index 19ecb05781cc..9e010974351d 100644
@@ -14,11 +14,6 @@ struct vme_master {
 	__u32 aspace;		/* Address Space */
 	__u32 cycle;		/* Cycle properties */
 	__u32 dwidth;		/* Maximum Data Width */
-#if 0
-	char prefetchenable;		/* Prefetch Read Enable State */
-	int prefetchsize;		/* Prefetch Read Size (Cache Lines) */
-	char wrpostenable;		/* Write Post State */
-#endif
 } __packed;
 
 /*
@@ -35,11 +30,6 @@ struct vme_slave {
 	__u64 size;		/* Window Size */
 	__u32 aspace;		/* Address Space */
 	__u32 cycle;		/* Cycle properties */
-#if 0
-	char wrpostenable;		/* Write Post State */
-	char rmwlock;			/* Lock PCI during RMW Cycles */
-	char data64bitcapable;		/* non-VMEbus capable of 64-bit Data */
-#endif
 } __packed;
 
 struct vme_irq_id {
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Albab Hasan

Remove dead code in #if 0 blocks from struct vme_master and struct vme_slave. these were never implemented or compiled in.

Quoted 8 lines

checkpatch.pl reports:

WARNING: Consider removing the code enclosed by this #if 0 and its #endif

No functional changes.

---

LGTM.

Thanks,

ET