drm/bridge: chipone-icn6211: remove bridge when chipone_dsi_host_attach fails
Subsystems (4)
PATCH 1/1 drm/bridge: chipone-icn6211: remove bridge when chipone_dsi_host_attach fails
when chipone_dsi_host_attach fails in chipone_i2c_probe remove drm bridge before return
Signed-off-by Osama Abdelkader <[email protected]>
--- drivers/gpu/drm/bridge/chipone-icn6211.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/bridge/chipone-icn6211.c +4 -1
@@ -760,7 +760,10 @@ static int chipone_i2c_probe(struct i2c_client *client)drm_bridge_add (&icn->bridge); -return chipone_dsi_host_attach (icn); + ret =chipone_dsi_host_attach (icn); +if (ret) +drm_bridge_remove (&icn->bridge); +return ret; }static void chipone_dsi_remove (struct mipi_dsi_device *dsi)
Signature · 1 line
2.43.0
Luca Ceresoli
reviewerQuoted 13 lines · Osama Abdelkader
when
chipone_dsi_host_attachfails inchipone_i2c_proberemove drm bridge before returnSigned-off-by Osama Abdelkader <[email protected]>--- drivers/gpu/drm/bridge/chipone-icn6211.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/gpu/drm/bridge/chipone-icn6211.c +0
-0
drivers/gpu/drm/bridge/chipone-icn6211.c static int chipone_i2c_probe(struct i2c_client *client) · line 767
Quoted 9 lines
drivers/gpu/drm/bridge/chipone-icn6211.c +4
-1@@ -760,7 +760,10 @@ static int chipone_i2c_probe(struct i2c_client *client)drm_bridge_add (&icn->bridge); -return chipone_dsi_host_attach (icn); + ret =chipone_dsi_host_attach (icn); +if (ret) +drm_bridge_remove (&icn->bridge); +return ret; }
You can simply switch to devm_drm_bridge_add().
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com