Skip to contentSkip to conversation

staging: rtl8723bs: remove redundant else block in sdio_halinit.c

PATCH In review Demir Özdemir 4 participants 4 messages Apr 20 – Apr 27 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: remove redundant else block in sdio_halinit.c

Remove redundant else block after a return statement within if block in rtl8723bs_hal_init(). Identified through checkpatch as a warning.

---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/hal/sdio_halinit.c +3 -3
index f2f73c65a636..809f07855bb8 100644
@@ -654,11 +654,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 		padapter->bFWReady = false;
 		pHalData->fw_ractrl = false;
 		return ret;
-	} else {
-		padapter->bFWReady = true;
-		pHalData->fw_ractrl = true;
 	}
 
+	padapter->bFWReady = true;
+	pHalData->fw_ractrl = true;
+
 	rtl8723b_InitializeFirmwareVars(padapter);
 
 /* 	SIC_Init(padapter); */
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Demir Özdemir
Quoted 17 lines · Demir Özdemir

Remove redundant else block after a return statement within if block in rtl8723bs_hal_init(). Identified through checkpatch as a warning.

---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/hal/sdio_halinit.c +0 -1
index f2f73c65a636..809f07855bb8 100644
@@ -654,11 +654,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 		padapter->bFWReady = false;
 		pHalData->fw_ractrl = false;
 		return ret;
-	} else {

drivers/staging/rtl8723bs/hal/sdio_halinit.c u32 rtl8723bs_hal_init(struct adapter *padapter) · line 664

Quoted 10 lines
drivers/staging/rtl8723bs/hal/sdio_halinit.c +3 -2
-		padapter->bFWReady = true;
-		pHalData->fw_ractrl = true;
 	}
 
+	padapter->bFWReady = true;
+	pHalData->fw_ractrl = true;
+
 	rtl8723b_InitializeFirmwareVars(padapter);
 
 /* 	SIC_Init(padapter); */

LGTM.

Best regards,
Luka Gejak

maintainer
#3 lore raw
In reply to Demir Özdemir
Quoted 32 lines · Demir Özdemir

Remove redundant else block after a return statement within if block in rtl8723bs_hal_init(). Identified through checkpatch as a warning.

---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/hal/sdio_halinit.c +3 -3
index f2f73c65a636..809f07855bb8 100644
@@ -654,11 +654,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 		padapter->bFWReady = false;
 		pHalData->fw_ractrl = false;
 		return ret;
-	} else {
-		padapter->bFWReady = true;
-		pHalData->fw_ractrl = true;
 	}
 
+	padapter->bFWReady = true;
+	pHalData->fw_ractrl = true;
+
 	rtl8723b_InitializeFirmwareVars(padapter);
 
 /* 	SIC_Init(padapter); */
Signature · 1 line
2.53.0

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch did not apply to any known trees that Greg is in control of. Possibly this is because you made it against Linus's tree, not the linux-next tree, which is where all of the development for the next version of the kernel is at. Please refresh your patch against the linux-next tree, or even better yet, the development tree specified in the MAINTAINERS file for the subsystem you are submitting a patch for, and resend it.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot