Skip to contentSkip to conversation

typofix: fix spelling mistakes in comments and test description

PATCH In review Hardik Kumar 3 participants 4 messages Aug 30 – Aug 31

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 typofix: fix spelling mistakes in comments and test description

Fix spelling errors in the following places:

versioncmp.c:           "fractionnal" -> "fractional"
git-gui/git-gui.sh:     "occurence"   -> "occurrence"
t/t0022-crlf-rename.sh: "similiarity" -> "similarity"
---
 git-gui/git-gui.sh     | 2 +-
 t/t0022-crlf-rename.sh | 2 +-
 versioncmp.c           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
git-gui/git-gui.sh +1 -1
index 15dd2b3a84..cc8a05517a 100755
@@ -109,7 +109,7 @@ foreach p [split $env(PATH) $_path_sep] {
 	if {[file pathtype $p] ne {absolute}} {
 		continue
 	}
-	# Keep only the first occurence of any duplicates.
+	# Keep only the first occurrence of any duplicates.
 	set norm_p [file normalize $p]
 	dict set _path_seen $norm_p 1
 }
t/t0022-crlf-rename.sh +1 -1
index 9bd863a970..328c6e5903 100755
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-test_description='ignore CR in CRLF sequence while computing similiarity'
+test_description='ignore CR in CRLF sequence while computing similarity'
 
 . ./test-lib.sh
 
versioncmp.c +1 -1
index 3a81b17bc1..f1e451755a 100644
@@ -15,7 +15,7 @@
 
 /*
  * states: S_N: normal, S_I: comparing integral part, S_F: comparing
- * fractionnal parts, S_Z: idem but with leading Zeroes only
+ * fractional parts, S_Z: idem but with leading Zeroes only
  */
 #define  S_N    0x0
 #define  S_I    0x3

---
base-commit: c73e85354c275c9d409b26445089bc16940fc527
change-id: 20260830-typo-fea59ea5a02a

#1 lore raw
Quoted 8 lines · Hardik Kumar

Fix spelling errors in the following places:

versioncmp.c:           "fractionnal" -> "fractional"
git-gui/git-gui.sh:     "occurence"   -> "occurrence"
t/t0022-crlf-rename.sh: "similiarity" -> "similarity"

These changes LGTM.

#2 lore raw
In reply to Hardik Kumar
Quoted 5 lines · Hardik Kumar

Fix spelling errors in the following places:

versioncmp.c:           "fractionnal" -> "fractional"
git-gui/git-gui.sh:     "occurence"   -> "occurrence"
t/t0022-crlf-rename.sh: "similiarity" -> "similarity"

git-gui comes from a separate project and a different rule applies to patches in that area. See Documentation/SubmittingPatches for details, but the consequences to the rule are:

- Any patch to git-gui (or gitk) would not be a patch against a path inside git-gui/ (or gitk-git/) directory.

- A patch message to git-gui (or gitk) would not contain any patches to other parts of the system.

#3 lore raw
Quoted 12 lines · Junio C Hamano
Quoted 5 lines · Hardik Kumar

Fix spelling errors in the following places:

versioncmp.c:           "fractionnal" -> "fractional"
git-gui/git-gui.sh:     "occurence"   -> "occurrence"
t/t0022-crlf-rename.sh: "similiarity" -> "similarity"

git-gui comes from a separate project and a different rule applies to patches in that area. See Documentation/SubmittingPatches for details, but the consequences to the rule are:

Quoted 5 lines

- Any patch to git-gui (or gitk) would not be a patch against a path inside git-gui/ (or gitk-git/) directory.

- A patch message to git-gui (or gitk) would not contain any patches to other parts of the system.

Thank you I had skipped over that.

I had sent another patch with the "versioncmp" prefix which only edits the core files to fix the typos.

Thanks.

Hardik