Skip to contentSkip to conversation

ptest-packagelists.inc: disable gnutls for RISCV64

PATCH In review João Marcos Costa 3 participants 6 messages Sep 18 – Sep 22

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ptest-packagelists.inc: disable gnutls for RISCV64

Timeouts have been observed (very frequently in the past weeks) in the autobuilder, and a bug [1] was filed at Bugzilla.

For now, it's not quite clear what specific test case is causing the timeout.

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=16162

---
 meta/conf/distro/include/ptest-packagelists.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/conf/distro/include/ptest-packagelists.inc +2 -2
index 79e27f617b..9b264657bb 100644
@@ -163,8 +163,8 @@ PTESTS_PROBLEMS:append:riscv32 = " lttng-tools strace"
 PTESTS_SLOW:append:libc-musl = " libc-test"
 
 # These tests don't yet pass for riscv64
-PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd"
-PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd"
+PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd gnutls"
+PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd gnutls"
 
 # These tests don't yet pass for musl qemuarm64
 PTESTS_SLOW:remove:libc-musl:qemuarm64 = "strace perl gnutls glib-2.0"
Signature · 1 line
2.55.0
#1 lore raw
Quoted 6 lines · João Marcos Costa

Timeouts have been observed (very frequently in the past weeks) in the autobuilder, and a bug [1] was filed at Bugzilla.

For now, it's not quite clear what specific test case is causing the timeout.

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=16162

I think that this change is too aggressive given what we actually see in the AB issue - most of the logs seem to show a timeout at the same part of the ptest run, after the 'mini-record' test. I'm doing some investigation locally to see what the heaviest tests in the suite are, so that we can more surgically disable only the problematic ones instead.

Trevor

Quoted 21 lines
---
 meta/conf/distro/include/ptest-packagelists.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/conf/distro/include/ptest-packagelists.inc +2 -2
index 79e27f617b..9b264657bb 100644
@@ -163,8 +163,8 @@ PTESTS_PROBLEMS:append:riscv32 = " lttng-tools strace"
 PTESTS_SLOW:append:libc-musl = " libc-test"
 
 # These tests don't yet pass for riscv64
-PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd"
-PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd"
+PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd gnutls"
+PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd gnutls"
 
 # These tests don't yet pass for musl qemuarm64
 PTESTS_SLOW:remove:libc-musl:qemuarm64 = "strace perl gnutls glib-2.0"
#2 lore raw

Hello, Trevor

Quoted 6 lines · Trevor Gamblin
Quoted 5 lines · João Marcos Costa

Timeouts have been observed (very frequently in the past weeks) in the autobuilder, and a bug [1] was filed at Bugzilla.

For now, it's not quite clear what specific test case is causing the timeout.

Quoted 7 lines
Quoted 1 line

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=16162

I think that this change is too aggressive given what we actually see in the AB issue - most of the logs seem to show a timeout at the same part of the ptest run, after the 'mini-record' test. I'm doing some investigation locally to see what the heaviest tests in the suite are, so that we can more surgically disable only the problematic ones instead.

Well, it was agressive indeed, considering how frequent this one became in the past few weeks, and I was not 100% happy to send this patch either way.

So thanks a lot for narrowing it down. I can send a v2 later this week to handle the worst offenders (as per your comment in bugzilla).

Quoted 34 lines

Trevor

Quoted 11 lines
---
  meta/conf/distro/include/ptest-packagelists.inc | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
meta/conf/distro/include/ptest-packagelists.inc +0 -0
index 79e27f617b..9b264657bb 100644

meta/conf/distro/include/ptest-packagelists.inc PTESTS_PROBLEMS:append:riscv32 = " lttng-tools strace" · line 170

Quoted 10 lines
meta/conf/distro/include/ptest-packagelists.inc +2 -2
@@ -163,8 +163,8 @@ PTESTS_PROBLEMS:append:riscv32 = " lttng-tools strace"
  PTESTS_SLOW:append:libc-musl = " libc-test"
 
  # These tests don't yet pass for riscv64
-PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd"
-PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd"
+PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd gnutls"
+PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd gnutls"
 
  # These tests don't yet pass for musl qemuarm64
  PTESTS_SLOW:remove:libc-musl:qemuarm64 = "strace perl gnutls glib-2.0"

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#246347): https://lists.openembedded.org/g/openembedded-core/message/246347
Mute This Topic: https://lists.openembedded.org/mt/121311542/8026893
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 2 lines
Best regards,
João Marcos Costa
#3 lore raw
Quoted 17 lines · Joao Marcos Costa

Hello, Trevor

Quoted 6 lines · Trevor Gamblin
Quoted 5 lines · João Marcos Costa

Timeouts have been observed (very frequently in the past weeks) in the autobuilder, and a bug [1] was filed at Bugzilla.

For now, it's not quite clear what specific test case is causing the timeout.

Quoted 7 lines
Quoted 1 line

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=16162

I think that this change is too aggressive given what we actually see in the AB issue - most of the logs seem to show a timeout at the same part of the ptest run, after the 'mini-record' test. I'm doing some investigation locally to see what the heaviest tests in the suite are, so that we can more surgically disable only the problematic ones instead.

Quoted 6 lines

Well, it was agressive indeed, considering how frequent this one became in the past few weeks, and I was not 100% happy to send this patch either way.

So thanks a lot for narrowing it down. I can send a v2 later this week to handle the worst offenders (as per your comment in bugzilla).

Sure! Let me know if I can help.

Quoted 29 lines
Quoted 29 lines

Trevor

Quoted 21 lines
---
  meta/conf/distro/include/ptest-packagelists.inc | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
meta/conf/distro/include/ptest-packagelists.inc +2 -2
index 79e27f617b..9b264657bb 100644
@@ -163,8 +163,8 @@ PTESTS_PROBLEMS:append:riscv32 = " lttng-tools strace"
  PTESTS_SLOW:append:libc-musl = " libc-test"
 
  # These tests don't yet pass for riscv64
-PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd"
-PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd"
+PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd gnutls"
+PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd gnutls"
 
  # These tests don't yet pass for musl qemuarm64
  PTESTS_SLOW:remove:libc-musl:qemuarm64 = "strace perl gnutls glib-2.0"
#4 lore raw
In reply to João Marcos Costa
Quoted 6 lines · João Marcos Costa

Timeouts have been observed (very frequently in the past weeks) in the autobuilder, and a bug [1] was filed at Bugzilla.

For now, it's not quite clear what specific test case is causing the timeout.

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=16162

After modifying the gnutls ptest so that it outputs rough test durations (in ms) and collecting a log, these seem to be the worst offenders:

|tgamblin@megalith ~/workspace/ypbuilds/poky-qemuriscv64/layers/openembedded-core (master)$ grep 'PASS:' tests.log | sort -t'(' -k2 -n -r
|PASS: mini-record-2 (187880ms)
|PASS: record-retvals (145390ms)
|PASS: rng-op-key (63820ms)
|PASS: rng-op-random (63330ms)
|PASS: rng-op-nonce (63260ms)
|PASS: dtls-rehandshake-cert (61360ms)
|PASS: dtls-rehandshake-cert-2 (61230ms)
|PASS: dtls-rehandshake-anon (61030ms)
|PASS: mini-loss-time (60130ms)
|PASS: mini-dtls-hello-verify-48 (30050ms)
|PASS: tls12-ffdhe (27790ms)
|PASS: x509sign-verify-rsa (18460ms)
|PASS: x509sign-verify-ecdsa (16050ms)

mini-record-2 is longest runtime by far, and is consistent with what the Bugzilla bug shows - if you build core-image-ptest-gnutls and watch the output, mini-record-2 comes after mini-record, which is the last on that runs before the AB log timeouts. Do you want to submit a narrower patch, which conditionally disables mini-record-2 and record-retvals for riscv64?

Quoted 21 lines
---
 meta/conf/distro/include/ptest-packagelists.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/conf/distro/include/ptest-packagelists.inc +2 -2
index 79e27f617b..9b264657bb 100644
@@ -163,8 +163,8 @@ PTESTS_PROBLEMS:append:riscv32 = " lttng-tools strace"
 PTESTS_SLOW:append:libc-musl = " libc-test"
 
 # These tests don't yet pass for riscv64
-PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd"
-PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd"
+PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd gnutls"
+PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace lttng-tools python3-numpy perl glib-2.0 zstd gnutls"
 
 # These tests don't yet pass for musl qemuarm64
 PTESTS_SLOW:remove:libc-musl:qemuarm64 = "strace perl gnutls glib-2.0"
#5 lore raw
Quoted 30 lines · Trevor Gamblin via lists.openembedded.org
Quoted 4 lines · João Marcos Costa

Timeouts have been observed (very frequently in the past weeks) in the autobuilder, and a bug [1] was filed at Bugzilla.

For now, it's not quite clear what specific test case is causing the

timeout.

Quoted 2 lines

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=16162

After modifying the gnutls ptest so that it outputs rough test durations (in ms)
and collecting a log, these seem to be the worst offenders:

|tgamblin@megalith ~/workspace/ypbuilds/poky-qemuriscv64/layers/openembedded-core (master)$ grep 'PASS:' tests.log | sort -t'(' -k2 -n -r

|PASS: mini-record-2 (187880ms)
|PASS: record-retvals (145390ms)
|PASS: rng-op-key (63820ms)
|PASS: rng-op-random (63330ms)
|PASS: rng-op-nonce (63260ms)
|PASS: dtls-rehandshake-cert (61360ms)
|PASS: dtls-rehandshake-cert-2 (61230ms)
|PASS: dtls-rehandshake-anon (61030ms)
|PASS: mini-loss-time (60130ms)
|PASS: mini-dtls-hello-verify-48 (30050ms)
|PASS: tls12-ffdhe (27790ms)
|PASS: x509sign-verify-rsa (18460ms)
|PASS: x509sign-verify-ecdsa (16050ms)
Quoted 9 lines

mini-record-2 is longest runtime by far, and is consistent with what the Bugzilla bug shows - if you build core-image-ptest-gnutls and watch the output,
mini-record-2 comes after mini-record, which is the last on that runs before the
AB log timeouts. Do you want to submit a narrower patch, which conditionally
disables mini-record-2 and record-retvals for riscv64?

Or relax the timeout a bit

Quoted 41 lines

Review

Quoted 7 lines
---
 meta/conf/distro/include/ptest-packagelists.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/meta/conf/distro/include/ptest-packagelists.inc

meta/conf/distro/include/ptest-packagelists.inc PTESTS_PROBLEMS:append:riscv32 = " lttng-tools

Quoted 4 lines

index 79e27f617b..9b264657bb 100644

meta/conf/distro/include/ptest-packagelists.inc +0 -0
@@ -163,8 +163,8 @@ PTESTS_PROBLEMS:append:riscv32 = " lttng-tools

strace"

meta/conf/distro/include/ptest-packagelists.inc PTESTS_PROBLEMS:append:riscv32 = " lttng-tools strace"

Quoted 4 lines
meta/conf/distro/include/ptest-packagelists.inc +0 -1
 PTESTS_SLOW:append:libc-musl = " libc-test"
 
 # These tests don't yet pass for riscv64
-PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools

python3-numpy perl glib-2.0 zstd"

meta/conf/distro/include/ptest-packagelists.inc PTESTS_PROBLEMS:append:riscv32 = " lttng-tools · line 167

Quoted 1 line
meta/conf/distro/include/ptest-packagelists.inc +0 -1
-PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace

lttng-tools python3-numpy perl glib-2.0 zstd"

meta/conf/distro/include/ptest-packagelists.inc PTESTS_PROBLEMS:append:riscv32 = " lttng-tools · line 166

Quoted 1 line
meta/conf/distro/include/ptest-packagelists.inc +1 -0
+PTESTS_SLOW:remove:riscv64 = "tcl tcl8 python3-cffi strace lttng-tools

python3-numpy perl glib-2.0 zstd gnutls"

meta/conf/distro/include/ptest-packagelists.inc PTESTS_PROBLEMS:append:riscv32 = " lttng-tools · line 167

Quoted 1 line
meta/conf/distro/include/ptest-packagelists.inc +1 -0
+PTESTS_PROBLEMS:append:riscv64 = " tcl tcl8 python3-cffi strace

lttng-tools python3-numpy perl glib-2.0 zstd gnutls"

meta/conf/distro/include/ptest-packagelists.inc PTESTS_PROBLEMS:append:riscv32 = " lttng-tools strace" · line 170

Quoted 3 lines
meta/conf/distro/include/ptest-packagelists.inc +0 -0
 # These tests don't yet pass for musl qemuarm64
 PTESTS_SLOW:remove:libc-musl:qemuarm64 = "strace perl gnutls glib-2.0"

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#246367):
https://lists.openembedded.org/g/openembedded-core/message/246367
Mute This Topic: https://lists.openembedded.org/mt/121311542/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-