util-linux: ptest: fix flock test timeout on slow targets
PATCH 1/1 util-linux: ptest: fix flock test timeout on slow targets
The flock ptest starts flock in the background and waits only 1 second (hardcoded "timeout 1s") for flock to spawn its child, polling with "pgrep -P". That budget only covers process startup, so it depends on host speed. Under emulation (qemuriscv64 under TCG) spawning bash and flock can exceed 1s, so the child is not seen in time and the test aborts with "timeout waiting for flock child", failing intermittently on the autobuilder.
Backport a test fix that raises the timeout to 30s. The poll loop exits as soon as the child appears, so fast hosts are unaffected; it only adds headroom on slow/emulated targets.
[YOCTO #16425]
--- meta/recipes-core/util-linux/util-linux.inc | 1 + ...ncrease-wait-for-flock-child-timeout.patch | 38 +++++++++++++++++++ 2 files changed, 39 insertions(+) create mode 100644 meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patch
meta/recipes-core/util-linux/util-linux.inc +1 -0
@@ -23,6 +23,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-lin file://0004-libmount-use-USE_LIBMOUNT_MOUNTFD_SUPPORT-for-idmap-h.patch \ file://0005-tools-add-non-newmount.conf-config-gen-profile.patch \ file://0006-tests-lsfd-accept-rw-mode-for-mmap-ed-packet-socket-.patch \ + file://0001-tests-flock-increase-wait-for-flock-child-timeout.patch \ " SRC_URI[sha256sum] = "66ac7c0e725278eb2b039e3104f2c91119341d941b41bac7a285c695f940bd57"
meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patch new file +38 -0
@@ -0,0 +1,38 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Pratik Farkase <[email protected]> +Date: Wed, 17 Sep 2026 12:00:00 +0000 +Subject: [PATCH] tests: flock: increase "wait for flock child" timeout + +The flock test launches "flock ... bash -c '... sleep 3 ...'" in the +background and then waits for flock to spawn its child using a hardcoded +"timeout 1s" around a pgrep poll loop. That 1 second only covers process +startup, so it is purely a function of host speed. Under emulation (e.g. +qemuriscv64 under TCG) spawning the shell and flock can exceed 1s, so +pgrep does not see the child in time and the test aborts with "timeout +waiting for flock child", failing intermittently. + +Increase the timeout to 30s. The loop exits as soon as the child +appears, so this does not slow down fast hosts; it only adds headroom on +slow/emulated targets. + +Upstream-Status: Submitted [https://github.com/util-linux/util-linux/pull/4639] + +Signed-off-by: Pratik Farkase <[email protected]> +--- + tests/ts/flock/flock | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tests/ts/flock/flock b/tests/ts/flock/flock +--- a/tests/ts/flock/flock ++++ b/tests/ts/flock/flock +@@ -65,7 +65,7 @@ + ts_die "unable to run flock" + fi + # the lock should be established when flock has a child +- timeout 1s bash -c "while ! pgrep -P $pid >/dev/null; do sleep 0.1 ;done" \ ++ timeout 30s bash -c "while ! pgrep -P $pid >/dev/null; do sleep 0.1 ;done" \ + || ts_die "timeout waiting for flock child" + + ts_init_subtest "${subtest_prefix}non-block" +-- +2.43.0
Signature · 1 line
2.43.0
Quoted 8 lines · Pratik Farkase
The flock ptest starts flock in the background and waits only 1 second (hardcoded "timeout 1s") for flock to spawn its child, polling with "pgrep -P". That budget only covers process startup, so it depends on host speed. Under emulation (qemuriscv64 under TCG) spawning bash and flock can exceed 1s, so the child is not seen in time and the test aborts with "timeout waiting for flock child", failing intermittently on the autobuilder.
Quoted 5 lines
Backport a test fix that raises the timeout to 30s. The poll loop exits as soon as the child appears, so fast hosts are unaffected; it only adds headroom on slow/emulated targets.
[YOCTO #16425]
Thanks for this. Hopefully, upstream takes the patch. Out of curiosity, why did you choose 30s? Did you test with shorter timeouts (e.g. 10s)?
Trevor
Quoted 64 lines
Signed-off-by Pratik Farkase <[email protected]>--- meta/recipes-core/util-linux/util-linux.inc | 1 + ...ncrease-wait-for-flock-child-timeout.patch | 38 +++++++++++++++++++ 2 files changed, 39 insertions(+) create mode 100644 meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patchmeta/recipes-core/util-linux/util-linux.inc +1
-0@@ -23,6 +23,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-lin file://0004-libmount-use-USE_LIBMOUNT_MOUNTFD_SUPPORT-for-idmap-h.patch \ file://0005-tools-add-non-newmount.conf-config-gen-profile.patch \ file://0006-tests-lsfd-accept-rw-mode-for-mmap-ed-packet-socket-.patch \ + file://0001-tests-flock-increase-wait-for-flock-child-timeout.patch \ " SRC_URI[sha256sum] = "66ac7c0e725278eb2b039e3104f2c91119341d941b41bac7a285c695f940bd57"meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patch new file +38
-0@@ -0,0 +1,38 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Pratik Farkase <[email protected]> +Date: Wed, 17 Sep 2026 12:00:00 +0000 +Subject: [PATCH] tests: flock: increase "wait for flock child" timeout + +The flock test launches "flock ... bash -c '... sleep 3 ...'" in the +background and then waits for flock to spawn its child using a hardcoded +"timeout 1s" around a pgrep poll loop. That 1 second only covers process +startup, so it is purely a function of host speed. Under emulation (e.g. +qemuriscv64 under TCG) spawning the shell and flock can exceed 1s, so +pgrep does not see the child in time and the test aborts with "timeout +waiting for flock child", failing intermittently. + +Increase the timeout to 30s. The loop exits as soon as the child +appears, so this does not slow down fast hosts; it only adds headroom on +slow/emulated targets. + +Upstream-Status: Submitted [https://github.com/util-linux/util-linux/pull/4639] + +Signed-off-by: Pratik Farkase <[email protected]> +--- + tests/ts/flock/flock | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tests/ts/flock/flock b/tests/ts/flock/flock +--- a/tests/ts/flock/flock ++++ b/tests/ts/flock/flock +@@ -65,7 +65,7 @@ + ts_die "unable to run flock" + fi + # the lock should be established when flock has a child +- timeout 1s bash -c "while ! pgrep -P $pid >/dev/null; do sleep 0.1 ;done" \ ++ timeout 30s bash -c "while ! pgrep -P $pid >/dev/null; do sleep 0.1 ;done" \ + || ts_die "timeout waiting for flock child" + + ts_init_subtest "${subtest_prefix}non-block" +-- +2.43.0
Hi TRevor,
30s was just a conservative margin, not a tuned value. I didn't benchmark 10s. The timeout only bounds a pgrep poll loop that exits as soon as flock's child appears, so it's near-instant on a healthy host; the ceiling only needs to clear worst-case startup under loaded TCG emulation, where 1s was too tight. Since it's filed upstream as PR #4639, I'd rather let the exact value settle there and keep the OE backport in sync.
Best Regards,
Pratik
________________________________________
From: Trevor Gamblin <[email protected]>
Sent: Thursday, September 17, 2026 5:40 PM
To: Pratik Farkase; [email protected]
Cc: [email protected]
Subject: Re: [OE-core][PATCH v1] util-linux: ptest: fix flock test timeout on slow targets
Quoted 8 lines · Pratik Farkase
The flock ptest starts flock in the background and waits only 1 second (hardcoded "timeout 1s") for flock to spawn its child, polling with "pgrep -P". That budget only covers process startup, so it depends on host speed. Under emulation (qemuriscv64 under TCG) spawning bash and flock can exceed 1s, so the child is not seen in time and the test aborts with "timeout waiting for flock child", failing intermittently on the autobuilder.
Quoted 5 lines
Backport a test fix that raises the timeout to 30s. The poll loop exits as soon as the child appears, so fast hosts are unaffected; it only adds headroom on slow/emulated targets.
[YOCTO #16425]
Thanks for this. Hopefully, upstream takes the patch. Out of curiosity, why did you choose 30s? Did you test with shorter timeouts (e.g. 10s)?
Trevor
Quoted 64 lines
Signed-off-by Pratik Farkase <[email protected]>--- meta/recipes-core/util-linux/util-linux.inc | 1 + ...ncrease-wait-for-flock-child-timeout.patch | 38 +++++++++++++++++++ 2 files changed, 39 insertions(+) create mode 100644 meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patchmeta/recipes-core/util-linux/util-linux.inc +1
-0@@ -23,6 +23,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-lin file://0004-libmount-use-USE_LIBMOUNT_MOUNTFD_SUPPORT-for-idmap-h.patch \ file://0005-tools-add-non-newmount.conf-config-gen-profile.patch \ file://0006-tests-lsfd-accept-rw-mode-for-mmap-ed-packet-socket-.patch \ + file://0001-tests-flock-increase-wait-for-flock-child-timeout.patch \ " SRC_URI[sha256sum] = "66ac7c0e725278eb2b039e3104f2c91119341d941b41bac7a285c695f940bd57"meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patch new file +38
-0@@ -0,0 +1,38 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Pratik Farkase <[email protected]> +Date: Wed, 17 Sep 2026 12:00:00 +0000 +Subject: [PATCH] tests: flock: increase "wait for flock child" timeout + +The flock test launches "flock ... bash -c '... sleep 3 ...'" in the +background and then waits for flock to spawn its child using a hardcoded +"timeout 1s" around a pgrep poll loop. That 1 second only covers process +startup, so it is purely a function of host speed. Under emulation (e.g. +qemuriscv64 under TCG) spawning the shell and flock can exceed 1s, so +pgrep does not see the child in time and the test aborts with "timeout +waiting for flock child", failing intermittently. + +Increase the timeout to 30s. The loop exits as soon as the child +appears, so this does not slow down fast hosts; it only adds headroom on +slow/emulated targets. + +Upstream-Status: Submitted [https://github.com/util-linux/util-linux/pull/4639] + +Signed-off-by: Pratik Farkase <[email protected]> +--- + tests/ts/flock/flock | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tests/ts/flock/flock b/tests/ts/flock/flock +--- a/tests/ts/flock/flock ++++ b/tests/ts/flock/flock +@@ -65,7 +65,7 @@ + ts_die "unable to run flock" + fi + # the lock should be established when flock has a child +- timeout 1s bash -c "while ! pgrep -P $pid >/dev/null; do sleep 0.1 ;done" \ ++ timeout 30s bash -c "while ! pgrep -P $pid >/dev/null; do sleep 0.1 ;done" \ + || ts_die "timeout waiting for flock child" + + ts_init_subtest "${subtest_prefix}non-block" +-- +2.43.0
Quoted 47 lines · Pratik Farkase via lists.openembedded.org
The flock ptest starts flock in the background and waits only 1 second (hardcoded "timeout 1s") for flock to spawn its child, polling with "pgrep -P". That budget only covers process startup, so it depends on host speed. Under emulation (qemuriscv64 under TCG) spawning bash and flock can exceed 1s, so the child is not seen in time and the test aborts with "timeout waiting for flock child", failing intermittently on the autobuilder.
Backport a test fix that raises the timeout to 30s. The poll loop exits as soon as the child appears, so fast hosts are unaffected; it only adds headroom on slow/emulated targets.
[YOCTO #16425]
Signed-off-by Pratik Farkase <[email protected]>--- meta/recipes-core/util-linux/util-linux.inc | 1 + ...ncrease-wait-for-flock-child-timeout.patch | 38 +++++++++++++++++++ 2 files changed, 39 insertions(+) create mode 100644 meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patchmeta/recipes-core/util-linux/util-linux.inc +1
-0@@ -23,6 +23,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-lin file://0004-libmount-use-USE_LIBMOUNT_MOUNTFD_SUPPORT-for-idmap-h.patch \ file://0005-tools-add-non-newmount.conf-config-gen-profile.patch \ file://0006-tests-lsfd-accept-rw-mode-for-mmap-ed-packet-socket-.patch \ + file://0001-tests-flock-increase-wait-for-flock-child-timeout.patch \ " SRC_URI[sha256sum] = "66ac7c0e725278eb2b039e3104f2c91119341d941b41bac7a285c695f940bd57"meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patch new file +8
-0@@ -0,0 +1,38 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Pratik Farkase <[email protected]> +Date: Wed, 17 Sep 2026 12:00:00 +0000 +Subject: [PATCH] tests: flock: increase "wait for flock child" timeout + +The flock test launches "flock ... bash -c '... sleep 3 ...'" in the +background and then waits for flock to spawn its child using a hardcoded +"timeout 1s" around a pgrep poll loop. That 1 second only covers process
meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patch line 18
Quoted 10 lines
meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patch new file +10
-0+startup, so it is purely a function of host speed. Under emulation (e.g. +qemuriscv64 under TCG) spawning the shell and flock can exceed 1s, so +pgrep does not see the child in time and the test aborts with "timeout +waiting for flock child", failing intermittently. + +Increase the timeout to 30s. The loop exits as soon as the child +appears, so this does not slow down fast hosts; it only adds headroom on +slow/emulated targets. + +Upstream-Status: Submitted [https://github.com/util-linux/util-linux/pull/4639]
Hello,
This patch is now merged (Congrats :)) Can you send a follow-up patch to update de Upstream-Status?
Thanks!
Signature · 2 lines
Yoann Congal Smile ECS
Hi Yoann,
It's on the list as a separate patch: https://lists.openembedded.org/g/openembedded-core/message/246869
Best Regards,
Pratik
________________________________________
From: Yoann Congal <[email protected]>
Sent: Thursday, September 24, 2026 5:05 PM
To: Pratik Farkase; [email protected]
Cc: [email protected]
Subject: Re: [OE-core][PATCH v1] util-linux: ptest: fix flock test timeout on slow targets
Quoted 47 lines · Pratik Farkase via lists.openembedded.org
The flock ptest starts flock in the background and waits only 1 second (hardcoded "timeout 1s") for flock to spawn its child, polling with "pgrep -P". That budget only covers process startup, so it depends on host speed. Under emulation (qemuriscv64 under TCG) spawning bash and flock can exceed 1s, so the child is not seen in time and the test aborts with "timeout waiting for flock child", failing intermittently on the autobuilder.
Backport a test fix that raises the timeout to 30s. The poll loop exits as soon as the child appears, so fast hosts are unaffected; it only adds headroom on slow/emulated targets.
[YOCTO #16425]
Signed-off-by Pratik Farkase <[email protected]>--- meta/recipes-core/util-linux/util-linux.inc | 1 + ...ncrease-wait-for-flock-child-timeout.patch | 38 +++++++++++++++++++ 2 files changed, 39 insertions(+) create mode 100644 meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patchmeta/recipes-core/util-linux/util-linux.inc +1
-0@@ -23,6 +23,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-lin file://0004-libmount-use-USE_LIBMOUNT_MOUNTFD_SUPPORT-for-idmap-h.patch \ file://0005-tools-add-non-newmount.conf-config-gen-profile.patch \ file://0006-tests-lsfd-accept-rw-mode-for-mmap-ed-packet-socket-.patch \ + file://0001-tests-flock-increase-wait-for-flock-child-timeout.patch \ " SRC_URI[sha256sum] = "66ac7c0e725278eb2b039e3104f2c91119341d941b41bac7a285c695f940bd57"meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patch new file +8
-0@@ -0,0 +1,38 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Pratik Farkase <[email protected]> +Date: Wed, 17 Sep 2026 12:00:00 +0000 +Subject: [PATCH] tests: flock: increase "wait for flock child" timeout + +The flock test launches "flock ... bash -c '... sleep 3 ...'" in the +background and then waits for flock to spawn its child using a hardcoded +"timeout 1s" around a pgrep poll loop. That 1 second only covers process
meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patch line 18
Quoted 10 lines
meta/recipes-core/util-linux/util-linux/0001-tests-flock-increase-wait-for-flock-child-timeout.patch new file +10
-0+startup, so it is purely a function of host speed. Under emulation (e.g. +qemuriscv64 under TCG) spawning the shell and flock can exceed 1s, so +pgrep does not see the child in time and the test aborts with "timeout +waiting for flock child", failing intermittently. + +Increase the timeout to 30s. The loop exits as soon as the child +appears, so this does not slow down fast hosts; it only adds headroom on +slow/emulated targets. + +Upstream-Status: Submitted [https://github.com/util-linux/util-linux/pull/4639]
Hello,
This patch is now merged (Congrats :)) Can you send a follow-up patch to update de Upstream-Status?
Thanks!
--
Yoann Congal
Smile ECS