Skip to contentSkip to conversation

bzImage target for PPC

PATCH In review Rusty Russell 6 participants 9 messages Sep 17, 2001 – Sep 18, 2001

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bzImage target for PPC

All the instructions (including the message after "make oldconfig") talk about "make bzImage". So I suppose it's best to give in to this rampant Intelism 8)

arch/ppc/Makefile renamed from arch/ppc/Makefile.~1~ +3 -0
@@ -87,6 +87,9 @@
 
 BOOT_TARGETS = zImage zImage.initrd znetboot znetboot.initrd
 
+# All the instructions talk about "make bzImage".
+bzImage: zImage
+
 $(BOOT_TARGETS): $(CHECKS) vmlinux
 	@$(MAKEBOOT) $@
 

Rusty.
--
Premature optmztion is rt of all evl. --DK

#1 lore raw
Quoted 3 lines · Rusty Russell

All the instructions (including the message after "make oldconfig") talk about "make bzImage". So I suppose it's best to give in to this rampant Intelism 8)

What about 'bzlilo' and 'zlilo' ? Those are mentioned too. Linus, please don't apply this. Hopefully Paul will say that too. :)

Quoted 11 lines
arch/ppc/Makefile renamed from arch/ppc/Makefile.~1~ +3 -0
@@ -87,6 +87,9 @@
 
 BOOT_TARGETS = zImage zImage.initrd znetboot znetboot.initrd
 
+# All the instructions talk about "make bzImage".
+bzImage: zImage
+
 $(BOOT_TARGETS): $(CHECKS) vmlinux
 	@$(MAKEBOOT) $@
Signature · 2 lines
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
#2 lore raw

In message <[email protected]> you writ e:

Quoted 8 lines · Rusty Russell
Quoted 4 lines

All the instructions (including the message after "make oldconfig") talk about "make bzImage". So I suppose it's best to give in to this rampant Intelism 8)

What about 'bzlilo' and 'zlilo' ? Those are mentioned too. Linus, please don't apply this. Hopefully Paul will say that too. :)

Actually, Paul suggested it. As for bzlilo, that's even a problem on non-lilo Intel (and should be subsumed by make install). Of course, make install should be moved to the top level Makefile, but that's another battle.

Cheers,
Rusty.
--
Premature optmztion is rt of all evl. --DK

#3 lore raw
Quoted 4 lines · Rusty Russell

Actually, Paul suggested it. As for bzlilo, that's even a problem on non-lilo Intel (and should be subsumed by make install). Of course, make install should be moved to the top level Makefile, but that's another battle.

Welll.... Shouldnt we fight it then?
What is holding us back from deciding on a limited number of supported and implemented make targets and making these fast(e.g. moving install to top level)? This would then become a part of kbuild2.5

"Let's party like it's 2.4.99"

Quoted 3 lines

Cheers,
Rusty.

Cheers!

#4 lore raw
In reply to Rusty Russell
Quoted 3 lines · Allan Sandfeld

What is holding us back from deciding on a limited number of supported and implemented make targets and making these fast(e.g. moving install to top level)? This would then become a part of kbuild2.5

Eh? What kbuild2.5 does, last time I looked at it, is let the user pick from the list of targets for that arch, for 'installable'. This looks great from the PPC side, which has ~6 targets for this right now. No need to limit to some 'generic' names or limit the number. For 2.4, I don't think we should bother to do anything, except _maybe_ change the text after oldconfig/whatnot to say 'zImage or bzImage and then install' Or nuke it all together.

Signature · 2 lines
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
#5 lore raw
In reply to Tom Rini
Quoted 8 lines · Rusty Russell

In message <[email protected]> you writ e:

Quoted 6 lines · Rusty Russell
Quoted 4 lines

All the instructions (including the message after "make oldconfig") talk about "make bzImage". So I suppose it's best to give in to this rampant Intelism 8)

Quoted 7 lines
Quoted 2 lines

What about 'bzlilo' and 'zlilo' ? Those are mentioned too. Linus, please don't apply this. Hopefully Paul will say that too. :)

Actually, Paul suggested it. As for bzlilo, that's even a problem on non-lilo Intel (and should be subsumed by make install). Of course, make install should be moved to the top level Makefile, but that's another battle.

Bah. I thought when that text got changed around a bit ages ago (didn't it used to say something just 'zImage') there was a bit of a thread/flame and it was just left as an intel-ism, and hopefully users would still do the 'right' thing. Anyhow, the original patch just makes bzImage not fail as an unknown target, but not actually do anything. The 'correct' way I _think_ would be:
arch/ppc/Makefile:
bzImage: $(CHECKS) vmlinux

	@$(MAKEBOOT) zImage

Or print out a msg saying to use 'zImage'. :)

Signature · 2 lines
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
#6 lore raw
In reply to Rusty Russell
Followup to:  <[email protected]>
By author:    Tom Rini <[email protected]>
In newsgroup: linux.dev.kernel
Quoted 4 lines

What about 'bzlilo' and 'zlilo' ? Those are mentioned too. Linus, please don't apply this. Hopefully Paul will say that too. :)

They're mentioned, and generally wrong -- the proper way to install a kernel is "make install", since that one can be customized for the appropriate system using /sbin/installkernel.

-hpa

Signature · 3 lines
<[email protected]> at work, <[email protected]> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt	<[email protected]>
#7 lore raw
In reply to Rusty Russell
Quoted 9 lines · Tom Rini
Quoted 3 lines · Rusty Russell

All the instructions (including the message after "make oldconfig") talk about "make bzImage". So I suppose it's best to give in to this rampant Intelism 8)

What about 'bzlilo' and 'zlilo' ? Those are mentioned too. Linus, please don't apply this. Hopefully Paul will say that too. :)

I'm with Tom on this. Don't apply this one. Additionally in the ppc64 camp we like our ppc brothern have been sticking with zImage. It seems (least to me) that it's reasonably documented in ppc and ppc64 circles. Perhaps tho it would be appropriate to add a short little blurb in the README for the various architectures.

Quoted 2 lines

Tom Rini (TR1265)
http://gate.crashing.org/~trini/

Regards,

Tom

Signature · 6 lines
Tom Gall - PPC64 Code Monkey     "Where's the ka-boom? There was
Linux Technology Center           supposed to be an earth
(w) [email protected]         shattering ka-boom!"
(w) 507-253-4558                 -- Marvin Martian
(h) [email protected]
http://www.ibm.com/linux/ltc/projects/ppc
#8 lore raw
Quoted 6 lines · Tom Gall

Tom Rini wrote:
I'm with Tom on this. Don't apply this one. Additionally in the ppc64 camp we like our ppc brothern have been sticking with zImage. It seems (least to me) that it's reasonably documented in ppc and ppc64 circles. Perhaps tho it would be appropriate to add a short little blurb in the README for the various architectures.

Probably not worth changing. In 2.5 the type of kernel to build is an architecture dependent config option. Users just make installable to build and make install to install, kbuild 2.5 takes care of everything else.