Skip to contentSkip to conversation

hugetlb: make private functions static

PATCH In review William Lee Irwin III 2 participants 2 messages Nov 6, 2002

lore
Share & tools
lore

William Lee Irwin III

author
#0 lore raw

PATCH 7/7 hugetlb: make private functions static

This patch makes various private structures and procedures static.

 hugetlbpage.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
arch/i386/mm/hugetlbpage.c +4 -4
diff -urpN hugetlbfs-2.5.46-5/arch/i386/mm/hugetlbpage.c hugetlbfs-2.5.46-6/arch/i386/mm/hugetlbpage.c
@@ -18,16 +18,16 @@
 #include <asm/tlb.h>
 #include <asm/tlbflush.h>
 
-long    htlbpagemem = 0;
+static long    htlbpagemem;
 int     htlbpage_max;
-long    htlbzone_pages;
+static long    htlbzone_pages;
 
 struct vm_operations_struct hugetlb_vm_ops;
 static LIST_HEAD(htlbpage_freelist);
 static spinlock_t htlbpage_lock = SPIN_LOCK_UNLOCKED;
 
 #define MAX_ID 	32
-struct htlbpagekey {
+static struct htlbpagekey {
 	struct inode *in;
 	int key;
 } htlbpagek[MAX_ID];

@@ -109,7 +109,7 @@ static int anon_get_hugetlb_page(struct 
 	return page ? 1 : -1;
 }
 
-int make_hugetlb_pages_present(unsigned long addr, unsigned long end, int flags)
+static int make_hugetlb_pages_present(unsigned long addr, unsigned long end, int flags)
 {
 	int write;
 	struct mm_struct *mm = current->mm;
#1 lore raw

hugetlb: No coalescing of adjacent mappings in /proc/pid/maps

Hello William

I noticed a small problem if a process allocates hugetlb memory using

sys_alloc_hugepages(0, 0, 4*1024*1024, PROT_READ|PROT_WRITE, 0) ;

If this process uses a lot of hugetlb pages, its /proc/pid/maps contains one entry for each mapping.

Could it be possible to coalesce all consecutive mappings onto only one ? As standard mmap() calls do ?