: Ext2/3 updates: Fix/simplify alternate superblock logic
PATCH 1/4 : Ext2/3 updates: Fix/simplify alternate superblock logic
Fix/simplify alternate superblock logic
Fix bugs when specifying an alternate superblock as a mount option; not all of the cases where a alternate sb was specified and a block device whose hardware blocksize was not 1024 worked correctly (and the failure mode was different for ext2 and ext3). The code has been tightened up and simplified, so that it is right in all of the permutations of these cases.
ext2/super.c | 12 +++++------- ext3/super.c | 10 ++++------ 2 files changed, 9 insertions(+), 13 deletions(-)
fs/ext2/super.c +5 -7
@@ -548,9 +548,9 @@struct buffer_head * bh;struct ext2_sb_info * sbi;struct ext2_super_block * es; -unsigned long block, sb_block =1 ; -unsigned long logic_sb_block =get_sb_block (&data); -unsigned long offset =0 ; +unsigned long block, sb_block =get_sb_block (&data); +unsigned long logic_sb_block; +unsigned long offset;unsigned long def_mount_opts;int blocksize =BLOCK_SIZE ;int db_count;
@@ -579,10 +579,8 @@* If the superblock doesn't start on a hardware sector boundary, * calculate the offset. */ -if (blocksize !=BLOCK_SIZE ) { - logic_sb_block = (sb_block*BLOCK_SIZE ) / blocksize; - offset = (sb_block*BLOCK_SIZE ) % blocksize; - } + logic_sb_block = (sb_block*BLOCK_SIZE ) / blocksize; + offset = (sb_block*BLOCK_SIZE ) % blocksize;if (!(bh =sb_bread (sb, logic_sb_block))) {printk ("EXT2-fs: unable to read superblock\n" );
fs/ext3/super.c +4 -6
@@ -1000,8 +1000,8 @@struct ext3_super_block *es =0 ;struct ext3_sb_info *sbi;unsigned long sb_block =get_sb_block (&data); -unsigned long block, logic_sb_block =1 ; -unsigned long offset =0 ; +unsigned long block, logic_sb_block; +unsigned long offset;unsigned long journal_inum =0 ;unsigned long def_mount_opts;int blocksize;
@@ -1033,10 +1033,8 @@* The ext3 superblock will not be buffer aligned for other than 1kB * block sizes. We need to calculate the offset from buffer start. */ -if (blocksize !=EXT3_MIN_BLOCK_SIZE ) { - logic_sb_block = (sb_block *EXT3_MIN_BLOCK_SIZE ) / blocksize; - offset = (sb_block *EXT3_MIN_BLOCK_SIZE ) % blocksize; - } + logic_sb_block = (sb_block *EXT3_MIN_BLOCK_SIZE ) / blocksize; + offset = (sb_block *EXT3_MIN_BLOCK_SIZE ) % blocksize;if (!(bh =sb_bread (sb, logic_sb_block))) {printk (KERN_ERR "EXT3-fs: unable to read superblock\n" );