befs (5/5): debugging code cleanup
PATCH 1/1 befs (5/5): debugging code cleanup
- Reduce stack usage.
- Kill useless duplication of error and warning messages when debug is on. Old behaviour was:
...
BeFS(hda1): ---> befs_fill_super()
BeFS(hda1): No write support. Marking filesystem read-only BeFS(hda1): No write support. Marking filesystem read-only
...
===== fs/befs/debug.c 1.2 vs edited =====
fs/befs/debug.c +24 -7
@@ -29,22 +29,29 @@ befs_error(const struct super_block *sb, const char *fmt, ...) { va_list args; -char err_buf[ERRBUFSIZE ]; - +char *err_buf = (char *)kmalloc (ERRBUFSIZE ,GFP_KERNEL ); +if (err_buf ==NULL ) { +printk (KERN_ERR "could not allocate %d bytes\n" ,ERRBUFSIZE ); +return ; + } +va_start (args, fmt);vsnprintf (err_buf,ERRBUFSIZE , fmt, args);va_end (args);printk (KERN_ERR "BeFS(%s): %s\n" , sb->s_id, err_buf); - -befs_debug (sb, err_buf); +kfree (err_buf); }void befs_warning (const struct super_block *sb,const char *fmt, ...) {va_list args; -char err_buf[ERRBUFSIZE ]; +char *err_buf = (char *)kmalloc (ERRBUFSIZE ,GFP_KERNEL ); +if (err_buf ==NULL ) { +printk (KERN_ERR "could not allocate %d bytes\n" ,ERRBUFSIZE ); +return ; + }va_start (args, fmt);vsnprintf (err_buf,ERRBUFSIZE , fmt, args);
@@ -52,7 +59,7 @@printk (KERN_WARNING "BeFS(%s): %s\n" , sb->s_id, err_buf); -befs_debug (sb, err_buf); +kfree (err_buf); }void
@@ -61,15 +68,25 @@#ifdef CONFIG_BEFS_DEBUG va_list args; -char err_buf[ERRBUFSIZE ]; +char *err_buf =NULL ;if (BEFS_SB (sb)->mount_opts.debug) { + err_buf = (char *)kmalloc (ERRBUFSIZE ,GFP_KERNEL ); +if (err_buf ==NULL ) { +printk (KERN_ERR "could not allocate %d bytes\n" , +ERRBUFSIZE ); +return ; + } +va_start (args, fmt);vsnprintf (err_buf,ERRBUFSIZE , fmt, args);va_end (args);printk (KERN_DEBUG "BeFS(%s): %s\n" , sb->s_id, err_buf); + +kfree (err_buf); } +#endif //CONFIG_BEFS_DEBUG }
Signature · 3 lines
Best regards,
Sergey S. Kostyliov <[email protected]>
Public PGP key: http://sysadminday.org.ru/rathamahata.asc