Skip to contentSkip to conversation

ec3104: replace schedule_timeout() with msleep()

PATCH In review [email protected] 1 participant 1 message Sep 1, 2004 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 20/25 ec3104: replace schedule_timeout() with msleep()

I would appreciate any comments from the janitor@sternweltens list. This is one (of a few) places where I had to make a decision to set the state before the call to

schedule_timeout();

This of course affected any decision to replace the code with msleep() or not. Please inform if the other state from the one I used is desired.

Thanks,
Nish

Description: Uses msleep() instead of schedule_timeout() to guarantee the task delays at least the desired time amount.

---

 linux-2.6.9-rc1-bk7-max/drivers/char/ec3104_keyb.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/char/ec3104_keyb.c renamed from drivers/char/ec3104_keyb.c~msleep-drivers_char_ec3104_keyb +1 -1
diff -puN drivers/char/ec3104_keyb.c~msleep-drivers_char_ec3104_keyb drivers/char/ec3104_keyb.c
@@ -412,7 +412,7 @@ static void ec3104_keyb_clear_state(void
 	k->last_msr = 0;
 
 	for (;;) {
-		schedule_timeout(HZ/10);
+		msleep(100);
 
 		msr = ctrl_inb(EC3104_SER4_MSR);
 	

_