pcwd: replace schedule_timeout() with msleep()
PATCH 24/25 pcwd: replace schedule_timeout() with msleep()
I would appreciate any comments from the janitor@sternweltens list. This is one (of many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.
Thanks,
Nish
Description: Uses msleep() instead of schedule_timeout() to guarantee the task delays at least the desired time amount.
Signed-off-by Nishanth Aravamudan <[email protected]>
Signed-off-by Maximilian Attems <[email protected]>
---
linux-2.6.9-rc1-bk7-max/drivers/char/watchdog/pcwd.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-)
drivers/char/watchdog/pcwd.c renamed from drivers/char/watchdog/pcwd.c~msleep-drivers_char_watchdog_pcwd +1 -2
@@ -859,8 +859,7 @@ static int __init pcwd_checkcard(int bas/* Not an 'ff' from a floating bus, so must be a card! */ for (i =0 ; i <4 ; ++i) { -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (HZ /2 ); +msleep (500 ); last_port0 = port0; last_port1 = port1;
_