net/mac89x0: replace schedule_timeout() with msleep()
Subsystems (2)
PATCH 10/16 net/mac89x0: replace schedule_timeout() with msleep()
I would appreciate any comments from the janitor@sternweltens list. This is one (of many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.
Thanks,
Nish
Description: Replace schedule_timeout() with msleep() to guarantee the task delays for the desired time.
Signed-off-by Nishanth Aravamudan <[email protected]>
Signed-off-by Maximilian Attems <[email protected]>
---
linux-2.6.9-rc1-bk7-max/drivers/net/mac89x0.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-)
drivers/net/mac89x0.c renamed from drivers/net/mac89x0.c~msleep-drivers_net_max89x0 +1 -2
@@ -308,8 +308,7 @@ void __init reset_chip(struct net_devicewritereg (dev, PP_SelfCTL,readreg (dev, PP_SelfCTL) |POWER_ON_RESET );/* wait 30 ms */ - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (30 *HZ /1000 ); +msleep (30 );/* Wait until the chip is reset */ reset_start_time = jiffies;
_