Skip to contentSkip to conversation

net/ns83820: replace schedule_timeout() with msleep()

PATCH New [email protected] 1 participant 1 message Sep 1, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 12/16 net/ns83820: replace schedule_timeout() with msleep()

Quoted 2 lines · Benjamin LaHaise

The commit message doesn't seem correspond to the actual patch. What are you trying to "fix"?

Thanks for catching this - it was another typo. Please find the corrected patch below.

-Nish

Description: Uses msleep() instead of schedule_timeout() to guarantee the task delays the desired time.

---

 linux-2.6.9-rc1-bk7-max/drivers/net/ns83820.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)
drivers/net/ns83820.c renamed from drivers/net/ns83820.c~msleep-drivers_net_ns83820 +1 -2
diff -puN drivers/net/ns83820.c~msleep-drivers_net_ns83820 drivers/net/ns83820.c
@@ -1960,8 +1960,7 @@ static int __devinit ns83820_init_one(st
 	if (reset_phy) {
 		printk(KERN_INFO "%s: resetting phy\n", ndev->name);
 		writel(dev->CFG_cache | CFG_PHY_RST, dev->base + CFG);
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout((HZ+99)/100);
+		msleep(10);
 		writel(dev->CFG_cache, dev->base + CFG);
 	}
 

_