Skip to contentSkip to conversation

radio/miropcm20-rds: replace schedule_timeout() with msleep()

PATCH In review [email protected] 1 participant 1 message Sep 1, 2004 Media (V4L/DVB)

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 8/14 radio/miropcm20-rds: replace schedule_timeout() with msleep()

I would appreciate any comments from the janitor@sternweltens list.

Thanks,
Nish

Description: Uses msleep() instead of schedule_timeout() so the task is guaranteed to delay the desired time.

Signed-off-by Nishanth Aravamudan <[email protected]>
Signed-off-by Maximilian Attems <[email protected]>

---

 linux-2.6.9-rc1-bk7-max/drivers/media/radio/miropcm20-rds.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/media/radio/miropcm20-rds.c renamed from drivers/media/radio/miropcm20-rds.c~msleep-drivers_media_radio-miropcm20-rds +2 -2
diff -puN drivers/media/radio/miropcm20-rds.c~msleep-drivers_media_radio-miropcm20-rds drivers/media/radio/miropcm20-rds.c
@@ -14,6 +14,7 @@
 #include <linux/slab.h>
 #include <linux/fs.h>
 #include <linux/miscdevice.h>
+#include <linux/delay.h>
 #include <asm/uaccess.h>
 #include "miropcm20-rds-core.h"
 

@@ -60,8 +61,7 @@ static ssize_t rds_f_read(struct file *f
 	char c;
 	char bits[8];
 
-	current->state=TASK_UNINTERRUPTIBLE;
-	schedule_timeout(2*HZ);
+	msleep(2000);
 	aci_rds_cmd(RDS_STATUS, &c, 1);
 	print_matrix(&c, bits);
 	if (copy_to_user(buffer, bits, 8))

_