Skip to contentSkip to conversation

char/isicom: replace schedule_timeout() with msleep_interruptible()

PATCH In review [email protected] 1 participant 1 message Sep 24, 2004 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 11/26 char/isicom: replace schedule_timeout() with msleep_interruptible()

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

---

 linux-2.6.9-rc2-bk7-max/drivers/char/isicom.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)
drivers/char/isicom.c renamed from drivers/char/isicom.c~msleep_interruptible-drivers_char_isicom +1 -2
diff -puN drivers/char/isicom.c~msleep_interruptible-drivers_char_isicom drivers/char/isicom.c
@@ -1126,11 +1126,10 @@ static void isicom_close(struct tty_stru
 	port->tty = NULL;
 	if (port->blocked_open) {
 		if (port->close_delay) {
-			set_current_state(TASK_INTERRUPTIBLE);
 #ifdef ISICOM_DEBUG			
 			printk(KERN_DEBUG "ISICOM: scheduling until time out.\n");
 #endif			
-			schedule_timeout(port->close_delay);
+			msleep_interruptible(jiffies_to_msecs(port->close_delay));
 		}
 		wake_up_interruptible(&port->open_wait);
 	}	

_