Skip to contentSkip to conversation

char/pcxx: replace schedule_timeout() with msleep_interruptible()

PATCH In review [email protected] 1 participant 1 message Sep 23, 2004 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 16/26 char/pcxx: replace schedule_timeout() with msleep_interruptible()

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

Looks fine to me.

---

 linux-2.6.9-rc2-bk7-max/drivers/char/pcxx.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)
drivers/char/pcxx.c renamed from drivers/char/pcxx.c~msleep_interruptible-drivers_char_pcxx +1 -2
diff -puN drivers/char/pcxx.c~msleep_interruptible-drivers_char_pcxx drivers/char/pcxx.c
@@ -555,8 +555,7 @@ static void pcxe_close(struct tty_struct
 #endif
 		if(info->blocked_open) {
 			if(info->close_delay) {
-				current->state = TASK_INTERRUPTIBLE;
-				schedule_timeout(info->close_delay);
+				msleep_interruptible(jiffies_to_msecs(info->close_delay));
 			}
 			wake_up_interruptible(&info->open_wait);
 		}

_